<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/buildstream.git/tests/sandboxes/missing-command.py, branch bschubert/python38</title>
<subtitle>gitlab.com: buildstream/buildstream.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/'/>
<entry>
<title>Reformat code using Black</title>
<updated>2019-11-14T21:21:06+00:00</updated>
<author>
<name>Chandan Singh</name>
<email>csingh43@bloomberg.net</email>
</author>
<published>2019-11-11T17:07:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=122177153b14664a0e4fed85aa4f22b87cfabf56'/>
<id>122177153b14664a0e4fed85aa4f22b87cfabf56</id>
<content type='text'>
As discussed over the mailing list, reformat code using Black. This is a
one-off change to reformat all our codebase. Moving forward, we
shouldn't expect such blanket reformats. Rather, we expect each change
to already comply with the Black formatting style.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As discussed over the mailing list, reformat code using Black. This is a
one-off change to reformat all our codebase. Moving forward, we
shouldn't expect such blanket reformats. Rather, we expect each change
to already comply with the Black formatting style.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Verify that a missing-command causes a cached failure</title>
<updated>2019-08-14T07:09:29+00:00</updated>
<author>
<name>Daniel Silverstone</name>
<email>daniel.silverstone@codethink.co.uk</email>
</author>
<published>2019-08-14T07:09:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=5a02d732b24d9a86b654790e7806eb5da7a109f1'/>
<id>5a02d732b24d9a86b654790e7806eb5da7a109f1</id>
<content type='text'>
Signed-off-by: Daniel Silverstone &lt;daniel.silverstone@codethink.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Daniel Silverstone &lt;daniel.silverstone@codethink.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/sandboxes: Enable pylint and fix problems</title>
<updated>2019-06-05T17:49:58+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-05T17:49:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=62237248b7c5e60643c172a4967da16f021b779c'/>
<id>62237248b7c5e60643c172a4967da16f021b779c</id>
<content type='text'>
tests/sandboxes was missing an __init__.py, which meant pylint
was never run there.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
tests/sandboxes was missing an __init__.py, which meant pylint
was never run there.
</pre>
</div>
</content>
</entry>
<entry>
<title>plugintestutils: Rename 'plugintestutils' package to 'testing'</title>
<updated>2019-04-16T13:25:40+00:00</updated>
<author>
<name>Phil Dawson</name>
<email>phil.dawson@codethink.co.uk</email>
</author>
<published>2019-04-15T10:02:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=97bbedbef15fc9edea5b04f66a30ec788da7f130'/>
<id>97bbedbef15fc9edea5b04f66a30ec788da7f130</id>
<content type='text'>
- Rename plugintestutils to testing.

- Don't run the tests from bst-plugins-template. This imports
  buildstream.plugintestutils so will have to be disabled to get
  through CI. This can be re nabled once bst-plugins-template has been
  patched.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Rename plugintestutils to testing.

- Don't run the tests from bst-plugins-template. This imports
  buildstream.plugintestutils so will have to be disabled to get
  through CI. This can be re nabled once bst-plugins-template has been
  patched.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: str(datafiles) instead of a longer thing</title>
<updated>2019-03-21T14:57:31+00:00</updated>
<author>
<name>Angelos Evripiotis</name>
<email>jevripiotis@bloomberg.net</email>
</author>
<published>2019-03-20T11:06:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=f2b15d86debd32241228f7b728016ed0057cd0d2'/>
<id>f2b15d86debd32241228f7b728016ed0057cd0d2</id>
<content type='text'>
Replace some popular copypasta.

This important-looking invocation:

    os.path.join(datafiles.dirname, datafiles.basename)

is equivalent to this shorter invocation:

    project = str(datafiles)

It seems like it's very popular copypasta, replace it with the shorter
one thus:

    # Use 'gsed' or 'sed' etc. as appropriate for your system.
    git config --global alias.sub '!f() { git grep --name-only --null "$1" | gxargs --null gsed --in-place --expression "s/$1/$2/g" ; }; f'
    git sub 'os.path.join(datafiles.dirname, datafiles.basename)' 'str(datafiles)'
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replace some popular copypasta.

This important-looking invocation:

    os.path.join(datafiles.dirname, datafiles.basename)

is equivalent to this shorter invocation:

    project = str(datafiles)

It seems like it's very popular copypasta, replace it with the shorter
one thus:

    # Use 'gsed' or 'sed' etc. as appropriate for your system.
    git config --global alias.sub '!f() { git grep --name-only --null "$1" | gxargs --null gsed --in-place --expression "s/$1/$2/g" ; }; f'
    git sub 'os.path.join(datafiles.dirname, datafiles.basename)' 'str(datafiles)'
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Remove unused parameters in functions</title>
<updated>2019-03-01T19:05:30+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-02-28T19:35:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=402cc7af5464f34d29909148dfb0876e56f97124'/>
<id>402cc7af5464f34d29909148dfb0876e56f97124</id>
<content type='text'>
For parameters that are required as part of an API, prefix them
by "_" to make it clear they are unused
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For parameters that are required as part of an API, prefix them
by "_" to make it clear they are unused
</pre>
</div>
</content>
</entry>
<entry>
<title>Expose basic api for testing external plugins.</title>
<updated>2019-02-08T14:27:54+00:00</updated>
<author>
<name>Phil Dawson</name>
<email>phil.dawson@codethink.co.uk</email>
</author>
<published>2019-01-16T14:03:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=b4d4c4f59c12c9b500f83d8cd4381418e1124f67'/>
<id>b4d4c4f59c12c9b500f83d8cd4381418e1124f67</id>
<content type='text'>
We want external plugins to be able to make use of the core testing utils.
This commit exposes the basic utilities which are currently in use in
bst-external plugins. If necessary, more utilities could be exposed in the
future.

Moves the following files from tests/testutils/ to
buildstream/plugintestingutils/:
o runcli.py
o integration.py

As part of this, this commit makes the following changes to runcli.py
and integration.py:
o runcli.py: Fix linting errors
o runcli.py: Add user facing documentation
o Integration.py: Add user facing documentation
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We want external plugins to be able to make use of the core testing utils.
This commit exposes the basic utilities which are currently in use in
bst-external plugins. If necessary, more utilities could be exposed in the
future.

Moves the following files from tests/testutils/ to
buildstream/plugintestingutils/:
o runcli.py
o integration.py

As part of this, this commit makes the following changes to runcli.py
and integration.py:
o runcli.py: Fix linting errors
o runcli.py: Add user facing documentation
o Integration.py: Add user facing documentation
</pre>
</div>
</content>
</entry>
<entry>
<title>Provide better error message on missing commands</title>
<updated>2018-07-02T14:45:04+00:00</updated>
<author>
<name>Tiago Gomes</name>
<email>tiago.gomes@codethink.co.uk</email>
</author>
<published>2018-06-28T10:31:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=9067e269a9f2866e659ef33a69aad72b01cb6633'/>
<id>9067e269a9f2866e659ef33a69aad72b01cb6633</id>
<content type='text'>
Before running a command in the sandbox, check its existence and fail
early if it does not.

This fixes issue #289.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Before running a command in the sandbox, check its existence and fail
early if it does not.

This fixes issue #289.
</pre>
</div>
</content>
</entry>
</feed>
