<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/buildstream.git/tests/internals/pluginloading.py, branch bschubert/cache-key-helper</title>
<subtitle>gitlab.com: buildstream/buildstream.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/'/>
<entry>
<title>Plugin loading refactor, removing all versioning</title>
<updated>2020-04-29T07:24:58+00:00</updated>
<author>
<name>Tristan Van Berkom</name>
<email>tristan.vanberkom@codethink.co.uk</email>
</author>
<published>2020-04-24T09:12:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=d63bd7e9def528d3ed59a2798452ac1da58ebea4'/>
<id>d63bd7e9def528d3ed59a2798452ac1da58ebea4</id>
<content type='text'>
Plugin format versioning was decided to be removed for local
plugins and any plugins for which we do not load an explicitly
provided plugin. For pip, this will be handled with a standard
distutils/setuptools approach, allowing users to specify pip
style version boundaries in the plugin origins.

This patch refactors plugin loading so that all related code
goes into the private _pluginfactory module, a new small
PluginOrigin type was added to better manipulate loaded
origins.

Test cases have been removed and will be readded in a following
commit, adjusted to new expectations.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Plugin format versioning was decided to be removed for local
plugins and any plugins for which we do not load an explicitly
provided plugin. For pip, this will be handled with a standard
distutils/setuptools approach, allowing users to specify pip
style version boundaries in the plugin origins.

This patch refactors plugin loading so that all related code
goes into the private _pluginfactory module, a new small
PluginOrigin type was added to better manipulate loaded
origins.

Test cases have been removed and will be readded in a following
commit, adjusted to new expectations.
</pre>
</div>
</content>
</entry>
<entry>
<title>exceptions: Expose ErrorDomain, ErrorLoadReason</title>
<updated>2020-01-23T16:45:35+00:00</updated>
<author>
<name>Thomas Coldrick</name>
<email>thomas.coldrick@codethink.co.uk</email>
</author>
<published>2020-01-17T15:22:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=8aa7e8b6c2ca418aafddf4ce308a9d0ff56cf467'/>
<id>8aa7e8b6c2ca418aafddf4ce308a9d0ff56cf467</id>
<content type='text'>
Plugin tests are already accessing this API, but using imports from
private modules. For motivation for this to be exposed publicly, note
that ErrorDomain is an argument for most things in runcli.py, and
LoadErrorReason may be another.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Plugin tests are already accessing this API, but using imports from
private modules. For motivation for this to be exposed publicly, note
that ErrorDomain is an argument for most things in runcli.py, and
LoadErrorReason may be another.
</pre>
</div>
</content>
</entry>
<entry>
<title>Reformat code using Black</title>
<updated>2019-11-14T21:21:06+00:00</updated>
<author>
<name>Chandan Singh</name>
<email>csingh43@bloomberg.net</email>
</author>
<published>2019-11-11T17:07:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=122177153b14664a0e4fed85aa4f22b87cfabf56'/>
<id>122177153b14664a0e4fed85aa4f22b87cfabf56</id>
<content type='text'>
As discussed over the mailing list, reformat code using Black. This is a
one-off change to reformat all our codebase. Moving forward, we
shouldn't expect such blanket reformats. Rather, we expect each change
to already comply with the Black formatting style.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As discussed over the mailing list, reformat code using Black. This is a
one-off change to reformat all our codebase. Moving forward, we
shouldn't expect such blanket reformats. Rather, we expect each change
to already comply with the Black formatting style.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/internals/pluginloading.py: Use dummy_context()</title>
<updated>2019-07-16T13:36:10+00:00</updated>
<author>
<name>Jürg Billeter</name>
<email>j@bitron.ch</email>
</author>
<published>2019-07-09T15:14:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=858c51902e603726e70d076a96cbd174f376295c'/>
<id>858c51902e603726e70d076a96cbd174f376295c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor, use context.messenger directly</title>
<updated>2019-07-05T09:44:45+00:00</updated>
<author>
<name>Angelos Evripiotis</name>
<email>jevripiotis@bloomberg.net</email>
</author>
<published>2019-07-02T16:14:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=cfbab5fe76f8011bc8b6b895b2d3bfff4ea167b3'/>
<id>cfbab5fe76f8011bc8b6b895b2d3bfff4ea167b3</id>
<content type='text'>
Instead of having methods in Context forward calls on to the Messenger,
have folks call the Messenger directly. Remove the forwarding methods in
Context.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of having methods in Context forward calls on to the Messenger,
have folks call the Messenger directly. Remove the forwarding methods in
Context.
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor: message handlers take 'is_silenced'</title>
<updated>2019-07-05T09:44:45+00:00</updated>
<author>
<name>Angelos Evripiotis</name>
<email>jevripiotis@bloomberg.net</email>
</author>
<published>2019-07-02T14:01:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=b60fffebf563edfe258cbb893754197af1ac5a0b'/>
<id>b60fffebf563edfe258cbb893754197af1ac5a0b</id>
<content type='text'>
Remove the need to pass the Context object to message handlers, by
passing what is usually requested from the context instead.

This paves the way to sharing less information with some child jobs -
they won't need the whole context object, just the messenger.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove the need to pass the Context object to message handlers, by
passing what is usually requested from the context instead.

This paves the way to sharing less information with some child jobs -
they won't need the whole context object, just the messenger.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: str(datafiles) instead of a longer thing</title>
<updated>2019-03-21T14:57:31+00:00</updated>
<author>
<name>Angelos Evripiotis</name>
<email>jevripiotis@bloomberg.net</email>
</author>
<published>2019-03-20T11:06:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=f2b15d86debd32241228f7b728016ed0057cd0d2'/>
<id>f2b15d86debd32241228f7b728016ed0057cd0d2</id>
<content type='text'>
Replace some popular copypasta.

This important-looking invocation:

    os.path.join(datafiles.dirname, datafiles.basename)

is equivalent to this shorter invocation:

    project = str(datafiles)

It seems like it's very popular copypasta, replace it with the shorter
one thus:

    # Use 'gsed' or 'sed' etc. as appropriate for your system.
    git config --global alias.sub '!f() { git grep --name-only --null "$1" | gxargs --null gsed --in-place --expression "s/$1/$2/g" ; }; f'
    git sub 'os.path.join(datafiles.dirname, datafiles.basename)' 'str(datafiles)'
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replace some popular copypasta.

This important-looking invocation:

    os.path.join(datafiles.dirname, datafiles.basename)

is equivalent to this shorter invocation:

    project = str(datafiles)

It seems like it's very popular copypasta, replace it with the shorter
one thus:

    # Use 'gsed' or 'sed' etc. as appropriate for your system.
    git config --global alias.sub '!f() { git grep --name-only --null "$1" | gxargs --null gsed --in-place --expression "s/$1/$2/g" ; }; f'
    git sub 'os.path.join(datafiles.dirname, datafiles.basename)' 'str(datafiles)'
</pre>
</div>
</content>
</entry>
<entry>
<title>tests:lint: remove all unneccessary-parens errors from pylint</title>
<updated>2019-03-20T09:38:42+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-03-09T10:35:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=010d10b611e5288ac9a105bce3efcfe85f01ba9f'/>
<id>010d10b611e5288ac9a105bce3efcfe85f01ba9f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Remove unused variables</title>
<updated>2019-03-01T19:05:30+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-02-28T19:31:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=d6d33c94751bd47ca77d2b2e4ac246a2dd1328a6'/>
<id>d6d33c94751bd47ca77d2b2e4ac246a2dd1328a6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>context: remove artifactdir</title>
<updated>2019-02-19T17:05:17+00:00</updated>
<author>
<name>Raoul Hidalgo Charman</name>
<email>raoul.hidalgocharman@codethink.co.uk</email>
</author>
<published>2019-02-11T12:07:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=4b62b9362870045a6203d01f2abf3e437bf23ae6'/>
<id>4b62b9362870045a6203d01f2abf3e437bf23ae6</id>
<content type='text'>
Will check and move old artifact directory if it exists, and create
symlink linking old directory to new.

Part of #870
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Will check and move old artifact directory if it exists, and create
symlink linking old directory to new.

Part of #870
</pre>
</div>
</content>
</entry>
</feed>
