delta/buildstream.git/tests/frontend, branch bschubert/python38 gitlab.com: buildstream/buildstream.git Add tests for interactive `bst init` 2019-12-05T13:46:40+00:00 Chandan Singh chandan@chandansingh.net 2019-11-12T00:47:14+00:00 23423f6bd1572003fbb1af571bf9a9758abdd79c Add tests for interactive `bst init` command using [pexpect](https://pexpect.readthedocs.io). 
Add tests for interactive `bst init` command using
[pexpect](https://pexpect.readthedocs.io).
tests/frontend/pull.py: Do not use checkout --hardlinks 2019-12-03T12:06:31+00:00 Jürg Billeter j@bitron.ch 2019-11-21T07:16:29+00:00 485fac0aa55f95466fedbff83ebacce38692bfa4 This is not necessary and doesn't work with CASD_SEPARATE_USER. 
This is not necessary and doesn't work with CASD_SEPARATE_USER.
tests/frontend/buildcheckout.py: Cannot hardlink with CASD_SEPARATE_USER 2019-12-03T12:06:31+00:00 Jürg Billeter j@bitron.ch 2019-11-21T07:06:09+00:00 b10a1cf327501271ccdeb82be9ff3eca7acf4898 Linux does not allow hardlinks to read-only files of other users by default since Linux 3.6 (see /proc/sys/fs/protected_hardlinks). 
Linux does not allow hardlinks to read-only files of other users by
default since Linux 3.6 (see /proc/sys/fs/protected_hardlinks).
lint: Remove unnecessary list comprehensions 2019-12-02T11:02:23+00:00 Benjamin Schubert bschubert15@bloomberg.net 2019-12-02T11:02:23+00:00 069b110c866ecfd652a041d735ca6d261b8d41ba Newer version of pylint detect when a comprehension would not be needed. Let's remove all the ones that are indeed extraneous 
Newer version of pylint detect when a comprehension would not be needed.
Let's remove all the ones that are indeed extraneous
tests/frontend: Refactor tests for default targets 2019-11-27T11:06:36+00:00 Chandan Singh csingh43@bloomberg.net 2019-11-11T16:01:01+00:00 75a8560c919245b7e1df37e069cf4a5b86496c76 `tests/frontend/buildcheckout.py` is already very crowded with all sorts of tests. Since this test is not really about testing `bst build` but rather about testing whether BuildStream can detect the default targets correctly, move it to a separate test module. At the same time, also improve the actual tests. Currently the test compares the number of sub-directories in BuildStream log directory with the number of elements. Change it such that we directly query BuildStream about what's been built rather than trying to guess. While doing so, sanitize its project directory to make it clearer what's being tested. 
`tests/frontend/buildcheckout.py` is already very crowded with all sorts
of tests. Since this test is not really about testing `bst build` but
rather about testing whether BuildStream can detect the default targets
correctly, move it to a separate test module.

At the same time, also improve the actual tests. Currently the test
compares the number of sub-directories in BuildStream log directory with
the number of elements. Change it such that we directly query
BuildStream about what's been built rather than trying to guess.

While doing so, sanitize its project directory to make it clearer what's
being tested.
Fix stacktraces during element loading 2019-11-22T11:41:31+00:00 Tristan Maat tristan.maat@codethink.co.uk 2019-11-18T16:50:57+00:00 176338b5cc20ac64b2b85bf83f704af7b26f3e6a These were caused by unhandled errors from plugins when calling `Source.get_consistency()`. This doesn't really solve the problem, since that interface is still used un-wrapped elsewhere, but it enables removing `Element.__schedule_tracking()` and fixes a bug. Ultimately we'd like to remove `Source.get_consistency()`, so this isn't too long-term of a problem. 
These were caused by unhandled errors from plugins when calling
`Source.get_consistency()`. This doesn't really solve the problem,
since that interface is still used un-wrapped elsewhere, but it
enables removing `Element.__schedule_tracking()` and fixes a bug.

Ultimately we'd like to remove `Source.get_consistency()`, so this
isn't too long-term of a problem.
Reformat code using Black 2019-11-14T21:21:06+00:00 Chandan Singh csingh43@bloomberg.net 2019-11-11T17:07:09+00:00 122177153b14664a0e4fed85aa4f22b87cfabf56 As discussed over the mailing list, reformat code using Black. This is a one-off change to reformat all our codebase. Moving forward, we shouldn't expect such blanket reformats. Rather, we expect each change to already comply with the Black formatting style. 
As discussed over the mailing list, reformat code using Black. This is a
one-off change to reformat all our codebase. Moving forward, we
shouldn't expect such blanket reformats. Rather, we expect each change
to already comply with the Black formatting style.
tests/frontend/completions: Fix implicit string concatenation 2019-11-12T10:44:05+00:00 Chandan Singh csingh43@bloomberg.net 2019-11-11T18:51:09+00:00 7b6847cd29d9b19dd6fd11dd73d89417f2dd207e We expect `INVALID_ELEMENTS` to be a list of element names. However we are missing a comma in between the names, so they end up being concatenated into a single strings. The test passes either way (which is not ideal) because it just checks that the suggested completion is _different_ than the expected in case of errors. 
We expect `INVALID_ELEMENTS` to be a list of element names. However we
are missing a comma in between the names, so they end up being
concatenated into a single strings.

The test passes either way (which is not ideal) because it just checks
that the suggested completion is _different_ than the expected in case
of errors.
Remove unnecessary ignore_workspaces kwarg 2019-11-06T09:16:21+00:00 Darius Makovsky traveltissues@protonmail.com 2019-11-06T09:16:18+00:00 2245af28b79cf978d7eb19fdb06273a4515c62d6 Attempting to open a workspace for the same element without closing it now raises. This makes this kwarg unnecessary and tests should close workspaces between attempts to open. 
Attempting to open a workspace for the same element without closing it
now raises. This makes this kwarg unnecessary and tests should close
workspaces between attempts to open.
frontend: Remove tracking options from `bst build` 2019-11-04T11:01:14+00:00 Chandan Singh chandan@chandansingh.net 2019-10-26T18:07:03+00:00 576be1fc19bb58d25309a911589ceb9f08f7812d BREAKING CHANGE: Remove all tracking related options and flags from `bst build` command, as discussed on mailing list previously. See https://mail.gnome.org/archives/buildstream-list/2019-October/msg00009.html for the original proposal, and https://mail.gnome.org/archives/buildstream-list/2019-October/msg00024.html for a summary. At the same time, remove use of the removed options from our test suite. 
BREAKING CHANGE: Remove all tracking related options and flags from
`bst build` command, as discussed on mailing list previously.

See
https://mail.gnome.org/archives/buildstream-list/2019-October/msg00009.html
for the original proposal, and
https://mail.gnome.org/archives/buildstream-list/2019-October/msg00024.html
for a summary.

At the same time, remove use of the removed options from our test suite.