<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/buildstream.git/tests/format/variables.py, branch bschubert/python38</title>
<subtitle>gitlab.com: buildstream/buildstream.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/'/>
<entry>
<title>Reformat code using Black</title>
<updated>2019-11-14T21:21:06+00:00</updated>
<author>
<name>Chandan Singh</name>
<email>csingh43@bloomberg.net</email>
</author>
<published>2019-11-11T17:07:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=122177153b14664a0e4fed85aa4f22b87cfabf56'/>
<id>122177153b14664a0e4fed85aa4f22b87cfabf56</id>
<content type='text'>
As discussed over the mailing list, reformat code using Black. This is a
one-off change to reformat all our codebase. Moving forward, we
shouldn't expect such blanket reformats. Rather, we expect each change
to already comply with the Black formatting style.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As discussed over the mailing list, reformat code using Black. This is a
one-off change to reformat all our codebase. Moving forward, we
shouldn't expect such blanket reformats. Rather, we expect each change
to already comply with the Black formatting style.
</pre>
</div>
</content>
</entry>
<entry>
<title>_variables: Fix reporting of missing variable</title>
<updated>2019-07-17T09:38:59+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-07-17T08:48:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=2bd91640f4ba7e29d92633f7e573deb2073dc27d'/>
<id>2bd91640f4ba7e29d92633f7e573deb2073dc27d</id>
<content type='text'>
When the missing variable was not defined, we would get an exception
as a string doesn't contain provenance information.

- Add a test to prevent regression
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When the missing variable was not defined, we would get an exception
as a string doesn't contain provenance information.

- Add a test to prevent regression
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Change all calls to _yaml.dump to _yaml.rountrip_dump</title>
<updated>2019-07-15T14:14:03+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-28T16:01:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=f7b461220ec2f1af3966ace12c21334f1f3b6457'/>
<id>f7b461220ec2f1af3966ace12c21334f1f3b6457</id>
<content type='text'>
Now that both are equivalent, we can skip the sanitization part before
the yaml call.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now that both are equivalent, we can skip the sanitization part before
the yaml call.
</pre>
</div>
</content>
</entry>
<entry>
<title>_yaml: Add 'as_str()' on ScalarNode and 'get_scalar()' on MappingNode</title>
<updated>2019-07-15T14:14:02+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>contact@benschubert.me</email>
</author>
<published>2019-06-10T06:51:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=38671fb53f4522d046bed94699db8cc344ac2862'/>
<id>38671fb53f4522d046bed94699db8cc344ac2862</id>
<content type='text'>
- 'get_scalar()' allows retrieving a scalar node from a mapping.
- 'as_str()' casts a ScalarNode into a string (thus removing the node
  information).

Both together, those replace 'node_get(mapping, key, type=str)' but
also allow retrieving the 'Node' itself, which will allow in the future
lazier provenance computation.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- 'get_scalar()' allows retrieving a scalar node from a mapping.
- 'as_str()' casts a ScalarNode into a string (thus removing the node
  information).

Both together, those replace 'node_get(mapping, key, type=str)' but
also allow retrieving the 'Node' itself, which will allow in the future
lazier provenance computation.
</pre>
</div>
</content>
</entry>
<entry>
<title>plugintestutils: Rename 'plugintestutils' package to 'testing'</title>
<updated>2019-04-16T13:25:40+00:00</updated>
<author>
<name>Phil Dawson</name>
<email>phil.dawson@codethink.co.uk</email>
</author>
<published>2019-04-15T10:02:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=97bbedbef15fc9edea5b04f66a30ec788da7f130'/>
<id>97bbedbef15fc9edea5b04f66a30ec788da7f130</id>
<content type='text'>
- Rename plugintestutils to testing.

- Don't run the tests from bst-plugins-template. This imports
  buildstream.plugintestutils so will have to be disabled to get
  through CI. This can be re nabled once bst-plugins-template has been
  patched.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Rename plugintestutils to testing.

- Don't run the tests from bst-plugins-template. This imports
  buildstream.plugintestutils so will have to be disabled to get
  through CI. This can be re nabled once bst-plugins-template has been
  patched.
</pre>
</div>
</content>
</entry>
<entry>
<title>The new YAML World Order</title>
<updated>2019-03-27T21:26:07+00:00</updated>
<author>
<name>Daniel Silverstone</name>
<email>daniel.silverstone@codethink.co.uk</email>
</author>
<published>2019-03-25T15:08:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=3816dcf8901b06f2b9c0153e5b5fe394acf104a5'/>
<id>3816dcf8901b06f2b9c0153e5b5fe394acf104a5</id>
<content type='text'>
Replace YAML internals with a new Node type, and refactor everything
to use it cleanly.

This work was also by James Ennis &lt;james.ennis@codethink.co.uk&gt;

Signed-off-by: Daniel Silverstone &lt;daniel.silverstone@codethink.co.uk&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replace YAML internals with a new Node type, and refactor everything
to use it cleanly.

This work was also by James Ennis &lt;james.ennis@codethink.co.uk&gt;

Signed-off-by: Daniel Silverstone &lt;daniel.silverstone@codethink.co.uk&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: str(datafiles) instead of a longer thing</title>
<updated>2019-03-21T14:57:31+00:00</updated>
<author>
<name>Angelos Evripiotis</name>
<email>jevripiotis@bloomberg.net</email>
</author>
<published>2019-03-20T11:06:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=f2b15d86debd32241228f7b728016ed0057cd0d2'/>
<id>f2b15d86debd32241228f7b728016ed0057cd0d2</id>
<content type='text'>
Replace some popular copypasta.

This important-looking invocation:

    os.path.join(datafiles.dirname, datafiles.basename)

is equivalent to this shorter invocation:

    project = str(datafiles)

It seems like it's very popular copypasta, replace it with the shorter
one thus:

    # Use 'gsed' or 'sed' etc. as appropriate for your system.
    git config --global alias.sub '!f() { git grep --name-only --null "$1" | gxargs --null gsed --in-place --expression "s/$1/$2/g" ; }; f'
    git sub 'os.path.join(datafiles.dirname, datafiles.basename)' 'str(datafiles)'
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replace some popular copypasta.

This important-looking invocation:

    os.path.join(datafiles.dirname, datafiles.basename)

is equivalent to this shorter invocation:

    project = str(datafiles)

It seems like it's very popular copypasta, replace it with the shorter
one thus:

    # Use 'gsed' or 'sed' etc. as appropriate for your system.
    git config --global alias.sub '!f() { git grep --name-only --null "$1" | gxargs --null gsed --in-place --expression "s/$1/$2/g" ; }; f'
    git sub 'os.path.join(datafiles.dirname, datafiles.basename)' 'str(datafiles)'
</pre>
</div>
</content>
</entry>
<entry>
<title>tests:lint: disable 'unused-import' checks on pytest fixtures</title>
<updated>2019-03-20T09:38:42+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-03-19T18:36:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=da439e6658049bb79ca471f4eeac401e70c548f1'/>
<id>da439e6658049bb79ca471f4eeac401e70c548f1</id>
<content type='text'>
Pylint can't know that pytest's fixtures are used in a file and
therefore reports false positives. Silencing all those errors
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Pylint can't know that pytest's fixtures are used in a file and
therefore reports false positives. Silencing all those errors
</pre>
</div>
</content>
</entry>
<entry>
<title>tests:lint: silence redefined-outer-name in files using fixtures</title>
<updated>2019-03-20T09:38:42+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-03-19T18:05:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=a90daa6a123d74a938a646e2fccaf4bfe6a5b950'/>
<id>a90daa6a123d74a938a646e2fccaf4bfe6a5b950</id>
<content type='text'>
Pylint doesn't play well with pytest fixtures, we therefore need to
silence this error.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Pylint doesn't play well with pytest fixtures, we therefore need to
silence this error.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests:lint: reorder imports for consistency</title>
<updated>2019-03-20T09:38:41+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-03-09T10:51:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=7474ed1f38b7b750e1cd2b5ebbfe9fc0f3f3d364'/>
<id>7474ed1f38b7b750e1cd2b5ebbfe9fc0f3f3d364</id>
<content type='text'>
- Remove all wrong-import-order from pylint
- Order some subgroups of imports
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Remove all wrong-import-order from pylint
- Order some subgroups of imports
</pre>
</div>
</content>
</entry>
</feed>
