delta/buildstream.git, branch valentindavid/rmtree_oserror

Catch correct exception from shutil.rmtree

2018-10-04T14:56:09+00:00

Python documentation is not clear on what shutil.rmtree is supposed to
raise. However from the source code, it is obvious that OSError are
raised, but never shutil.Error.

It is not easy to test in normal condition because issues happen
usually in combination with a FUSE filesystem, a probably a race
condition where `fstatat` returns an error just before the filesystem
being unmounted.

Fixes #153.

Merge branch 'Qinusty/634-workspace-failed-builds' into 'master'

2018-10-04T14:11:27+00:00

Do not save workspace on failed build

Closes #634

See merge request BuildStream/buildstream!812

testing: Add regression test for workspace bug

2018-10-04T13:43:10+00:00

element.py: Do not save workspace on failed build

2018-10-04T13:43:10+00:00

This fixes #634, BuildStream no longer saves workspace configuration on
a failed build.

Merge branch 'danielsilverstone-ct/bwrap-check-runtime-only' into 'master'

2018-10-04T09:45:58+00:00

Make bwrap check runtime only

Closes #644

See merge request BuildStream/buildstream!847

setup.py: Change bwrap assertion to a warning

2018-10-04T09:13:04+00:00

Since there are use-cases where BuildStream could be installed
onto systems which do not have BubbleWrap (e.g. for remote-build-only
scenarios) it is not correct to assert a dependency on bwrap during
installation.  This patch makes the assertion a warning, and also
clarifies the message somewhat.  This should fix #644

Signed-off-by: Daniel Silverstone

_site.py: Reduce complexity of bwrap version comparison

2018-10-04T09:04:21+00:00

Instead of an if/else ladder which is quite complex, this patch
uses the fact that Python supports by-component tuple comparison
to simply compare two (major, minor, patch) tuples

Signed-off-by: Daniel Silverstone

_site.py: Protect against failure running `bwrap --version`

2018-10-04T09:04:21+00:00

On some potentially broken systems, running `bwrap --version` might
fail with an error code.  This patch corrects the oversight ensuring
that we cleanly return False for version checking in such cases.

Signed-off-by: Daniel Silverstone

_platform/linux.py: Refactor checks for sandboxing

2018-10-04T09:04:21+00:00

To better report issues in the absence of a suitable bwrap, or the
FUSE devices, this refactors the checks for sandboxing in the Linux
platform to cover the various possibilities.  The reasons are then
collated and passed to the dummy sandbox for later reporting to the
user if a local build is attempted.

Signed-off-by: Daniel Silverstone

_platform/darwin.py: Give reason for use of dummy sandbox

2018-10-04T08:12:20+00:00

Since Darwin is limited to the dummy sandbox for now due to OSXFUSE
being unsupported as yet, and there being no suitable sandboxing option
for use on OSX, give this as the reason so that it can be reported if
the user attempts a local build.

Signed-off-by: Daniel Silverstone