delta/buildstream.git, branch danielsilverstone-ct/fix-lint-issues gitlab.com: buildstream/buildstream.git MANIFEST: Include a lot more missing stuff in the manifest 2018-10-25T12:58:10+00:00 Daniel Silverstone daniel.silverstone@codethink.co.uk 2018-10-25T09:55:17+00:00 4247cef3985b4fa0a15ed02b7beae1dc1a9cd8f1 Versioneer needs to be in the MANIFEST.in and its .pyc needs to be ignored in the .gitignore. Also much docs were not being included, nor conftest.py. Much of the test suite data files needed including, so changed that to a raw include of everything in the tests/ tree. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk> 
Versioneer needs to be in the MANIFEST.in and its .pyc needs to be ignored
in the .gitignore.  Also much docs were not being included, nor conftest.py.
Much of the test suite data files needed including, so changed that to a
raw include of everything in the tests/ tree.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
Bump CI image tags 2018-10-25T12:58:10+00:00 Tristan Maat tm@tlater.net 2018-10-24T16:13:18+00:00 1d8fe381be3eb06c7412642694a7b1d7e9b50ed4 We need to do this so that the new linting errors pop up 
We need to do this so that the new linting errors pop up
_artifactcache/cascache.py: Cleanup lint warning about indexing 2018-10-25T12:58:10+00:00 Daniel Silverstone daniel.silverstone@codethink.co.uk 2018-10-24T10:28:43+00:00 598c04b0b7915327b08d7d86e4cb1bab3bc1dc77 In order to quieten the linter, and to make a more correct comparison, we switch to using the `Code.OK` enumeration from `google.rpc.Code` Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk> 
In order to quieten the linter, and to make a more correct comparison,
we switch to using the `Code.OK` enumeration from `google.rpc.Code`

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
_artifactcache/cascache.py: Remove unused imports 2018-10-25T12:58:09+00:00 Daniel Silverstone daniel.silverstone@codethink.co.uk 2018-10-24T10:18:07+00:00 a9489c8e97bad8916a8cf91ba97045b071ab6323 The imports of `Message` and `MessageType` were unused. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk> 
The imports of `Message` and `MessageType` were unused.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
_artifactcache/cascache.py: Prepare attributes in __init__ 2018-10-25T12:58:09+00:00 Daniel Silverstone daniel.silverstone@codethink.co.uk 2018-10-24T10:17:18+00:00 50fd1480a06a0fa2dc7dfc2726cd9644fad6acb4 Python linters prefer that attributes are defined in __init__ rather than left to later routines. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk> 
Python linters prefer that attributes are defined in __init__ rather
than left to later routines.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
_artifactcache/cascache.py: Silence len(SEQUENCE) as condition warnings 2018-10-25T12:58:09+00:00 Daniel Silverstone daniel.silverstone@codethink.co.uk 2018-10-24T10:12:25+00:00 21e3f0369d037504e4d8b9a0262d908bdc8fd0e0 The lint tool dislikes the use of `if len(SEQ) == 0` type statements because nominally `len(SEQ)` may be more expensive than `bool(SEQ)`. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk> 
The lint tool dislikes the use of `if len(SEQ) == 0` type statements
because nominally `len(SEQ)` may be more expensive than `bool(SEQ)`.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
_artifactcache/cascache.py: Refactor slightly for indentation 2018-10-25T12:58:09+00:00 Daniel Silverstone daniel.silverstone@codethink.co.uk 2018-10-24T10:09:22+00:00 6e539889b7416a65c4a5fdfcb0a8bfac6add2485 Correct some multi-line conditional indentation by slight refactor if necessary. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk> 
Correct some multi-line conditional indentation by slight refactor
if necessary.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
sandbox/_sandboxchroot.py: Silence warning about dict.get 2018-10-25T12:58:09+00:00 Daniel Silverstone daniel.silverstone@codethink.co.uk 2018-10-24T09:57:23+00:00 39a7b5f75e8c74639e759f53f998722c0c38327f Sometimes `dict.get()` is preferable to an `if` statement, but this time it's clearer if we keep the structure. As such, silence the warning. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk> 
Sometimes `dict.get()` is preferable to an `if` statement, but this time
it's clearer if we keep the structure.  As such, silence the warning.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
sandbox/_sandboxchroot.py: Silence warning about preexec_fn 2018-10-25T12:58:09+00:00 Daniel Silverstone daniel.silverstone@codethink.co.uk 2018-10-24T09:56:28+00:00 cc2b299e466c8dea166e52f4f43241eb95b035f2 We are super-careful to not use threads in places where we might use Popen and as such this warning is save to quash. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk> 
We are super-careful to not use threads in places where we might use
Popen and as such this warning is save to quash.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>
sandbox/_sandboxchroot.py: Silence warning about unused variable 2018-10-25T12:58:09+00:00 Daniel Silverstone daniel.silverstone@codethink.co.uk 2018-10-24T09:55:17+00:00 91afae39d0bc73e06ccf59520f589b1cb8313d89 The variable was unused, remove it. Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk> 
The variable was unused, remove it.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>