delta/buildstream.git, branch bschubert/node-api-novalidate gitlab.com: buildstream/buildstream.git _yaml: Remove 'node_validate' and replace by 'MappingNode.validate_keys' 2019-07-04T09:14:02+00:00 Benjamin Schubert ben.c.schubert@gmail.com 2019-07-03T17:01:30+00:00 59da3304aaf6e320ec111f9e1c660be56d1f051b - adapt all call sites to use the new API 
- adapt all call sites to use the new API
Merge branch 'bschubert/rework-node-creations' into 'bschubert/new-node-api' 2019-07-04T09:09:23+00:00 Benjamin Schubert contact@benschubert.me 2019-07-04T09:09:23+00:00 c7a7e44838a0df64088924caecb9fea1ef9e91af Rework synthetic node creation See merge request BuildStream/buildstream!1447 
Rework synthetic node creation

See merge request BuildStream/buildstream!1447
 _yaml: Create 'from_dict' on Node and remove node creation methods 2019-07-03T16:57:26+00:00 Benjamin Schubert ben.c.schubert@gmail.com 2019-07-03T11:20:27+00:00 482221aaacf690b73d67a8c1ec4eb15686abfd5b Using 'Node.from_dict({})' can replace new_empty_node, and the rest is not needed anymore. - Adapt all call sites 
Using 'Node.from_dict({})' can replace new_empty_node, and the rest
is not needed anymore.

- Adapt all call sites
_yaml: Remove 'node_extend_list' and add 'SequenceNode.append' 2019-07-03T16:57:26+00:00 Benjamin Schubert ben.c.schubert@gmail.com 2019-07-03T09:55:19+00:00 3c84fc22b67ab92b6905c4797a4d7ad6ed6f4821 There was a single place using 'node_extend_list', which we can replace more easily with 'SequenceNode.append'. Also rewrite _projectrefs.py:_lookup to use the new API more effectively 
There was a single place using 'node_extend_list', which we can replace
more easily with 'SequenceNode.append'.

Also rewrite _projectrefs.py:_lookup to use the new API more effectively
_yaml: Refer new synthetic nodes to their parents 2019-07-03T16:57:26+00:00 Benjamin Schubert ben.c.schubert@gmail.com 2019-07-03T09:30:18+00:00 05496a31f72963180f0a382dc68ca1314d91b51c This changes how we were handling synthetic nodes. Previously, we would have them as coming from a 'SYNTHETIC_FILE'. This is not correct when we need the position in the real file when adding new information to a file we will end up writing to disk (like project_ref). This is a prerequisite for further work on cleaning how it is done. 
This changes how we were handling synthetic nodes. Previously, we would
have them as coming from a 'SYNTHETIC_FILE'. This is not correct when
we need the position in the real file when adding new information to a
file we will end up writing to disk (like project_ref).

This is a prerequisite for further work on cleaning how it is done.
_yaml: Add a 'from_dict' on Node to create new nodes from dicts 2019-07-03T16:57:25+00:00 Benjamin Schubert ben.c.schubert@gmail.com 2019-07-03T09:28:50+00:00 f05f91725db54c62f79be11ea890f1ed5556db00 This new methods is here to replace the previous 'new_node_from_dict' that will be moved to a private method. Adapt all call sites to use the new 'from_dict' method. 
This new methods is here to replace the previous 'new_node_from_dict'
that will be moved to a private method.

Adapt all call sites to use the new 'from_dict' method.
Merge branch 'bschubert/new-node-compose' into 'bschubert/new-node-api' 2019-07-03T15:58:12+00:00 Benjamin Schubert contact@benschubert.me 2019-07-03T15:58:12+00:00 b4b0f79f6e09a89f1eee785702f47e5975e41bf7 Rework node compose API See merge request BuildStream/buildstream!1442 
Rework node compose API

See merge request BuildStream/buildstream!1442
 _yaml: Move 'node_composite' to a method on 'MappingNode' 2019-07-03T15:18:30+00:00 Benjamin Schubert ben.c.schubert@gmail.com 2019-07-02T15:06:45+00:00 35fad402ef5d75d25589fdfd6cddde0306c263aa - Also take care of node_composite_move in the same way. - Adapt all calling places 
- Also take care of node_composite_move in the same way.
- Adapt all calling places
_yaml: move 'composite_dict' to 'MappingNode' as '_composite' 2019-07-03T12:57:47+00:00 Benjamin Schubert ben.c.schubert@gmail.com 2019-07-02T14:31:06+00:00 382712aec8f6c0a1a820194ee6917b9f8195ab1f 






_yaml: Extract parts of 'composite_dict' to each type of 'Node'
2019-07-03T12:57:47+00:00

Benjamin Schubert
ben.c.schubert@gmail.com

2019-07-02T14:16:06+00:00

781dbeaba3b04debeee194aa388f43adf697efdd

We had a large if-else clause in 'composite_dict' that was looking at
the type of the source and acting based on that. This is easier to
handle once split on each type of 'Node'





We had a large if-else clause in 'composite_dict' that was looking at
the type of the source and acting based on that. This is easier to
handle once split on each type of 'Node'