<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/buildstream.git, branch bschubert/node-api-nosanitize</title>
<subtitle>gitlab.com: buildstream/buildstream.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/'/>
<entry>
<title>_yaml: remove node_sanitize</title>
<updated>2019-07-01T21:38:54+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-28T16:36:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=0c4b6217fb2541667456cb96123363c18304b410'/>
<id>0c4b6217fb2541667456cb96123363c18304b410</id>
<content type='text'>
Some call places do not need calls to 'node_sanitize' anymore, therefore
removing the call entirely.

Other still use it for convenience, but that doesn't seem the right way
to do it for consistency. Those places have been replaced by calls to
'Node.strip_node_info()'.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some call places do not need calls to 'node_sanitize' anymore, therefore
removing the call entirely.

Other still use it for convenience, but that doesn't seem the right way
to do it for consistency. Those places have been replaced by calls to
'Node.strip_node_info()'.
</pre>
</div>
</content>
</entry>
<entry>
<title>_yaml: Decomission 'dump()'. 'roundtrip_dump' is an equivalent function now</title>
<updated>2019-07-01T21:38:51+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-28T16:06:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=be5ee63758654ebfc6da169ada2ba65e3af33d60'/>
<id>be5ee63758654ebfc6da169ada2ba65e3af33d60</id>
<content type='text'>
Remove completely '_yaml.dump()' and replace all notions and call by
'roundtrip_dump'
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove completely '_yaml.dump()' and replace all notions and call by
'roundtrip_dump'
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Change all calls to _yaml.dump to _yaml.rountrip_dump</title>
<updated>2019-07-01T21:38:48+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-28T16:01:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=947fbd8bedb93185ff69db35fd3dce22efc80e8a'/>
<id>947fbd8bedb93185ff69db35fd3dce22efc80e8a</id>
<content type='text'>
Now that both are equivalent, we can skip the sanitization part before
the yaml call.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now that both are equivalent, we can skip the sanitization part before
the yaml call.
</pre>
</div>
</content>
</entry>
<entry>
<title>_yaml: Automatically represent Yaml nodes into yaml</title>
<updated>2019-07-01T21:38:46+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-28T16:00:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=d96c1a232b0cd41558e75aac10dc3badb9361594'/>
<id>d96c1a232b0cd41558e75aac10dc3badb9361594</id>
<content type='text'>
This removes the need of calling _yaml.dump(), as roundtrip_dump
is now equivalent.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This removes the need of calling _yaml.dump(), as roundtrip_dump
is now equivalent.
</pre>
</div>
</content>
</entry>
<entry>
<title>_yaml: Stop stringifying manually in roundtrip_dump</title>
<updated>2019-07-01T21:38:42+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-28T15:40:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=75296d85b20fa4a7ca894de729a990e3420ce16e'/>
<id>75296d85b20fa4a7ca894de729a990e3420ce16e</id>
<content type='text'>
This removes the need of manually stringifying the values in
roundtrip_dump by registering special Ruamel representer for each
value we might expect.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This removes the need of manually stringifying the values in
roundtrip_dump by registering special Ruamel representer for each
value we might expect.
</pre>
</div>
</content>
</entry>
<entry>
<title>_cachekey: Remove the 'node_sanitization' done before the json string</title>
<updated>2019-07-01T21:38:39+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-28T11:29:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=160f0a59ebe853aa75103e06a679fce1e224f741'/>
<id>160f0a59ebe853aa75103e06a679fce1e224f741</id>
<content type='text'>
Since ujson already sorts the keys, we just need to be able to jsonify
Nodes sensibly. This is done by implementing __json__ on the 'Node' base
class.

This does not break the cache keys.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since ujson already sorts the keys, we just need to be able to jsonify
Nodes sensibly. This is done by implementing __json__ on the 'Node' base
class.

This does not break the cache keys.
</pre>
</div>
</content>
</entry>
<entry>
<title>_yaml: Remove 'node_find_target' and replace by 'MappingNode.find'</title>
<updated>2019-07-01T21:26:55+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-27T13:49:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=d0e92427acc75b23b8183d807b6fbdf71f3ec26a'/>
<id>d0e92427acc75b23b8183d807b6fbdf71f3ec26a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>_yaml: Remove 'key' from node_find_target</title>
<updated>2019-07-01T21:26:52+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>ben.c.schubert@gmail.com</email>
</author>
<published>2019-06-27T10:18:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=099bff38c3b655a7f5af4771feab8b12e805985b'/>
<id>099bff38c3b655a7f5af4771feab8b12e805985b</id>
<content type='text'>
- node_find_target with 'key' is only used once in the codebase.
  We can remove and simplify this function
- Allow 'MappingNode.get_node()' to be called without any
  'expected_types'
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- node_find_target with 'key' is only used once in the codebase.
  We can remove and simplify this function
- Allow 'MappingNode.get_node()' to be called without any
  'expected_types'
</pre>
</div>
</content>
</entry>
<entry>
<title>_yaml: Remove 'node_set'. Now use __setitem__</title>
<updated>2019-07-01T21:26:50+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>contact@benschubert.me</email>
</author>
<published>2019-06-18T10:05:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=7155ae81763cc67fdbfd119bdffe30d72afc82a5'/>
<id>7155ae81763cc67fdbfd119bdffe30d72afc82a5</id>
<content type='text'>
- Implement __setitem__ on 'MappingNode'
- Implement __setitem__ on 'SequenceNode'
- Adapt all call sites to use the new calling way.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Implement __setitem__ on 'MappingNode'
- Implement __setitem__ on 'SequenceNode'
- Adapt all call sites to use the new calling way.
</pre>
</div>
</content>
</entry>
<entry>
<title>_yaml: Remove 'node_items' and add 'MappingNode.items()'</title>
<updated>2019-07-01T21:26:47+00:00</updated>
<author>
<name>Benjamin Schubert</name>
<email>contact@benschubert.me</email>
</author>
<published>2019-06-25T20:14:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/buildstream.git/commit/?id=7585f65696cf8cec4c587c85f8ca068f57e902c6'/>
<id>7585f65696cf8cec4c587c85f8ca068f57e902c6</id>
<content type='text'>
One difference is that 'MappingNode.items()' does not strip the
provenance from scalars and lists, which ends up not affecting the
code much.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
One difference is that 'MappingNode.items()' does not strip the
provenance from scalars and lists, which ends up not affecting the
code much.
</pre>
</div>
</content>
</entry>
</feed>
