From 95a6b0a106fac6ea35670421534d461a3663c0ba Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 15 Oct 2017 08:36:51 -0600 Subject: Constify execute_command This constifies execute_command and fixes up the callers. gdb/ChangeLog 2017-11-07 Tom Tromey * event-top.h (command_handler): Constify. * record-full.c (cmd_record_full_start): Update. * thread.c (thread_apply_all_command): Update. * printcmd.c (eval_command): Update. * mi/mi-main.c (mi_execute_cli_command): Update. (mi_execute_async_cli_command): Update. * tui/tui-stack.c (tui_update_command): Update. * cli/cli-interp.c (safe_execute_command): Constify. * record.c (record_start): Update. (record_start, record_stop, cmd_record_start): Update. * record-btrace.c (cmd_record_btrace_bts_start): Update. (cmd_record_btrace_pt_start): Update. (cmd_record_btrace_start): Update. (cmd_record_btrace_start): Update. * reverse.c (exec_reverse_once): Update. * python/python.c (execute_gdb_command): Don't copy the command. * event-top.c (command_line_handler): Update. (command_handler): Constify. * defs.h (deprecated_call_command_hook): Constify. * cli/cli-script.h (execute_user_command): Constify. * cli/cli-script.c (execute_user_command): Constify. (execute_cmd_pre_hook, execute_cmd_post_hook): Constify. (enum command_control_type): Update. * main.c (catch_command_errors): Remove non-const overload. (catch_command_errors_ftype): Remove. * python/py-cmd.c (cmdpy_function): Constify. * guile/scm-cmd.c (cmdscm_function): Constify. * cli/cli-dump.c (call_dump_func): Constify. * cli/cli-decode.c (do_const_cfunc): Constify. (do_sfunc): Constify. (cmd_func): Constify. * gdbcmd.h (execute_command, execute_command_to_string): Constify. * top.h (execute_command): Constify. * top.c (execute_command): Constify. (execute_command_to_string): Constify. (deprecated_call_command_hook): Constify. * command.h (cmd_func): Constify. * cli/cli-decode.h (struct cmd_list_element) : Constify. --- gdb/cli/cli-interp.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'gdb/cli/cli-interp.c') diff --git a/gdb/cli/cli-interp.c b/gdb/cli/cli-interp.c index 609a419fe86..9477ac8fad6 100644 --- a/gdb/cli/cli-interp.c +++ b/gdb/cli/cli-interp.c @@ -80,7 +80,7 @@ as_cli_interp (struct interp *interp) /* Longjmp-safe wrapper for "execute_command". */ static struct gdb_exception safe_execute_command (struct ui_out *uiout, - char *command, + const char *command, int from_tty); /* See cli-interp.h. @@ -332,11 +332,6 @@ cli_interp::exec (const char *command_str) struct ui_file *old_stream; struct gdb_exception result; - /* FIXME: cagney/2003-02-01: Need to const char *propogate - safe_execute_command. */ - char *str = (char *) alloca (strlen (command_str) + 1); - strcpy (str, command_str); - /* gdb_stdout could change between the time cli_uiout was initialized and now. Since we're probably using a different interpreter which has a new ui_file for gdb_stdout, use that one @@ -345,7 +340,7 @@ cli_interp::exec (const char *command_str) It is important that it gets reset everytime, since the user could set gdb to use a different interpreter. */ old_stream = cli->cli_uiout->set_stream (gdb_stdout); - result = safe_execute_command (cli->cli_uiout, str, 1); + result = safe_execute_command (cli->cli_uiout, command_str, 1); cli->cli_uiout->set_stream (old_stream); return result; } @@ -357,7 +352,8 @@ cli_interp_base::supports_command_editing () } static struct gdb_exception -safe_execute_command (struct ui_out *command_uiout, char *command, int from_tty) +safe_execute_command (struct ui_out *command_uiout, const char *command, + int from_tty) { struct gdb_exception e = exception_none; struct ui_out *saved_uiout; -- cgit v1.2.1