From f2aec7f6d149c8a534e8246b0d3a50038864fa2d Mon Sep 17 00:00:00 2001 From: Christian Biesinger Date: Mon, 9 Sep 2019 12:55:39 -0500 Subject: Make relocate_{path,gdb_directory} return std::string This simplifies memory management. I've also changed some global variables to std::string accordingly (which store the result of these functions), but not all because some are used with add_setshow_optional_filename_cmd which requires a char*. gdb/ChangeLog: 2019-09-11 Christian Biesinger * auto-load.c (auto_load_expand_dir_vars): Update. * defs.h (gdb_datadir): Change to std::string. (python_libdir): Likewise. (relocate_gdb_directory): Change return type to std::string. * guile/guile.c (gdbscm_data_directory): Update. (initialize_scheme_side): Update. * jit.c (jit_reader_dir): Change to std::string. (jit_reader_load_command): Update. * main.c (gdb_datadir): Change to std::string. (python_libdir): Likewise. (set_gdb_data_directory): Update. (relocate_path): Change to return std::string. (relocate_gdb_directory): Change to return std::string. (relocate_gdbinit_path_maybe_in_datadir): Update. (captured_main_1): Update. * python/python.c (do_start_initialization): Update. * top.c (show_gdb_datadir): Update. * xml-syscall.c (xml_init_syscalls_info): Update. (init_syscalls_info): Update. --- gdb/auto-load.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gdb/auto-load.c') diff --git a/gdb/auto-load.c b/gdb/auto-load.c index 616aeb6fc96..115d5c10e82 100644 --- a/gdb/auto-load.c +++ b/gdb/auto-load.c @@ -178,7 +178,7 @@ static std::vector> auto_load_expand_dir_vars (const char *string) { char *s = xstrdup (string); - substitute_path_component (&s, "$datadir", gdb_datadir); + substitute_path_component (&s, "$datadir", gdb_datadir.c_str ()); substitute_path_component (&s, "$debugdir", debug_file_directory); if (debug_auto_load && strcmp (s, string) != 0) -- cgit v1.2.1