From c2f5dc30afa34696f2da0081c4ac50b958ecb0e9 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Fri, 7 Dec 2018 23:39:42 +1030 Subject: PR23952, memory leak in _bfd_generic_read_minisymbols bfd/ PR 23952 * syms.c (_bfd_generic_read_minisymbols): Free syms before returning with zero symcount. binutils/ * nm.c (display_rel_file): Use xrealloc to increase minisyms for synthetic symbols. --- binutils/ChangeLog | 5 +++++ binutils/nm.c | 9 +++------ 2 files changed, 8 insertions(+), 6 deletions(-) (limited to 'binutils') diff --git a/binutils/ChangeLog b/binutils/ChangeLog index d865bf6d327..a75f83b923b 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,8 @@ +2018-12-07 Alan Modra + + * nm.c (display_rel_file): Use xrealloc to increase minisyms + for synthetic symbols. + 2018-12-07 Nick Clifton * addr2line.c (demangle_flags): New static variable. diff --git a/binutils/nm.c b/binutils/nm.c index 8807832f978..39083c3f4e8 100644 --- a/binutils/nm.c +++ b/binutils/nm.c @@ -1175,17 +1175,14 @@ display_rel_file (bfd *abfd, bfd *archive_bfd) if (synth_count > 0) { asymbol **symp; - void *new_mini; long i; - new_mini = xmalloc ((symcount + synth_count + 1) * sizeof (*symp)); - symp = (asymbol **) new_mini; - memcpy (symp, minisyms, symcount * sizeof (*symp)); - symp += symcount; + minisyms = xrealloc (minisyms, + (symcount + synth_count + 1) * sizeof (*symp)); + symp = (asymbol **) minisyms + symcount; for (i = 0; i < synth_count; i++) *symp++ = synthsyms + i; *symp = 0; - minisyms = new_mini; symcount += synth_count; } } -- cgit v1.2.1