From 1594e052d4fec8690b6bfabd369bc030135eb91a Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Sat, 7 Jul 2018 21:23:53 +0930 Subject: xgate cleanup elf32-xgate.c contains many functions that are only stubs and elf32-xgate.h contains unused declarations. While this might be reasonable for the initial commit of a port with subsequent work fleshing out the stubs, xgate has only had two minor target specific patches since the initial commit over six years ago. The rest of the changes have been general maintenance work applied to all ELF targets, and some of this work could have been avoided if the stubs hadn't been there. So this patch removes all the stubs. I've kept the functionality of the old elf32_xgate_add_symbol_hook, implemented in elf32_xgate_backend_symbol_processing. Presumably, that's to set the symbol st_target_internal flag for use in elf32-m68hc1x.c:elf32_m68hc11_relocate_section. The empty elf32_xgate_relocate_section meant that xgate had no linker. Or at least, no linker relocation processing. Deleting the elf_backend_relocate_section define means the target will now use the generic linker reloc processing. How good that is will depend on the accuracy of the reloc howtos.. I haven't updated the ld testsuite to xfail tests expected to fail for generic elf targets. bfd/ * elf32-xgate.h: Delete. * elf32-xgate.c: Delete unnecessary forward declarations, add two that are now needed. (xgate_elf_bfd_link_hash_table_create) (xgate_elf_bfd_link_hash_table_free) (xgate_elf_set_mach_from_flags, struct xgate_scan_param) (stub_hash_newfunc, elf32_xgate_add_symbol_hook) (elf32_xgate_setup_section_lists, elf32_xgate_size_stubs) (elf32_xgate_build_stubs, elf32_xgate_check_relocs) (elf32_xgate_relocate_section, _bfd_xgate_elf_set_private_flags) (elf32_xgate_post_process_headers): Delete. (elf32_xgate_backend_symbol_processing): New function. (xgate_elf_ignore_reloc, xgate_elf_special_reloc) (_bfd_xgate_elf_print_private_bfd_data): Make static. (ELF_TARGET_ID, elf_info_to_howto, elf_backend_check_relocs) (elf_backend_relocate_section, elf_backend_object_p) (elf_backend_final_write_processing, elf_backend_can_gc_sections) (elf_backend_post_process_headers, elf_backend_add_symbol_hook) (bfd_elf32_bfd_link_hash_table_create) (bfd_elf32_bfd_set_private_flags) (xgate_stub_hash_lookup): Don't define. (elf_backend_symbol_processing): Define. * elf-bfd.h (elf_target_id): Delete XGATE_ELF_DATA. ld/ * emulparams/xgateelf.sh (TEMPLATE_NAME) Set to generic. (EXTRA_EM_FILE): Set to genelf. --- bfd/elf32-xgate.h | 142 ------------------------------------------------------ 1 file changed, 142 deletions(-) delete mode 100644 bfd/elf32-xgate.h (limited to 'bfd/elf32-xgate.h') diff --git a/bfd/elf32-xgate.h b/bfd/elf32-xgate.h deleted file mode 100644 index 99ab9a4935d..00000000000 --- a/bfd/elf32-xgate.h +++ /dev/null @@ -1,142 +0,0 @@ -/* Freescale XGATE-specific support for 32-bit ELF - Copyright (C) 2012-2018 Free Software Foundation, Inc. - - Contributed by Sean Keys (skeys@ipdatasys.com) - (Heavily copied from the HC11 port by Stephane Carrez (stcarrez@nerim.fr)) - - This file is part of BFD, the Binary File Descriptor library. - - This program is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, - MA 02110-1301, USA. */ - -#ifndef _ELF32_XGATE_H -#define _ELF32_XGATE_H - -#include "elf-bfd.h" -#include "bfdlink.h" -#include "elf/xgate.h" - -/* Set and control ELF flags in ELF header. */ -extern bfd_boolean _bfd_xgate_elf_set_private_flags (bfd*,flagword); -extern bfd_boolean _bfd_xgate_elf_print_private_bfd_data (bfd*, void*); - -struct elf32_xgate_stub_hash_entry -{ - /* Base hash table entry structure. */ - struct bfd_hash_entry root; - - /* The stub section. */ - asection *stub_sec; - - /* Offset within stub_sec of the beginning of this stub. */ - bfd_vma stub_offset; - - /* Given the symbol's value and its section we can determine its final - value when building the stubs (so the stub knows where to jump. */ - bfd_vma target_value; - asection *target_section; -}; - -struct xgate_page_info -{ - bfd_vma bank_virtual; - bfd_vma bank_physical; - bfd_vma bank_physical_end; - bfd_vma bank_mask; - bfd_vma bank_size; - int bank_shift; - int bank_param_initialized; - bfd_vma trampoline_addr; -}; - -struct xgate_elf_link_hash_table -{ - struct elf_link_hash_table root; - struct xgate_page_info pinfo; - - /* The stub hash table. */ - struct bfd_hash_table* stub_hash_table; - - /* Linker stub bfd. */ - bfd *stub_bfd; - - asection* stub_section; - asection* tramp_section; - - /* Linker call-backs. */ - asection * (*add_stub_section) (const char *, asection *); - - /* Assorted information used by elf32_hppa_size_stubs. */ - unsigned int bfd_count; - int top_index; - asection ** input_list; - - /* Small local sym cache. */ - struct sym_cache sym_cache; - - bfd_boolean (*size_one_stub) (struct bfd_hash_entry*, void*); - bfd_boolean (*build_one_stub) (struct bfd_hash_entry*, void*); -}; - -/* Get the XGate ELF linker hash table from a link_info structure. */ - -#define xgate_elf_hash_table(p) \ - ((struct xgate_elf_link_hash_table *) ((p)->hash)) - -/* Create a XGATE ELF linker hash table. */ - -extern struct xgate_elf_link_hash_table* xgate_elf_hash_table_create - (bfd *); - -extern void xgate_elf_get_bank_parameters (struct bfd_link_info *); - -/* Return 1 if the address is in banked memory. - This can be applied to a virtual address and to a physical address. */ -extern int xgate_addr_is_banked (struct xgate_page_info *, bfd_vma); - -/* Return the physical address seen by the processor, taking - into account banked memory. */ -extern bfd_vma xgate_phys_addr (struct xgate_page_info *, bfd_vma); - -/* Return the page number corresponding to an address in banked memory. */ -extern bfd_vma xgate_phys_page (struct xgate_page_info *, bfd_vma); - -bfd_reloc_status_type xgate_elf_ignore_reloc - (bfd *, arelent *, asymbol *, void *, asection *, bfd *, char **); -bfd_reloc_status_type xgate_elf_special_reloc - (bfd *, arelent *, asymbol *, void *, asection *, bfd *, char **); - -bfd_boolean elf32_xgate_check_relocs - (bfd *, struct bfd_link_info *, asection *, const Elf_Internal_Rela *); -bfd_boolean elf32_xgate_relocate_section - (bfd *, struct bfd_link_info *, bfd *, asection *, bfd_byte *, - Elf_Internal_Rela *, Elf_Internal_Sym *, asection **); - -bfd_boolean elf32_xgate_add_symbol_hook - (bfd *, struct bfd_link_info *, Elf_Internal_Sym *, const char **, - flagword *, asection **, bfd_vma *); - -/* Tweak the OSABI field of the elf header. */ -extern void elf32_xgate_post_process_headers (bfd *, struct bfd_link_info *); - -int elf32_xgate_setup_section_lists (bfd *, struct bfd_link_info *); - -bfd_boolean elf32_xgate_size_stubs - (bfd *, bfd *, struct bfd_link_info *, - asection * (*) (const char *, asection *)); - -bfd_boolean elf32_xgate_build_stubs (bfd * abfd, struct bfd_link_info *); - -#endif /* _ELF32_XGATE_H */ -- cgit v1.2.1