From f6a8b8c7ac2d5369070a6b76a94ee0f3052433ff Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Thu, 19 Apr 2018 14:13:41 +0930 Subject: PR22537, Segmentation fault with static PIE The only stub type that makes sense for undefined symbols, or those defined in shared libraries, is a plt call stub. This patch arranges to have "destination" set to -1 on such symbols, making for an easy test in hppa_type_of_stub. PR 22537 * elf32-hppa.c (elf32_hppa_size_stubs): Init "destination" to -1. (hppa_type_of_stub): Don't return a long branch stub for symbols other than those defined statically. --- bfd/elf32-hppa.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'bfd/elf32-hppa.c') diff --git a/bfd/elf32-hppa.c b/bfd/elf32-hppa.c index 3ce38078b8d..44fb753c0ea 100644 --- a/bfd/elf32-hppa.c +++ b/bfd/elf32-hppa.c @@ -612,6 +612,9 @@ hppa_type_of_stub (asection *input_sec, return hppa_stub_import; } + if (destination == (bfd_vma) -1) + return hppa_stub_none; + /* Determine where the call point is. */ location = (input_sec->output_offset + input_sec->output_section->vma @@ -2843,7 +2846,7 @@ elf32_hppa_size_stubs section. */ sym_sec = NULL; sym_value = 0; - destination = 0; + destination = -1; hh = NULL; if (r_indx < symtab_hdr->sh_info) { -- cgit v1.2.1