From 0e158763b0c5671cd40cdd2faee48d6659489ddd Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Fri, 23 Jun 2017 10:22:36 +0100 Subject: Make the strings utility reject directories. PR binutils/21659 * strings.c (strings_file): Warn about attempts to run strings on a directory. --- binutils/ChangeLog | 6 ++++++ binutils/strings.c | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 484632addb5..b4672fa50c5 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,9 @@ +2017-06-23 Nick Clifton + + PR binutils/21659 + * strings.c (strings_file): Warn about attempts to run strings on + a directory. + 2017-06-22 H.J. Lu * readelf.c (decode_x86_feature): Decode diff --git a/binutils/strings.c b/binutils/strings.c index 13e261923b8..77d89eb9812 100644 --- a/binutils/strings.c +++ b/binutils/strings.c @@ -446,6 +446,11 @@ strings_file (char *file) file, strerror (errno)); return FALSE; } + else if (S_ISDIR (st.st_mode)) + { + non_fatal (_("Warning: '%s' is a directory"), file); + return FALSE; + } /* If we weren't told to scan the whole file, try to open it as an object file and only look at -- cgit v1.2.1