diff options
| author | Lancelot SIX <lsix@lancelotsix.com> | 2021-01-11 22:40:59 +0000 |
|---|---|---|
| committer | Lancelot SIX <lsix@lancelotsix.com> | 2021-01-23 17:17:38 +0000 |
| commit | d3ee35dbf754b72461f67a29892fff0d10961065 (patch) | |
| tree | 5c7fe4009561e03320af100268f1afad55d467dd /gdbsupport/ChangeLog | |
| parent | ef45cb65a7be9f80686233d0e5586ced81613db0 (diff) | |
| download | binutils-gdb-d3ee35dbf754b72461f67a29892fff0d10961065.tar.gz | |
Improve gdb_tilde_expand logic.
Before this patch, gdb_tilde_expand would use glob(3) in order to expand
tilde at the begining of a path. This implementation has limitation when
expanding a tilde leading path to a non existing file since glob fails to
expand.
This patch proposes to use glob only to expand the tilde component of the
path and leaves the rest of the path unchanged.
This patch is a followup to the following discution:
https://sourceware.org/pipermail/gdb-patches/2021-January/174776.html
Before the patch:
gdb_tilde_expand("~") -> "/home/lsix"
gdb_tilde_expand("~/a/c/b") -> error() is called
After the patch:
gdb_tilde_expand("~") -> "/home/lsix"
gdb_tilde_expand("~/a/c/b") -> "/home/lsix/a/c/b"
Tested on x84_64 linux.
gdb/ChangeLog:
* Makefile.in (SELFTESTS_SRCS): Add
unittests/gdb_tilde_expand-selftests.c.
* unittests/gdb_tilde_expand-selftests.c: New file.
gdbsupport/ChangeLog:
* gdb_tilde_expand.cc (gdb_tilde_expand): Improve
implementation.
(gdb_tilde_expand_up): Delegate logic to gdb_tilde_expand.
* gdb_tilde_expand.h (gdb_tilde_expand): Update description.
Diffstat (limited to 'gdbsupport/ChangeLog')
| -rw-r--r-- | gdbsupport/ChangeLog | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog index 487107e3b14..fe6138ca2de 100644 --- a/gdbsupport/ChangeLog +++ b/gdbsupport/ChangeLog @@ -1,3 +1,10 @@ +2021-01-23 Lancelot SIX <lsix@lancelotsix.com> + + * gdb_tilde_expand.cc (gdb_tilde_expand): Improve + implementation. + (gdb_tilde_expand_up): Delegate logic to gdb_tilde_expand. + * gdb_tilde_expand.h (gdb_tilde_expand): Update description. + 2021-01-22 Simon Marchi <simon.marchi@polymtl.ca> * common-debug.h (debug_prefixed_printf_cond_nofunc): New. |