diff options
| author | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-06-14 13:13:58 +0200 |
|---|---|---|
| committer | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-06-22 14:24:38 +0200 |
| commit | 6e713425a0dcede167924e7691e95ab5e54e399c (patch) | |
| tree | 4ce8cbe368733dc0049b5b690b13e0e3123d7a3a /t/parallel-tests-exit-statuses.sh | |
| parent | d0dc448517d3a61ba55e62dd76b9a42b68bef8f8 (diff) | |
| download | automake-6e713425a0dcede167924e7691e95ab5e54e399c.tar.gz | |
tests: use more POSIX shell features our test scripts
Since commit 'v1.12-36-g2d68fd9' of 2012-05-07, "configure: search a
sturdy POSIX shell to be used in the testsuite", the shell running
our test script is assured to be a POSIX-conforming shell, so we can
use the more modern and flexible idioms and features that we couldn't
use when we also aimed at compatibility with non-POSIX Bourne shells,
like Solaris /bin/sh.
* t/README: Suggest to use POSIX shell features liberally in test cases,
with possible exception of Makefile recipes and configure shell code.
* Several tests: Adjust to use more POSIX shell features; e.g., $(...)
rather than `...`, $((...)) rather than `expr ...`, "if ! CMD; then ..."
instead of "if CMD; then :; else ...", and so on.
In several places, when using the 'test' built-in, prefer '-eq' over
'=' for numeric comparisons, and prefer "grep -c PATTERN FILE" over
"grep PATTERN FILE | wc -l".
Throw in other low-hanging easy improvements and fixlets while we are
at it.
* t/ax/depcomp.sh, t/ax/tap-summary-aux.sh, t/ax/tap-functions.sh,
defs, defs-static.in: Likewise.
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Diffstat (limited to 't/parallel-tests-exit-statuses.sh')
| -rwxr-xr-x | t/parallel-tests-exit-statuses.sh | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/t/parallel-tests-exit-statuses.sh b/t/parallel-tests-exit-statuses.sh index 90583d59c..8d8e6a972 100755 --- a/t/parallel-tests-exit-statuses.sh +++ b/t/parallel-tests-exit-statuses.sh @@ -25,15 +25,15 @@ END # $failure_statuses should be defined to the list of all integers between # 1 and 255 (inclusive), excluded 77 and 99. -failure_statuses=`seq_ 1 255 | $EGREP -v '^(77|99)$' | tr "$nl" ' '` +failure_statuses=$(seq_ 1 255 | $EGREP -v '^(77|99)$' | tr "$nl" ' ') # For debugging. echo "failure_statuses: $failure_statuses" # Sanity check. -test `for st in $failure_statuses; do echo $st; done | wc -l` -eq 253 \ +test $(for st in $failure_statuses; do echo $st; done | wc -l) -eq 253 \ || fatal_ "initializing list of exit statuses for simple failures" cat > Makefile.am <<END -LOG_COMPILER = ./do-exit +LOG_COMPILER = $AM_TEST_RUNNER_SHELL ./do-exit fail_tests = $failure_statuses TESTS = 0 77 99 $failure_statuses \$(TESTS): @@ -44,7 +44,7 @@ cat > do-exit <<'END' echo "$0: $1" case $1 in [0-9]|[0-9][0-9]|[0-9][0-9][0-9]) st=$1;; - */[0-9]|*/[0-9][0-9]|*/[0-9][0-9][0-9]) st=`echo x"$1" | sed 's|.*/||'`;; + */[0-9]|*/[0-9][0-9]|*/[0-9][0-9][0-9]) st=${1##*/};; *) st=99;; esac exit $st |