diff options
| author | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-06-14 13:13:58 +0200 |
|---|---|---|
| committer | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-06-22 14:24:38 +0200 |
| commit | 6e713425a0dcede167924e7691e95ab5e54e399c (patch) | |
| tree | 4ce8cbe368733dc0049b5b690b13e0e3123d7a3a /t/ax/tap-summary-aux.sh | |
| parent | d0dc448517d3a61ba55e62dd76b9a42b68bef8f8 (diff) | |
| download | automake-6e713425a0dcede167924e7691e95ab5e54e399c.tar.gz | |
tests: use more POSIX shell features our test scripts
Since commit 'v1.12-36-g2d68fd9' of 2012-05-07, "configure: search a
sturdy POSIX shell to be used in the testsuite", the shell running
our test script is assured to be a POSIX-conforming shell, so we can
use the more modern and flexible idioms and features that we couldn't
use when we also aimed at compatibility with non-POSIX Bourne shells,
like Solaris /bin/sh.
* t/README: Suggest to use POSIX shell features liberally in test cases,
with possible exception of Makefile recipes and configure shell code.
* Several tests: Adjust to use more POSIX shell features; e.g., $(...)
rather than `...`, $((...)) rather than `expr ...`, "if ! CMD; then ..."
instead of "if CMD; then :; else ...", and so on.
In several places, when using the 'test' built-in, prefer '-eq' over
'=' for numeric comparisons, and prefer "grep -c PATTERN FILE" over
"grep PATTERN FILE | wc -l".
Throw in other low-hanging easy improvements and fixlets while we are
at it.
* t/ax/depcomp.sh, t/ax/tap-summary-aux.sh, t/ax/tap-functions.sh,
defs, defs-static.in: Likewise.
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Diffstat (limited to 't/ax/tap-summary-aux.sh')
| -rw-r--r-- | t/ax/tap-summary-aux.sh | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/t/ax/tap-summary-aux.sh b/t/ax/tap-summary-aux.sh index f5d1fbdfe..2fadb3d2b 100644 --- a/t/ax/tap-summary-aux.sh +++ b/t/ax/tap-summary-aux.sh @@ -311,7 +311,7 @@ done > tap # Lots of non-failures (300 per kind). (cat tap && cat tap && cat tap) > all.test -test `wc -l <all.test` -eq 900 || Exit 99 # Sanity check. +test $(wc -l <all.test) -eq 900 || Exit 99 # Sanity check. echo 1..900 >> all.test # Test plan. do_check --pass <<END $success_header @@ -327,7 +327,7 @@ END # 1 failure and lots of non-failures means failure. (cat tap && echo "not ok" && cat tap) > all.test -test `wc -l <all.test` -eq 601 || Exit 99 # Sanity check. +test $(wc -l <all.test) -eq 601 || Exit 99 # Sanity check. echo 1..601 >> all.test # Test plan. do_check --fail <<END $failure_header @@ -343,7 +343,7 @@ END # 1 error and lots of non-failures means failure. (cat tap && sed 30q tap && echo 'Bail out!') > all.test -test `wc -l <all.test` -eq 331 || Exit 99 # Sanity check. +test $(wc -l <all.test) -eq 331 || Exit 99 # Sanity check. echo 1..331 >> all.test # Test plan. do_check --fail <<END $failure_header |