summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Notifying observers of sound properties only by value changes.genivi_impJacqueline Molz2018-08-225-303/+375
| | | | | | | | | Fix infinite loop in CAmDltWrapper by logging out enum values exceeding the boundaries. Minor changes: Pull request 36 changed implementation to database macros (review comments) added option "WITH_DATABASE_CHANGE_CHECK" to audiomanagerconfig.h.in whitespace cleanup in test/AmMapHandlerTest/CAmMapHandlerTest.cpp additional cast to uint in DB_UPDATE call in function removeMainConnectionDB to solve error in macro expansion
* Merge pull request #35 from JensLorenz/issue_24_clean_up_whitespaceGENIVI Audio Manager Maintainer2018-07-1236-8827/+9785
|\ | | | | Issue #24 clean up whitespace
| * FOO: Issue #26 fix white space issues and apply new coding styleJens Lorenz2018-07-0335-8817/+9783
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * FOO: Remove missing logging files in uncrustify_files.cfgJens Lorenz2018-07-031-10/+2
|/ | | | | | Linked files are wrongly referenced. They will be provided in a later PR. Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
* Merge pull request #34 from JensLorenz/foo_beatifier_uncrustifyGENIVI Audio Manager Maintainer2018-07-0322-230/+442
|\ | | | | Clean up whitespace #24: Provide configuration files for the beautifier uncrustify
| * Foo: Initial proposal for the command line beautifier uncrustifyJens Lorenz2018-06-202-0/+257
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * codestyle: Remove empty single line c++ comments in ctor initializersJens Lorenz2018-06-2014-124/+124
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMCore: Rework of preprocessor defines to improve readabilityJens Lorenz2018-06-204-102/+57
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * CMAKE: Rename the input cmake file of audiomanagerconfig.hJens Lorenz2018-06-202-4/+4
|/ | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
* Merge pull request #32 from JensLorenz/clean_pr26_utility_updatesGENIVI Audio Manager Maintainer2018-06-2010-573/+982
|\ | | | | Clean pr26 utility updates
| * AMUtil: Fix inconsistent fdPollingArrayJens Lorenz2018-06-123-116/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In case someone removed a fd and closed it opened a new one and added it to the socket handler the container state of the object in map was changed from either REMOVE/CLOSE to UNINIT. This leads to the emplace call in the fdPollingArray vector and the fd is maintained twice. Over the entire runtime there will be zombie fds provided to ppoll functions which will race a POLLERR revent leading to 100% cpu load. Also the CLOSE state is now removed because only the application is aware if a fd has to be closed. For instance calling add/remove in a loop were start_listenting is not running will turn to a system issue were no fds can be provided by the operation system. Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Test: Return in threads with NULLJens Lorenz2018-04-231-0/+6
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMCore: Test: Initialize file descriptors of pipe with '-1' in ctorJens Lorenz2018-04-231-1/+2
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: No check callback needed for eventfd and signalfdJens Lorenz2018-04-091-5/+2
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Change log level of removeFDPoll from error to warningJens Lorenz2018-04-091-1/+1
| | | | | | | | | | | | | | It is not an error in case the requested fdpoll is not part of the internal database. I just worth to print a warning here. Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Store signalfd as file descriptor instead of pollfd handleJens Lorenz2018-04-092-46/+21
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Wakeup of ppoll is now also triggered on addFdPollJens Lorenz2018-04-092-16/+17
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Fix startup sequence addFdPoll and removeFdPollJens Lorenz2018-04-092-4/+87
| | | | | | | | | | | | | | | | | | | | In case plugins add new fdpoll elements and directly removing them afterwards the state inside the structure will be changed to REMOVE. REMOVE will lead all the time to an erase which will not work in case the pointer is at .end() of vector or the element itself is not the correct one. Both cases will be fixed just by checking if the fd is the same. Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Cleanup indents and whitespacesJens Lorenz2018-04-093-33/+34
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Rework of exception debug messagesJens Lorenz2018-04-091-13/+15
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: ONLY timers will be closed in worker threadJens Lorenz2018-04-092-9/+18
| | | | | | | | | | | | | | The removeFDPoll API is extended to allow applications to close the fd by the central worker thread. Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Rework of socketHandler to avoid calls of invalidated objectsJens Lorenz2018-04-094-219/+505
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch tries to follow the idea raised in PR26. Following two patches have been reworked: commit: cfe0e77aaf87a0590ceea42f6afa62b0c7d95e80 commit: bc33226f59910a960f62d419ba10d4ea761e3724 The biggest change applies to the internal database. Instead of having a vector for all items which will be copied inside the worker thread the new approach aims a central map which allows to store the sh_poll elements in containers. By this a container is valid until it is remove from map. The remove of items inside a map is now centralized within the worker and only the worker is responsible to keep the ppoll list and the map in sync. This patch also extends the unit tests to stress different timer scenarios. Signed-off-by: Aleksandar Donchev <Aleksander.Donchev@partner.bmw.de> Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Change from mPipe to eventfdJens Lorenz2018-04-092-20/+41
| | | | | | | | | | | | This commit is the first commit of a rework of the CAmSochetHandler class. Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Improve timer implementation and ensure that no fd leak happensJens Lorenz2018-04-092-48/+50
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Rework of listenToSignal and minor improvementsJens Lorenz2018-04-091-17/+15
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Improve actionPoll lambda implementation for signal and timerJens Lorenz2018-04-091-27/+45
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Test: Ensure that revents are tested in fire callbackJens Lorenz2018-04-091-2/+2
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Test: Lets check the return value of addTimerJens Lorenz2018-04-091-13/+14
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Test: Remove off-by-one problem for timer meas. and socket testsJens Lorenz2018-04-091-45/+39
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Test: Fix mExpected value range for 32-bitJens Lorenz2018-04-092-2/+2
| | | | | | | | | | | | | | The duration calculation for mExpected is not working. The playWithTimers oneshot test reported all times warnings. Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * CMAKE: Update option messageAleksandar Donchev2018-03-271-3/+1
| | | | | | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
| * AMUtil: Test: Add macro to increase the loop count of serializer testsAleksandar Donchev2018-03-271-2/+5
| | | | | | | | Signed-off-by: Christian Linke <christian.linke@bmw.de>
| * AMUtil: Common API WrapperAleksandar Donchev2018-03-272-106/+124
| | | | | | | | | | | | | | | | | | All methods in CAPI wrapper with connectionID parameter are deprecated because CAPI creates new filedescriptor per connection which isn't needed. * revents flag is passed to the CommonAPI watcher instead events * revents set to 0 in Sockethandler Signed-off-by: Christian Linke <christian.linke@bmw.de>
| * AMUtil: Dlt init function returns now correctlyAleksandar Donchev2018-03-271-2/+3
|/ | | | Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
* Merge pull request #31 from gunnarx/sorted_indent_rulesGENIVI Audio Manager Maintainer2018-03-261-132/+144
|\ | | | | Sorted code style config file
| * Foo: Apply formatting changes as proposed in pr 28Gunnar Andersson2018-03-161-5/+17
| | | | | | | | | | | | | | | | Applied changes proposed by @JensLorenz in e2bc7099 except this time the lines are sorted for efficient diffing. Signed-off-by: Gunnar Andersson <gandersson@genivi.org>
| * Foo: Sort all the settings in the code style XMLGunnar Andersson2018-03-161-131/+131
|/ | | | | | | | | Sorting all lines (No changes to the settings). This is so that subsequent changes (may also need manual sorting) can be actually compared. It seemed on another change that Eclipse may move things around so that it's impossible to diff. Signed-off-by: Gunnar Andersson <gandersson@genivi.org>
* Merge pull request #30 from GENIVI/revert-26-utilityUpdates_CAPI_fixesGENIVI Audio Manager Maintainer2018-03-139-932/+429
|\ | | | | Revert "Utility updates capi fixes"
| * Revert "Utility updates capi fixes"revert-26-utilityUpdates_CAPI_fixesJens Lorenz2018-03-139-932/+429
|/
* Merge pull request #26 from GENIVI/utilityUpdates_CAPI_fixesGENIVI Audio Manager Maintainer2018-03-139-429/+932
|\ | | | | Utility updates capi fixes
| * Remainning fixes from utility updateutilityUpdates_CAPI_fixesDon Al2018-02-273-104/+114
| | | | | | | | | | Signed-off-by: Christian Linke <christian.linke@bmw.de> Change-Id: I3c8a2b474bc8fac62c76a46545a231c718edb2a9
| * The real-time scheduler removed.Aleksandar Donchev2018-02-137-62/+3
| | | | | | | | | | | | Signed-off-by: Christian Linke <christian.linke@bmw.de> Change-Id: I7c8a2c474bc8fac62c76a46545a231c518edb2a8
| * Cmake parameters for real-time scheduler's priority and policy and throw ↵Aleksandar Donchev2018-02-137-65/+120
| | | | | | | | | | | | | | | | runtime error if read fails. Signed-off-by: Christian Linke <christian.linke@bmw.de> Change-Id: I6a7a2c424bc8fac62c76a66545a231c518edb2e1
| * FIx for CAPI timeouts and support for more than one CAPI watchAleksandar Donchev2018-02-132-116/+198
| | | | | | | | | | Signed-off-by: Christian Linke <christian.linke@bmw.de> Change-Id: I9a9d2c424bc8fac62c76a66545a531c518edb2e3
| * Real time scheduler added, capi wrapper timeout return value considered in ↵Aleksandar Donchev2018-02-135-67/+90
| | | | | | | | | | | | | | registerTimeout, only requested revent passed from within the camsockethandler instead of all Signed-off-by: Christian Linke <christian.linke@bmw.de> Change-Id: I2d9d2c424ac3fac62c76a66545a531c518edb2e8
| * * All methods in CAPI wrapper with connectionID parameter are deprecated ↵Aleksandar Donchev2018-02-134-121/+119
| | | | | | | | | | | | | | | | | | | | | | because CommonAPI creates new filedescriptor per connection which isn't needed. * revents flag is passed to the CommonAPI watcher instead events * revents set to 0 in Sockethandler Signed-off-by: Christian Linke <christian.linke@bmw.de> Change-Id: I9d9d2c424ac9fad62c76a66545c731c518adb2e4
| * Runtime check for calls to the sockethandler from other threadsAleksandar Donchev2018-02-133-56/+99
| | | | | | | | | | | | Signed-off-by: Christian Linke <christian.linke@bmw.de> Change-Id: I9d9d3c424ac9fad62c76a76545c731b518bdb1e2
| * A filedescriptor removal will set an invalidation flag which will prevent ↵Aleksandar Donchev2018-02-133-44/+61
| | | | | | | | | | | | | | | | | | | | | | calls on the invalidated objects in the current iteration. Signed-off-by: Christian Linke <christian.linke@bmw.de> Change-Id: I9d5d3c434ac9fad62c76a76145c731b538aeb1e3 # Conflicts: # AudioManagerUtilities/src/CAmSocketHandler.cpp
| * Timer fd is closed at the beginning of the next iteration + some unit tests. ↵Aleksandar Donchev2018-02-135-44/+378
| | | | | | | | | | | | Signed-off-by: Christian Linke <christian.linke@bmw.de> Change-Id: I8c5d3c436ac9fad62c76a26145c731b538abb1e7
* | Merge pull request #25 from JensLorenz/version_and_doc_updateGENIVI Audio Manager Maintainer2018-02-26975-36121/+22169
|\ \ | |/ |/| Version and doc update