From 9a74d2e023007deceb808d8687acc561a195f0bb Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 8 Apr 2020 12:41:32 +0200 Subject: dns: add FIXME comment about adding default "~" routing search domain --- src/dns/nm-dns-manager.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/dns/nm-dns-manager.c') diff --git a/src/dns/nm-dns-manager.c b/src/dns/nm-dns-manager.c index a3c3a59c47..ac8a2afc41 100644 --- a/src/dns/nm-dns-manager.c +++ b/src/dns/nm-dns-manager.c @@ -1321,6 +1321,11 @@ rebuild_domain_lists (NMDnsManager *self) * If there is no default route, add the wildcard domain to all non-VPN * connections */ if (default_route_found) { + /* FIXME: this heuristic of which device has a default route does + * not work with policy routing (as used by default with WireGuard). + * We should have a more stable mechanism where an NMIPConfig indicates + * whether it is suitable for certain operations (like having an automatically + * added "~" domain). */ if (nm_ip_config_best_default_route_get (ip_config)) domains[num_dom1++] = "~"; } else { -- cgit v1.2.1