From ec982ceb8ebc9a2f9c3ee14f89735bce818ee948 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 2 Aug 2019 08:33:32 +0200 Subject: cli: fix dereferncing NULL pointer in parse_passwords() with empty file Warned by coverity. --- clients/cli/connections.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'clients/cli/connections.c') diff --git a/clients/cli/connections.c b/clients/cli/connections.c index c88fbd2abb..b8905cc78a 100644 --- a/clients/cli/connections.c +++ b/clients/cli/connections.c @@ -2711,7 +2711,6 @@ parse_passwords (const char *passwd_file, GError **error) if (!passwd_file) return g_steal_pointer (&pwds_hash); - /* Read the passwords file */ if (!g_file_get_contents (passwd_file, &contents, &len, &local_err)) { g_set_error (error, NMCLI_ERROR, NMC_RESULT_ERROR_USER_INPUT, _("failed to read passwd-file '%s': %s"), @@ -2721,7 +2720,7 @@ parse_passwords (const char *passwd_file, GError **error) } strv = nm_utils_strsplit_set (contents, "\r\n"); - for (iter = strv; *iter; iter++) { + for (iter = strv; strv && *iter; iter++) { gs_free char *iter_s = g_strdup (*iter); pwd = strchr (iter_s, ':'); -- cgit v1.2.1