From ef1ae93fc1b00f58ad7554245eac5ccfe4c9ad74 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 9 Dec 2022 18:04:09 +0100 Subject: core: fix returning invalid pointer from nm_netns_l3cfg_get() The code isn't actually used outside of tests. Fixes: 15f5d1035254 ('l3cfg: add nm_netns_get_l3cfg() accessor') (cherry picked from commit e3d3b001e024e7ff6a0250d43076eec16004d42a) --- src/core/nm-netns.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/core/nm-netns.c b/src/core/nm-netns.c index 5ee6315292..859dbb21b6 100644 --- a/src/core/nm-netns.c +++ b/src/core/nm-netns.c @@ -129,13 +129,16 @@ NML3Cfg * nm_netns_l3cfg_get(NMNetns *self, int ifindex) { NMNetnsPrivate *priv; + L3CfgData *l3cfg_data; g_return_val_if_fail(NM_IS_NETNS(self), NULL); g_return_val_if_fail(ifindex > 0, NULL); priv = NM_NETNS_GET_PRIVATE(self); - return g_hash_table_lookup(priv->l3cfgs, &ifindex); + l3cfg_data = g_hash_table_lookup(priv->l3cfgs, &ifindex); + + return l3cfg_data ? l3cfg_data->l3cfg : NULL; } NML3Cfg * -- cgit v1.2.1