From edda3d36064dba517c9b312210d56c28f880db4a Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Thu, 7 Nov 2019 14:14:32 +0100 Subject: n-dhcp4/lease: expose the server IP address This is useful for network booting. https://github.com/nettools/n-dhcp4/pull/7 --- shared/n-dhcp4/src/libndhcp4.sym | 1 + shared/n-dhcp4/src/n-dhcp4-c-lease.c | 14 ++++++++++++++ shared/n-dhcp4/src/n-dhcp4.h | 1 + shared/n-dhcp4/src/test-api.c | 1 + 4 files changed, 17 insertions(+) diff --git a/shared/n-dhcp4/src/libndhcp4.sym b/shared/n-dhcp4/src/libndhcp4.sym index b9ba800a3b..0659926bec 100644 --- a/shared/n-dhcp4/src/libndhcp4.sym +++ b/shared/n-dhcp4/src/libndhcp4.sym @@ -34,6 +34,7 @@ global: n_dhcp4_client_lease_ref; n_dhcp4_client_lease_unref; n_dhcp4_client_lease_get_yiaddr; + n_dhcp4_client_lease_get_siaddr; n_dhcp4_client_lease_get_lifetime; n_dhcp4_client_lease_query; n_dhcp4_client_lease_select; diff --git a/shared/n-dhcp4/src/n-dhcp4-c-lease.c b/shared/n-dhcp4/src/n-dhcp4-c-lease.c index 208ad92a6a..c14a9daf0a 100644 --- a/shared/n-dhcp4/src/n-dhcp4-c-lease.c +++ b/shared/n-dhcp4/src/n-dhcp4-c-lease.c @@ -203,6 +203,20 @@ _c_public_ void n_dhcp4_client_lease_get_yiaddr(NDhcp4ClientLease *lease, struct yiaddr->s_addr = header->yiaddr; } +/** + * n_dhcp4_client_lease_get_siaddr() - get the server IP address + * @lease: the lease to operate on + * @siaddr: return argument for the IP address + * + * Gets the server IP address cotained in the lease. Or INADDR_ANY if the + * lease does not contain an IP address. + */ +_c_public_ void n_dhcp4_client_lease_get_siaddr(NDhcp4ClientLease *lease, struct in_addr *siaddr) { + NDhcp4Header *header = n_dhcp4_incoming_get_header(lease->message); + + siaddr->s_addr = header->siaddr; +} + /** * n_dhcp4_client_lease_get_lifetime() - get the lifetime * @lease: the lease to operate on diff --git a/shared/n-dhcp4/src/n-dhcp4.h b/shared/n-dhcp4/src/n-dhcp4.h index 58a3cb803a..ef75eca7c8 100644 --- a/shared/n-dhcp4/src/n-dhcp4.h +++ b/shared/n-dhcp4/src/n-dhcp4.h @@ -156,6 +156,7 @@ NDhcp4ClientLease *n_dhcp4_client_lease_ref(NDhcp4ClientLease *lease); NDhcp4ClientLease *n_dhcp4_client_lease_unref(NDhcp4ClientLease *lease); void n_dhcp4_client_lease_get_yiaddr(NDhcp4ClientLease *lease, struct in_addr *yiaddr); +void n_dhcp4_client_lease_get_siaddr(NDhcp4ClientLease *lease, struct in_addr *siaddr); void n_dhcp4_client_lease_get_lifetime(NDhcp4ClientLease *lease, uint64_t *ns_lifetimep); int n_dhcp4_client_lease_query(NDhcp4ClientLease *lease, uint8_t option, uint8_t **datap, size_t *n_datap); diff --git a/shared/n-dhcp4/src/test-api.c b/shared/n-dhcp4/src/test-api.c index 9e7b6bcaa7..be2d7b36a0 100644 --- a/shared/n-dhcp4/src/test-api.c +++ b/shared/n-dhcp4/src/test-api.c @@ -104,6 +104,7 @@ static void test_api_functions(void) { (void *)n_dhcp4_client_lease_unrefp, (void *)n_dhcp4_client_lease_unrefv, (void *)n_dhcp4_client_lease_get_yiaddr, + (void *)n_dhcp4_client_lease_get_siaddr, (void *)n_dhcp4_client_lease_get_lifetime, (void *)n_dhcp4_client_lease_query, (void *)n_dhcp4_client_lease_select, -- cgit v1.2.1 From c1104a5cc2ff2fce9831e7ccc9286e91bd48120d Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Thu, 7 Nov 2019 13:26:38 +0100 Subject: dhcp/nettools: add siaddr to lease options This is so that we end up with a next-server option analogous to what dhclient helper sends us. Dracut uses this for networked boots. --- src/dhcp/nm-dhcp-nettools.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/dhcp/nm-dhcp-nettools.c b/src/dhcp/nm-dhcp-nettools.c index 49743eb148..e2719f8557 100644 --- a/src/dhcp/nm-dhcp-nettools.c +++ b/src/dhcp/nm-dhcp-nettools.c @@ -352,6 +352,7 @@ lease_parse_address (NDhcp4ClientLease *lease, const gint64 ts_clock_boottime = nm_utils_monotonic_timestamp_as_boottime (ts, 1); struct in_addr a_address; struct in_addr a_netmask; + struct in_addr a_next_server; guint32 a_plen; guint64 nettools_lifetime; gint64 a_lifetime; @@ -415,6 +416,16 @@ lease_parse_address (NDhcp4ClientLease *lease, NM_DHCP_OPTION_DHCP4_NM_EXPIRY, (guint64) a_expiry); + + n_dhcp4_client_lease_get_siaddr (lease, &a_next_server); + if (a_next_server.s_addr != INADDR_ANY) { + nm_utils_inet4_ntop (a_next_server.s_addr, addr_str); + nm_dhcp_option_add_option (options, + _nm_dhcp_option_dhcp4_options, + NM_DHCP_OPTION_DHCP4_NM_NEXT_SERVER, + addr_str); + } + nm_ip4_config_add_address (ip4_config, &((const NMPlatformIP4Address) { .address = a_address.s_addr, -- cgit v1.2.1