From 4d65a8fda10c0f1c4ddafcaaf6dd162b9005a374 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 4 Sep 2019 18:00:41 +0200 Subject: libnm: drop unused property setter NM_DEVICE_MANAGED NM_DEVICE_MANAGED was intended to work like NM_DEVICE_AUTOCONNECT: namely it would call the D-Bus property setter synchronously. But such behavior is horrendous, we certainly don't want blocking calls during a property getter. Luckily this one instance was unused and never worked as the property was marked as G_PARAM_READABLE. Just drop the setter. --- libnm/nm-device.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libnm/nm-device.c b/libnm/nm-device.c index b9f4acd454..2114db2a68 100644 --- a/libnm/nm-device.c +++ b/libnm/nm-device.c @@ -458,11 +458,6 @@ set_property (GObject *object, gboolean b; switch (prop_id) { - case PROP_MANAGED: - b = g_value_get_boolean (value); - if (priv->managed != b) - nm_device_set_managed (NM_DEVICE (object), b); - break; case PROP_AUTOCONNECT: b = g_value_get_boolean (value); if (priv->autoconnect != b) -- cgit v1.2.1