From 0c227e6b626ca37864ebdd77557c8b5fc9e2ec84 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 17 Apr 2015 15:15:38 +0200 Subject: device: use NMDeviceCapabilities enum for device capabilities (cherry picked from commit 2117bef864c1820da337e2b491ba67f865955ec0) --- src/devices/adsl/nm-device-adsl.c | 2 +- src/devices/bluetooth/nm-device-bt.c | 2 +- src/devices/nm-device-bond.c | 2 +- src/devices/nm-device-bridge.c | 2 +- src/devices/nm-device-ethernet.c | 2 +- src/devices/nm-device-generic.c | 2 +- src/devices/nm-device-infiniband.c | 2 +- src/devices/nm-device-vlan.c | 2 +- src/devices/nm-device.c | 4 ++-- src/devices/nm-device.h | 2 +- src/devices/team/nm-device-team.c | 2 +- src/devices/wwan/nm-device-modem.c | 2 +- src/tests/config/nm-test-device.c | 2 +- 13 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/devices/adsl/nm-device-adsl.c b/src/devices/adsl/nm-device-adsl.c index e664ff4850..ce265ba447 100644 --- a/src/devices/adsl/nm-device-adsl.c +++ b/src/devices/adsl/nm-device-adsl.c @@ -73,7 +73,7 @@ typedef struct { /**************************************************************/ -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *dev) { return ( NM_DEVICE_CAP_CARRIER_DETECT diff --git a/src/devices/bluetooth/nm-device-bt.c b/src/devices/bluetooth/nm-device-bt.c index 61371dddec..852ca39971 100644 --- a/src/devices/bluetooth/nm-device-bt.c +++ b/src/devices/bluetooth/nm-device-bt.c @@ -124,7 +124,7 @@ get_connection_bt_type (NMConnection *connection) return NM_BT_CAPABILITY_NONE; } -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *device) { return NM_DEVICE_CAP_IS_NON_KERNEL; diff --git a/src/devices/nm-device-bond.c b/src/devices/nm-device-bond.c index 6b4581082b..c0d7141f37 100644 --- a/src/devices/nm-device-bond.c +++ b/src/devices/nm-device-bond.c @@ -61,7 +61,7 @@ enum { /******************************************************************/ -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *dev) { return NM_DEVICE_CAP_CARRIER_DETECT; diff --git a/src/devices/nm-device-bridge.c b/src/devices/nm-device-bridge.c index a2ed4b4176..d2cc70c1bf 100644 --- a/src/devices/nm-device-bridge.c +++ b/src/devices/nm-device-bridge.c @@ -59,7 +59,7 @@ enum { /******************************************************************/ -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *dev) { return NM_DEVICE_CAP_CARRIER_DETECT; diff --git a/src/devices/nm-device-ethernet.c b/src/devices/nm-device-ethernet.c index 22d2bfa923..0bab1f5b97 100644 --- a/src/devices/nm-device-ethernet.c +++ b/src/devices/nm-device-ethernet.c @@ -370,7 +370,7 @@ update_initial_hw_address (NMDevice *dev) _LOGD (LOGD_DEVICE | LOGD_ETHER, "read initial MAC address %s", priv->initial_hw_addr); } -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *device) { NMDeviceEthernet *self = NM_DEVICE_ETHERNET (device); diff --git a/src/devices/nm-device-generic.c b/src/devices/nm-device-generic.c index f103ef8303..0704c7d313 100644 --- a/src/devices/nm-device-generic.c +++ b/src/devices/nm-device-generic.c @@ -45,7 +45,7 @@ enum { LAST_PROP }; -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *dev) { if (nm_platform_link_supports_carrier_detect (nm_device_get_ifindex (dev))) diff --git a/src/devices/nm-device-infiniband.c b/src/devices/nm-device-infiniband.c index e1af899507..cfb15c76e4 100644 --- a/src/devices/nm-device-infiniband.c +++ b/src/devices/nm-device-infiniband.c @@ -59,7 +59,7 @@ nm_device_infiniband_init (NMDeviceInfiniband * self) { } -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *dev) { return NM_DEVICE_CAP_CARRIER_DETECT; diff --git a/src/devices/nm-device-vlan.c b/src/devices/nm-device-vlan.c index c69bcdedde..2f32d3165b 100644 --- a/src/devices/nm-device-vlan.c +++ b/src/devices/nm-device-vlan.c @@ -84,7 +84,7 @@ update_initial_hw_address (NMDevice *dev) _LOGD (LOGD_DEVICE | LOGD_VLAN, "read initial MAC address %s", priv->initial_hw_addr); } -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *dev) { /* We assume VLAN interfaces always support carrier detect */ diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index 2badb825a1..eb11d77621 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -191,7 +191,7 @@ typedef struct { int ip_ifindex; NMDeviceType type; char * type_desc; - guint32 capabilities; + NMDeviceCapabilities capabilities; char * driver; char * driver_version; char * firmware_version; @@ -476,7 +476,7 @@ nm_device_ipv6_sysctl_get_int32 (NMDevice *self, const char *property, gint32 fa static gboolean device_has_capability (NMDevice *self, NMDeviceCapabilities caps) { - return !!(NM_DEVICE_GET_PRIVATE (self)->capabilities & caps); + return NM_FLAGS_ANY (NM_DEVICE_GET_PRIVATE (self)->capabilities, caps); } /***********************************************************/ diff --git a/src/devices/nm-device.h b/src/devices/nm-device.h index e204af84a5..6664452a2d 100644 --- a/src/devices/nm-device.h +++ b/src/devices/nm-device.h @@ -142,7 +142,7 @@ typedef struct { gboolean (* get_ip_iface_identifier) (NMDevice *self, NMUtilsIPv6IfaceId *out_iid); - guint32 (* get_generic_capabilities) (NMDevice *self); + NMDeviceCapabilities (* get_generic_capabilities) (NMDevice *self); gboolean (* is_available) (NMDevice *self, NMDeviceCheckDevAvailableFlags flags); diff --git a/src/devices/team/nm-device-team.c b/src/devices/team/nm-device-team.c index 49202c3612..84d2241cc6 100644 --- a/src/devices/team/nm-device-team.c +++ b/src/devices/team/nm-device-team.c @@ -71,7 +71,7 @@ static gboolean teamd_start (NMDevice *device, NMSettingTeam *s_team); /******************************************************************/ -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *device) { return NM_DEVICE_CAP_CARRIER_DETECT; diff --git a/src/devices/wwan/nm-device-modem.c b/src/devices/wwan/nm-device-modem.c index f819d1d774..a429aa0396 100644 --- a/src/devices/wwan/nm-device-modem.c +++ b/src/devices/wwan/nm-device-modem.c @@ -376,7 +376,7 @@ device_state_changed (NMDevice *device, } } -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *device) { return NM_DEVICE_CAP_IS_NON_KERNEL; diff --git a/src/tests/config/nm-test-device.c b/src/tests/config/nm-test-device.c index 512085e997..b5f65ded6c 100644 --- a/src/tests/config/nm-test-device.c +++ b/src/tests/config/nm-test-device.c @@ -61,7 +61,7 @@ dispose (GObject *object) g_object_class->dispose (object); } -static guint32 +static NMDeviceCapabilities get_generic_capabilities (NMDevice *device) { return NM_DEVICE_CAP_IS_NON_KERNEL; -- cgit v1.2.1 From 80aaf076cf5009a581f76734291aa154954683a7 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 17 Apr 2015 15:19:48 +0200 Subject: device: expose nm_device_has_capability() function (cherry picked from commit 756b756c2c4a4546a3ad69ff4f42d954701363bf) --- src/devices/nm-device.c | 18 +++++++++--------- src/devices/nm-device.h | 2 ++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index eb11d77621..4d964c82b3 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -473,8 +473,8 @@ nm_device_ipv6_sysctl_get_int32 (NMDevice *self, const char *property, gint32 fa return nm_platform_sysctl_get_int32 (nm_utils_ip6_property_path (nm_device_get_ip_iface (self), property), fallback); } -static gboolean -device_has_capability (NMDevice *self, NMDeviceCapabilities caps) +gboolean +nm_device_has_capability (NMDevice *self, NMDeviceCapabilities caps) { return NM_FLAGS_ANY (NM_DEVICE_GET_PRIVATE (self)->capabilities, caps); } @@ -1380,8 +1380,8 @@ static void link_changed (NMDevice *self, NMPlatformLink *info) { /* Update carrier from link event if applicable. */ - if ( device_has_capability (self, NM_DEVICE_CAP_CARRIER_DETECT) - && !device_has_capability (self, NM_DEVICE_CAP_NONSTANDARD_CARRIER)) + if ( nm_device_has_capability (self, NM_DEVICE_CAP_CARRIER_DETECT) + && !nm_device_has_capability (self, NM_DEVICE_CAP_NONSTANDARD_CARRIER)) nm_device_set_carrier (self, info->connected); } @@ -6484,7 +6484,7 @@ nm_device_bring_up (NMDevice *self, gboolean block, gboolean *no_firmware) * complete (via a pending action) until either the carrier turns on, or * a timeout is reached. */ - if (device_has_capability (self, NM_DEVICE_CAP_CARRIER_DETECT)) { + if (nm_device_has_capability (self, NM_DEVICE_CAP_CARRIER_DETECT)) { if (priv->carrier_wait_id) g_source_remove (priv->carrier_wait_id); else @@ -6504,7 +6504,7 @@ check_carrier (NMDevice *self) { int ifindex = nm_device_get_ip_ifindex (self); - if (!device_has_capability (self, NM_DEVICE_CAP_NONSTANDARD_CARRIER)) + if (!nm_device_has_capability (self, NM_DEVICE_CAP_NONSTANDARD_CARRIER)) nm_device_set_carrier (self, nm_platform_link_is_connected (ifindex)); } @@ -6525,7 +6525,7 @@ bring_up (NMDevice *self, gboolean *no_firmware) *no_firmware = nm_platform_get_error () == NM_PLATFORM_ERROR_NO_FIRMWARE; /* Store carrier immediately. */ - if (result && device_has_capability (self, NM_DEVICE_CAP_CARRIER_DETECT)) + if (result && nm_device_has_capability (self, NM_DEVICE_CAP_CARRIER_DETECT)) check_carrier (self); return result; @@ -8311,7 +8311,7 @@ constructor (GType type, if (NM_DEVICE_GET_CLASS (self)->get_generic_capabilities) priv->capabilities |= NM_DEVICE_GET_CLASS (self)->get_generic_capabilities (self); - if (priv->ifindex <= 0 && !device_has_capability (self, NM_DEVICE_CAP_IS_NON_KERNEL)) + if (priv->ifindex <= 0 && !nm_device_has_capability (self, NM_DEVICE_CAP_IS_NON_KERNEL)) _LOGW (LOGD_HW, "failed to look up interface index"); device_get_driver_info (self, priv->iface, &priv->driver_version, &priv->firmware_version); @@ -8357,7 +8357,7 @@ constructed (GObject *object) NM_DEVICE_GET_CLASS (self)->update_initial_hw_address (self); /* Have to call update_initial_hw_address() before calling get_ignore_carrier() */ - if (device_has_capability (self, NM_DEVICE_CAP_CARRIER_DETECT)) { + if (nm_device_has_capability (self, NM_DEVICE_CAP_CARRIER_DETECT)) { priv->ignore_carrier = nm_config_get_ignore_carrier (nm_config_get (), self); check_carrier (self); diff --git a/src/devices/nm-device.h b/src/devices/nm-device.h index 6664452a2d..46de099804 100644 --- a/src/devices/nm-device.h +++ b/src/devices/nm-device.h @@ -371,6 +371,8 @@ void nm_device_set_initial_unmanaged_flag (NMDevice *device, gboolean nm_device_get_is_nm_owned (NMDevice *device); void nm_device_set_nm_owned (NMDevice *device); +gboolean nm_device_has_capability (NMDevice *self, NMDeviceCapabilities caps); + gboolean nm_device_get_autoconnect (NMDevice *device); void nm_device_handle_autoip4_event (NMDevice *self, -- cgit v1.2.1 From bd83000816f1b34443bda4b77f48664af357ad3b Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 17 Apr 2015 13:06:31 +0200 Subject: core/logging: downgrade some loggings to These logging statements are compile time dependent and add little informational value. (cherry picked from commit d8e1d9b469aeeca3291acab3088193e3f7ae43b9) --- src/main.c | 2 +- src/settings/plugins/ifcfg-rh/plugin.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main.c b/src/main.c index c315663bb7..70449ae99b 100644 --- a/src/main.c +++ b/src/main.c @@ -425,7 +425,7 @@ main (int argc, char *argv[]) dbus_glib_global_set_disable_legacy_property_access (); nm_log_info (LOGD_CORE, "Read config: %s", nm_config_data_get_config_description (nm_config_get_data (config))); - nm_log_info (LOGD_CORE, "WEXT support is %s", + nm_log_dbg (LOGD_CORE, "WEXT support is %s", #if HAVE_WEXT "enabled" #else diff --git a/src/settings/plugins/ifcfg-rh/plugin.c b/src/settings/plugins/ifcfg-rh/plugin.c index b7efa8643a..15e702ef8b 100644 --- a/src/settings/plugins/ifcfg-rh/plugin.c +++ b/src/settings/plugins/ifcfg-rh/plugin.c @@ -1139,7 +1139,7 @@ nm_system_config_factory (void) dbus_g_connection_register_g_object (priv->bus, DBUS_OBJECT_PATH, G_OBJECT (singleton)); - _LOGI ("Acquired D-Bus service %s", DBUS_SERVICE_NAME); + _LOGD ("Acquired D-Bus service %s", DBUS_SERVICE_NAME); } else g_object_ref (singleton); -- cgit v1.2.1 From 3d17c73576d878fa724554822fc4736cfcc28b4e Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 17 Apr 2015 13:36:41 +0200 Subject: core/logging: adjust log line about loading setting plugins We have different kinds of plugins (settings, dhcp, dns). Clearify, that we are about to load "settings" plugins. (cherry picked from commit e9b9d9b627acaf39a24514cf69bcf5a4329f8fcf) --- src/settings/nm-settings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings/nm-settings.c b/src/settings/nm-settings.c index 3a586b747e..2a6204e9f5 100644 --- a/src/settings/nm-settings.c +++ b/src/settings/nm-settings.c @@ -627,7 +627,7 @@ add_plugin (NMSettings *self, NMSystemConfigInterface *plugin) NM_SYSTEM_CONFIG_INTERFACE_INFO, &pinfo, NULL); - nm_log_info (LOGD_SETTINGS, "Loaded plugin %s: %s", pname, pinfo); + nm_log_info (LOGD_SETTINGS, "Loaded settings plugin %s: %s", pname, pinfo); g_free (pname); g_free (pinfo); } -- cgit v1.2.1 From 8da0a8104a56b795eba962420f7836c5bb3f7a19 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 17 Apr 2015 15:46:17 +0200 Subject: device/logging: log connection UUID when activating connection It is often hard to understand whether we activate an assumed connection. Only the UUID is unique. (cherry picked from commit 9983e4eff5b07ed217cf60785039dfeb9fbbfd19) --- src/devices/nm-device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index 4d964c82b3..d23a49178a 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -5763,8 +5763,9 @@ _device_activate (NMDevice *self, NMActRequest *req) connection = nm_act_request_get_connection (req); g_assert (connection); - _LOGI (LOGD_DEVICE, "Activation: starting connection '%s'", - nm_connection_get_id (connection)); + _LOGI (LOGD_DEVICE, "Activation: starting connection '%s' (%s)", + nm_connection_get_id (connection), + nm_connection_get_uuid (connection)); delete_on_deactivate_unschedule (self); -- cgit v1.2.1 From c593be5c495ada3e2fa1ea4927f1d56765420ee7 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 17 Apr 2015 13:47:10 +0200 Subject: core/logging: reduce info logging messages for devices https://bugzilla.redhat.com/show_bug.cgi?id=1212196 (cherry picked from commit b91b8a035ce4fa334513c68033df92485e73e71d) --- src/devices/nm-device.c | 8 ++++---- src/nm-manager.c | 8 ++++++-- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index d23a49178a..8d62a1fc23 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -493,7 +493,7 @@ nm_device_dbus_export (NMDevice *self) g_return_if_fail (priv->path == NULL); priv->path = g_strdup_printf ("/org/freedesktop/NetworkManager/Devices/%d", devcount++); - _LOGI (LOGD_DEVICE, "exported as %s", priv->path); + _LOGD (LOGD_DEVICE, "exported as %s", priv->path); nm_dbus_manager_register_object (nm_dbus_manager_get (), priv->path, self); } @@ -7394,9 +7394,9 @@ nm_device_cleanup (NMDevice *self, NMDeviceStateReason reason, gboolean deconfig g_return_if_fail (NM_IS_DEVICE (self)); if (reason == NM_DEVICE_STATE_REASON_NOW_MANAGED) - _LOGI (LOGD_DEVICE, "preparing device"); + _LOGD (LOGD_DEVICE, "preparing device"); else - _LOGI (LOGD_DEVICE, "deactivating device (reason '%s') [%d]", reason_to_string (reason), reason); + _LOGD (LOGD_DEVICE, "deactivating device (reason '%s') [%d]", reason_to_string (reason), reason); /* Save whether or not we tried IPv6 for later */ priv = NM_DEVICE_GET_PRIVATE (self); @@ -8362,7 +8362,7 @@ constructed (GObject *object) priv->ignore_carrier = nm_config_get_ignore_carrier (nm_config_get (), self); check_carrier (self); - _LOGI (LOGD_HW, + _LOGD (LOGD_HW, "carrier is %s%s", priv->carrier ? "ON" : "OFF", priv->ignore_carrier ? " (but ignored)" : ""); diff --git a/src/nm-manager.c b/src/nm-manager.c index 54b4429a5c..3356bef51c 100644 --- a/src/nm-manager.c +++ b/src/nm-manager.c @@ -1866,8 +1866,12 @@ add_device (NMManager *self, NMDevice *device, gboolean try_assume) driver = nm_device_get_driver (device); if (!driver) driver = "unknown"; - nm_log_info (LOGD_HW, "(%s): new %s device (driver: '%s' ifindex: %d)", - iface, type_desc, driver, nm_device_get_ifindex (device)); + nm_log_info (LOGD_HW, "(%s): new %s device (carrier: %s, driver: '%s', ifindex: %d)", + iface, type_desc, + nm_device_has_capability (device, NM_DEVICE_CAP_CARRIER_DETECT) + ? (nm_device_has_carrier (device) ? "ON" : "OFF") + : "UNKNOWN", + driver, nm_device_get_ifindex (device)); unmanaged_specs = nm_settings_get_unmanaged_specs (priv->settings); user_unmanaged = nm_device_spec_match_list (device, unmanaged_specs); -- cgit v1.2.1 From c531edc0020fdb06fffce039c8886574080078aa Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 17 Apr 2015 15:56:04 +0200 Subject: device/logging: downgrade log level of "Activation: Stage x of 5" messages Only downgrade the levels to . Leave warnings unchanged. https://bugzilla.redhat.com/show_bug.cgi?id=1212196 (cherry picked from commit 255f30c3627c43b38720001309bf36112b91d6f5) --- src/devices/nm-device.c | 66 ++++++++++++++++++++----------------------------- 1 file changed, 27 insertions(+), 39 deletions(-) diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index 8d62a1fc23..35198fb0d6 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -2439,7 +2439,7 @@ nm_device_activate_stage1_device_prepare (gpointer user_data) /* Notify the new ActiveConnection along with the state change */ g_object_notify (G_OBJECT (self), NM_DEVICE_ACTIVE_CONNECTION); - _LOGI (LOGD_DEVICE, "Activation: Stage 1 of 5 (Device Prepare) started..."); + _LOGD (LOGD_DEVICE, "Activation: Stage 1 of 5 (Device Prepare) started..."); nm_device_state_changed (self, NM_DEVICE_STATE_PREPARE, NM_DEVICE_STATE_REASON_NONE); /* Assumed connections were already set up outside NetworkManager */ @@ -2473,7 +2473,7 @@ nm_device_activate_stage1_device_prepare (gpointer user_data) nm_device_activate_schedule_stage2_device_config (self); out: - _LOGI (LOGD_DEVICE, "Activation: Stage 1 of 5 (Device Prepare) complete."); + _LOGD (LOGD_DEVICE, "Activation: Stage 1 of 5 (Device Prepare) complete."); return FALSE; } @@ -2496,7 +2496,7 @@ nm_device_activate_schedule_stage1_device_prepare (NMDevice *self) activation_source_schedule (self, nm_device_activate_stage1_device_prepare, 0); - _LOGI (LOGD_DEVICE, "Activation: Stage 1 of 5 (Device Prepare) scheduled..."); + _LOGD (LOGD_DEVICE, "Activation: Stage 1 of 5 (Device Prepare) scheduled..."); } static NMActStageReturn @@ -2527,7 +2527,7 @@ nm_device_activate_stage2_device_config (gpointer user_data) /* Clear the activation source ID now that this stage has run */ activation_source_clear (self, FALSE, 0); - _LOGI (LOGD_DEVICE, "Activation: Stage 2 of 5 (Device Configure) starting..."); + _LOGD (LOGD_DEVICE, "Activation: Stage 2 of 5 (Device Configure) starting..."); nm_device_state_changed (self, NM_DEVICE_STATE_CONFIG, NM_DEVICE_STATE_REASON_NONE); /* Assumed connections were already set up outside NetworkManager */ @@ -2562,12 +2562,12 @@ nm_device_activate_stage2_device_config (gpointer user_data) nm_device_queue_recheck_assume (info->slave); } - _LOGI (LOGD_DEVICE, "Activation: Stage 2 of 5 (Device Configure) successful."); + _LOGD (LOGD_DEVICE, "Activation: Stage 2 of 5 (Device Configure) successful."); nm_device_activate_schedule_stage3_ip_config_start (self); out: - _LOGI (LOGD_DEVICE, "Activation: Stage 2 of 5 (Device Configure) complete."); + _LOGD (LOGD_DEVICE, "Activation: Stage 2 of 5 (Device Configure) complete."); return FALSE; } @@ -2590,7 +2590,7 @@ nm_device_activate_schedule_stage2_device_config (NMDevice *self) activation_source_schedule (self, nm_device_activate_stage2_device_config, 0); - _LOGI (LOGD_DEVICE, "Activation: Stage 2 of 5 (Device Configure) scheduled..."); + _LOGD (LOGD_DEVICE, "Activation: Stage 2 of 5 (Device Configure) scheduled..."); } /*********************************************/ @@ -2832,7 +2832,7 @@ aipd_start (NMDevice *self, NMDeviceStateReason *reason) return NM_ACT_STAGE_RETURN_FAILURE; } - _LOGI (LOGD_DEVICE | LOGD_AUTOIP4, + _LOGD (LOGD_DEVICE | LOGD_AUTOIP4, "Activation: Stage 3 of 5 (IP Configure Start) started" " avahi-autoipd..."); @@ -4216,7 +4216,7 @@ rdisc_config_changed (NMRDisc *rdisc, NMRDiscConfigMap changed, NMDevice *self) if (priv->dhcp6_mode != NM_RDISC_DHCP_LEVEL_NONE) { NMDeviceStateReason reason; - _LOGI (LOGD_DEVICE | LOGD_DHCP6, + _LOGD (LOGD_DEVICE | LOGD_DHCP6, "Activation: Stage 3 of 5 (IP Configure Start) starting DHCPv6" " as requested by IPv6 router..."); if (!dhcp6_start (self, FALSE, &reason)) { @@ -4796,7 +4796,7 @@ nm_device_activate_stage3_ip_config_start (gpointer user_data) priv->ip4_state = priv->ip6_state = IP_WAIT; - _LOGI (LOGD_DEVICE, "Activation: Stage 3 of 5 (IP Configure Start) started..."); + _LOGD (LOGD_DEVICE, "Activation: Stage 3 of 5 (IP Configure Start) started..."); nm_device_state_changed (self, NM_DEVICE_STATE_IP_CONFIG, NM_DEVICE_STATE_REASON_NONE); /* Device should be up before we can do anything with it */ @@ -4834,7 +4834,7 @@ nm_device_activate_stage3_ip_config_start (gpointer user_data) nm_device_check_ip_failed (self, TRUE); out: - _LOGI (LOGD_DEVICE, "Activation: Stage 3 of 5 (IP Configure Start) complete."); + _LOGD (LOGD_DEVICE, "Activation: Stage 3 of 5 (IP Configure Start) complete."); return FALSE; } @@ -4858,7 +4858,7 @@ fw_change_zone_cb (GError *error, gpointer user_data) } activation_source_schedule (self, nm_device_activate_stage3_ip_config_start, 0); - _LOGI (LOGD_DEVICE, "Activation: Stage 3 of 5 (IP Configure Start) scheduled."); + _LOGD (LOGD_DEVICE, "Activation: Stage 3 of 5 (IP Configure Start) scheduled."); } /* @@ -4891,7 +4891,7 @@ nm_device_activate_schedule_stage3_ip_config_start (NMDevice *self) if (nm_device_uses_assumed_connection (self)) { _LOGD (LOGD_DEVICE, "Activation: skip setting firewall zone '%s' for assumed device", zone ? zone : "default"); activation_source_schedule (self, nm_device_activate_stage3_ip_config_start, 0); - _LOGI (LOGD_DEVICE, "Activation: Stage 3 of 5 (IP Configure Start) scheduled."); + _LOGD (LOGD_DEVICE, "Activation: Stage 3 of 5 (IP Configure Start) scheduled."); return; } @@ -4932,8 +4932,7 @@ nm_device_activate_ip4_config_timeout (gpointer user_data) /* Clear the activation source ID now that this stage has run */ activation_source_clear (self, FALSE, AF_INET); - _LOGI (LOGD_DEVICE | LOGD_IP4, - "Activation: Stage 4 of 5 (IPv4 Configure Timeout) started..."); + _LOGD (LOGD_DEVICE | LOGD_IP4, "Activation: Stage 4 of 5 (IPv4 Configure Timeout) started..."); ret = NM_DEVICE_GET_CLASS (self)->act_stage4_ip4_config_timeout (self, &reason); if (ret == NM_ACT_STAGE_RETURN_POSTPONE) @@ -4949,8 +4948,7 @@ nm_device_activate_ip4_config_timeout (gpointer user_data) nm_device_check_ip_failed (self, FALSE); out: - _LOGI (LOGD_DEVICE | LOGD_IP4, - "Activation: Stage 4 of 5 (IPv4 Configure Timeout) complete."); + _LOGD (LOGD_DEVICE | LOGD_IP4, "Activation: Stage 4 of 5 (IPv4 Configure Timeout) complete."); return FALSE; } @@ -4973,8 +4971,7 @@ nm_device_activate_schedule_ip4_config_timeout (NMDevice *self) activation_source_schedule (self, nm_device_activate_ip4_config_timeout, AF_INET); - _LOGI (LOGD_DEVICE | LOGD_IP4, - "Activation: Stage 4 of 5 (IPv4 Configure Timeout) scheduled..."); + _LOGD (LOGD_DEVICE | LOGD_IP4, "Activation: Stage 4 of 5 (IPv4 Configure Timeout) scheduled..."); } @@ -5007,8 +5004,7 @@ nm_device_activate_ip6_config_timeout (gpointer user_data) /* Clear the activation source ID now that this stage has run */ activation_source_clear (self, FALSE, AF_INET6); - _LOGI (LOGD_DEVICE | LOGD_IP6, - "Activation: Stage 4 of 5 (IPv6 Configure Timeout) started..."); + _LOGD (LOGD_DEVICE | LOGD_IP6, "Activation: Stage 4 of 5 (IPv6 Configure Timeout) started..."); ret = NM_DEVICE_GET_CLASS (self)->act_stage4_ip6_config_timeout (self, &reason); if (ret == NM_ACT_STAGE_RETURN_POSTPONE) @@ -5024,8 +5020,7 @@ nm_device_activate_ip6_config_timeout (gpointer user_data) nm_device_check_ip_failed (self, FALSE); out: - _LOGI (LOGD_DEVICE | LOGD_IP6, - "Activation: Stage 4 of 5 (IPv6 Configure Timeout) complete."); + _LOGD (LOGD_DEVICE | LOGD_IP6, "Activation: Stage 4 of 5 (IPv6 Configure Timeout) complete."); return FALSE; } @@ -5048,8 +5043,7 @@ nm_device_activate_schedule_ip6_config_timeout (NMDevice *self) activation_source_schedule (self, nm_device_activate_ip6_config_timeout, AF_INET6); - _LOGI (LOGD_DEVICE | LOGD_IP6, - "Activation: Stage 4 of 5 (IPv6 Configure Timeout) scheduled..."); + _LOGD (LOGD_DEVICE | LOGD_IP6, "Activation: Stage 4 of 5 (IPv6 Configure Timeout) scheduled..."); } static void @@ -5293,7 +5287,7 @@ nm_device_activate_ip4_config_commit (gpointer user_data) /* Clear the activation source ID now that this stage has run */ activation_source_clear (self, FALSE, AF_INET); - _LOGI (LOGD_DEVICE, "Activation: Stage 5 of 5 (IPv4 Commit) started..."); + _LOGD (LOGD_DEVICE, "Activation: Stage 5 of 5 (IPv4 Commit) started..."); req = nm_device_get_act_request (self); g_assert (req); @@ -5310,8 +5304,7 @@ nm_device_activate_ip4_config_commit (gpointer user_data) /* NULL to use the existing priv->dev_ip4_config */ if (!ip4_config_merge_and_apply (self, NULL, TRUE, &reason)) { - _LOGI (LOGD_DEVICE | LOGD_IP4, - "Activation: Stage 5 of 5 (IPv4 Commit) failed"); + _LOGD (LOGD_DEVICE | LOGD_IP4, "Activation: Stage 5 of 5 (IPv4 Commit) failed"); nm_device_state_changed (self, NM_DEVICE_STATE_FAILED, reason); goto out; } @@ -5353,7 +5346,7 @@ nm_device_activate_ip4_config_commit (gpointer user_data) nm_device_state_changed (self, NM_DEVICE_STATE_IP_CHECK, NM_DEVICE_STATE_REASON_NONE); out: - _LOGI (LOGD_DEVICE, "Activation: Stage 5 of 5 (IPv4 Commit) complete."); + _LOGD (LOGD_DEVICE, "Activation: Stage 5 of 5 (IPv4 Commit) complete."); return FALSE; } @@ -5372,8 +5365,7 @@ nm_device_activate_schedule_ip4_config_result (NMDevice *self, NMIP4Config *conf activation_source_schedule (self, nm_device_activate_ip4_config_commit, AF_INET); - _LOGI (LOGD_DEVICE | LOGD_IP4, - "Activation: Stage 5 of 5 (IPv4 Configure Commit) scheduled..."); + _LOGD (LOGD_DEVICE | LOGD_IP4, "Activation: Stage 5 of 5 (IPv4 Configure Commit) scheduled..."); } gboolean @@ -5395,7 +5387,6 @@ nm_device_activate_ip6_config_commit (gpointer user_data) { NMDevice *self = NM_DEVICE (user_data); NMDevicePrivate *priv = NM_DEVICE_GET_PRIVATE (self); - guint level = (priv->ip6_state == IP_DONE) ? LOGL_DEBUG : LOGL_INFO; NMActRequest *req; NMConnection *connection; NMDeviceStateReason reason = NM_DEVICE_STATE_REASON_NONE; @@ -5404,7 +5395,7 @@ nm_device_activate_ip6_config_commit (gpointer user_data) /* Clear the activation source ID now that this stage has run */ activation_source_clear (self, FALSE, AF_INET6); - _LOG (level, LOGD_DEVICE, "Activation: Stage 5 of 5 (IPv6 Commit) started..."); + _LOGD (LOGD_DEVICE, "Activation: Stage 5 of 5 (IPv6 Commit) started..."); req = nm_device_get_act_request (self); g_assert (req); @@ -5444,12 +5435,11 @@ nm_device_activate_ip6_config_commit (gpointer user_data) if (nm_device_get_state (self) == NM_DEVICE_STATE_IP_CONFIG) nm_device_state_changed (self, NM_DEVICE_STATE_IP_CHECK, NM_DEVICE_STATE_REASON_NONE); } else { - _LOGW (LOGD_DEVICE | LOGD_IP6, - "Activation: Stage 5 of 5 (IPv6 Commit) failed"); + _LOGW (LOGD_DEVICE | LOGD_IP6, "Activation: Stage 5 of 5 (IPv6 Commit) failed"); nm_device_state_changed (self, NM_DEVICE_STATE_FAILED, reason); } - _LOG (level, LOGD_DEVICE, "Activation: Stage 5 of 5 (IPv6 Commit) complete."); + _LOGD (LOGD_DEVICE, "Activation: Stage 5 of 5 (IPv6 Commit) complete."); return FALSE; } @@ -5458,7 +5448,6 @@ void nm_device_activate_schedule_ip6_config_result (NMDevice *self) { NMDevicePrivate *priv = NM_DEVICE_GET_PRIVATE (self); - guint level = (priv->ip6_state == IP_DONE) ? LOGL_DEBUG : LOGL_INFO; g_return_if_fail (NM_IS_DEVICE (self)); @@ -5470,8 +5459,7 @@ nm_device_activate_schedule_ip6_config_result (NMDevice *self) activation_source_schedule (self, nm_device_activate_ip6_config_commit, AF_INET6); - _LOG (level, LOGD_DEVICE | LOGD_IP6, - "Activation: Stage 5 of 5 (IPv6 Commit) scheduled..."); + _LOGD (LOGD_DEVICE | LOGD_IP6, "Activation: Stage 5 of 5 (IPv6 Commit) scheduled..."); } gboolean -- cgit v1.2.1