From 2899343bfd4dceac5d0be2a52ce91566eb145278 Mon Sep 17 00:00:00 2001 From: Valentin David Date: Tue, 8 Sep 2020 17:15:30 +0200 Subject: build/docs: fix generated XML syntax in tools/generate-docs-nm-settings-docs-gir.py Class description may contains double quotes which is not valid as XML attribute value. [thaller@redhat.com: adjust original patch to reformat code with python black] [thaller@redhat.com: adjusted patch during backport from nm-1-26 to nm-1-24] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/620 (cherry picked from commit 54e25f23f53af889703dfc50d51a8afeeea8a439) (cherry picked from commit 7d26773138dd4270c45e131761d4e6be58f64d12) --- libnm/generate-setting-docs.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libnm/generate-setting-docs.py b/libnm/generate-setting-docs.py index 6f8a03700d..ccc58f5bd7 100755 --- a/libnm/generate-setting-docs.py +++ b/libnm/generate-setting-docs.py @@ -218,7 +218,14 @@ for settingxml in settings: class_desc = get_docs(settingxml) if class_desc is None: raise Exception("%s needs a gtk-doc block with one-line description" % setting.props.name) - outfile.write(" \n" % (setting.props.name, class_desc, get_setting_name_define (settingxml))) + outfile.write( + ' \n' + % ( + setting.props.name, + xml_quoteattr(class_desc), + get_setting_name_define(settingxml), + ) + ) setting_properties = { prop.name: prop for prop in GObject.list_properties(setting) if prop.name != 'name' } if args.overrides is None: -- cgit v1.2.1