From 27835ba73c242e4d8232562c6b6eca4861b1097f Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Sat, 28 Nov 2015 22:53:12 +0100 Subject: Revert "systemd: fix potential memory leaks" @random_data is declared as _cleanup_free_. Freeing it is unnecessary and freeing without clearing the pointer leads do a double free. This reverts commit 3d1557eaad4d408218bee8996c3721eb2aa5e22c. --- src/systemd/src/libsystemd-network/sd-ipv4ll.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/systemd/src/libsystemd-network/sd-ipv4ll.c b/src/systemd/src/libsystemd-network/sd-ipv4ll.c index fbf0dc5646..a3eaf2b4f5 100644 --- a/src/systemd/src/libsystemd-network/sd-ipv4ll.c +++ b/src/systemd/src/libsystemd-network/sd-ipv4ll.c @@ -211,10 +211,8 @@ int sd_ipv4ll_set_address_seed(sd_ipv4ll *ll, unsigned seed) { return -ENOMEM; random_data_state = new0(char, 128); - if (!random_data_state) { - free(random_data); + if (!random_data_state) return -ENOMEM; - } r = initstate_r(seed, random_data_state, 128, random_data); if (r < 0) -- cgit v1.2.1