<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git/tools, branch lr/python3</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>tests: implement Update2() in NetworkManager stub</title>
<updated>2018-05-28T09:21:07+00:00</updated>
<author>
<name>Beniamino Galvani</name>
<email>bgalvani@redhat.com</email>
</author>
<published>2018-05-25T16:00:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=af946871614db6fdf2b46ae2c909aa63fdaf1337'/>
<id>af946871614db6fdf2b46ae2c909aa63fdaf1337</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>clients/tests: add SetProperties operation to test-networkmanager-service.py stub</title>
<updated>2018-05-24T14:40:17+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T14:20:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=d424de10bf6d2228d36dadf3568a74a3e505e647'/>
<id>d424de10bf6d2228d36dadf3568a74a3e505e647</id>
<content type='text'>
It is a hook to set one or several D-Bus properties at once. Properties that are
to be set-able, have to be whitelisted in the stub.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It is a hook to set one or several D-Bus properties at once. Properties that are
to be set-able, have to be whitelisted in the stub.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: don't return path name from obj.get_managed_ifaces() in test-networkmanager-service.py</title>
<updated>2018-05-24T14:40:17+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T19:04:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=c834a8e822a4201c3d18c4c28b2305b292c70f1e'/>
<id>c834a8e822a4201c3d18c4c28b2305b292c70f1e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: fix quitting mainloop in test-networkmanager-service.py</title>
<updated>2018-05-15T09:44:47+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T09:38:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=c905ee94f09e76db917a684a2fb44d83886475f5'/>
<id>c905ee94f09e76db917a684a2fb44d83886475f5</id>
<content type='text'>
Previously, the callbacks would return gl.mainloop.quit(), which is None
and thus the source got removed already. The later GLib.source_remove()
would thus use an invalid source-id.

Fix that, by no removing the source id from the callback.

Fixes: b1ff82eba5e80e4ef3f16e35372ba933c300be1d
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, the callbacks would return gl.mainloop.quit(), which is None
and thus the source got removed already. The later GLib.source_remove()
would thus use an invalid source-id.

Fix that, by no removing the source id from the callback.

Fixes: b1ff82eba5e80e4ef3f16e35372ba933c300be1d
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: explicitly export/unexport objects</title>
<updated>2018-05-15T08:32:02+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T08:16:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=2ef24490a3712ffca0faf86aecf56abcd43a1276'/>
<id>2ef24490a3712ffca0faf86aecf56abcd43a1276</id>
<content type='text'>
Instead of exporting exported-objects during construction, export
them right before we register them (for example, in case of device
instances, before we add the device to the manager's device list).

Likewise, when removing the object from the list, always explicitly
unexport them.

Without explicitly unexporting the objects, they can also not be
removed, because object-manage and D-Bus library keep references
to them.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of exporting exported-objects during construction, export
them right before we register them (for example, in case of device
instances, before we add the device to the manager's device list).

Likewise, when removing the object from the list, always explicitly
unexport them.

Without explicitly unexporting the objects, they can also not be
removed, because object-manage and D-Bus library keep references
to them.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/trivial: move code</title>
<updated>2018-05-15T08:06:38+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T08:06:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=39118a1f4229d66667867a85b976258aef0141ea'/>
<id>39118a1f4229d66667867a85b976258aef0141ea</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: rework handling of D-Bus properties in NetworkManager stub service</title>
<updated>2018-05-15T08:04:13+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T06:31:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=b1ff82eba5e80e4ef3f16e35372ba933c300be1d'/>
<id>b1ff82eba5e80e4ef3f16e35372ba933c300be1d</id>
<content type='text'>
Instead of registering a __get_props() function which constructs the
entire hash anew each time, register a props dictionary. This dictionary
is used as cache for the properies.

In most cases, we don't need to additionally cache the properties
outside the props dictionary. Also, add _dbus_property_set() which
sets the property and emits the notification.

Also, cleanup the property names by giving them a PRP_ prefix.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of registering a __get_props() function which constructs the
entire hash anew each time, register a props dictionary. This dictionary
is used as cache for the properies.

In most cases, we don't need to additionally cache the properties
outside the props dictionary. Also, add _dbus_property_set() which
sets the property and emits the notification.

Also, cleanup the property names by giving them a PRP_ prefix.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: better implement ActivateConnection in NetworkManager stub service</title>
<updated>2018-05-14T15:53:03+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-14T13:49:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=0d302caab8f01cb055d8a0081be0fb10c15fe076'/>
<id>0d302caab8f01cb055d8a0081be0fb10c15fe076</id>
<content type='text'>
Transition the states, so that `nmcli con up` can succeed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Transition the states, so that `nmcli con up` can succeed.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: various refactoring in tools/test-networkmanager-service.py</title>
<updated>2018-05-14T15:53:03+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-14T12:22:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=f563a6dfeb3bc0763e5acb14ca36d0b3a89e5d50'/>
<id>f563a6dfeb3bc0763e5acb14ca36d0b3a89e5d50</id>
<content type='text'>
- no more global variables, except those in the new variable "gl".

- don't pass that bus instance around. Use the singleton gl.bus.

- separate creation of ExportedObj from exporting on D-Bus.

- use enum values loaded from NM via GObject introspection.

- the visible change is that the generated D-Bus paths now start
  counting at one. That is also how NetworkManager behaves, and
  it looks nicer to have no zero ID for an object.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- no more global variables, except those in the new variable "gl".

- don't pass that bus instance around. Use the singleton gl.bus.

- separate creation of ExportedObj from exporting on D-Bus.

- use enum values loaded from NM via GObject introspection.

- the visible change is that the generated D-Bus paths now start
  counting at one. That is also how NetworkManager behaves, and
  it looks nicer to have no zero ID for an object.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: refactor finding device in NetworkManager stub</title>
<updated>2018-05-11T14:51:20+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-09T10:46:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=6d34d5e41bc5684f3787852fd280e23fd04b4001'/>
<id>6d34d5e41bc5684f3787852fd280e23fd04b4001</id>
<content type='text'>
- add find_devices() and find_device_first() functions,
  to not re-implement iterating the device list.

- for test functions, accept the device's "ident", instead
  of ifname. The "ident" must b unique, contrary to the "ifname".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- add find_devices() and find_device_first() functions,
  to not re-implement iterating the device list.

- for test functions, accept the device's "ident", instead
  of ifname. The "ident" must b unique, contrary to the "ifname".
</pre>
</div>
</content>
</entry>
</feed>
