<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git/tools, branch fix-eBPF</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>build: pass both filenames to "tools/check-compare-generated.sh" script</title>
<updated>2022-10-31T08:11:30+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2022-10-26T07:59:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=139f4b4b2ee153e728f111143a55d126e7fd0e65'/>
<id>139f4b4b2ee153e728f111143a55d126e7fd0e65</id>
<content type='text'>
It just feels nicer to be explicit about the filenames and
not rely on a specific naming.

Also, in meson we can directly pass the target as argument, which
expands to the filename but also adds a dependency.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It just feels nicer to be explicit about the filenames and
not rely on a specific naming.

Also, in meson we can directly pass the target as argument, which
expands to the filename but also adds a dependency.
</pre>
</div>
</content>
</entry>
<entry>
<title>tools: drop unused variables from "tools/generate-docs-nm-property-infos.py"</title>
<updated>2022-10-25T10:12:44+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2022-10-25T10:12:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=ea5cd47bc45ad0a0a9d6dc53ecaab7c1239a2372'/>
<id>ea5cd47bc45ad0a0a9d6dc53ecaab7c1239a2372</id>
<content type='text'>
Found by lgtm.com.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Found by lgtm.com.
</pre>
</div>
</content>
</entry>
<entry>
<title>tools: avoid Python 3 f-string in "generate-docs-nm-property-infos.py"</title>
<updated>2022-10-07T19:08:39+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2022-10-07T19:08:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=70fee1cf4613b1f7abc07322070f814d4d8020d5'/>
<id>70fee1cf4613b1f7abc07322070f814d4d8020d5</id>
<content type='text'>
We also need to build with python2. No f-strings.

Fixes: 8fc7b6df12ed ('tools: rework generating documentation from libnm meta data')
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We also need to build with python2. No f-strings.

Fixes: 8fc7b6df12ed ('tools: rework generating documentation from libnm meta data')
</pre>
</div>
</content>
</entry>
<entry>
<title>tools: sort the settings in "generate-docs-nm-property-infos.py" by name</title>
<updated>2022-10-06T11:40:30+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2022-10-04T08:15:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=77e0041b274826d17ed94a1680a045aec756819d'/>
<id>77e0041b274826d17ed94a1680a045aec756819d</id>
<content type='text'>
"nm-setting-ip-config.c" is a base class for IPv4 and IPv6 settings. So
far, any tags there were ignored, which was not obvious. It can be
useful to document common properties there. Well, maybe every property
better has a IPv4/IPv6 specific text, but that should not be a technical
limitation of the tool. So also honor the base file for "ipv4" and
"ipv6" settings.

When doing that, the settings are no longer processed in the order as
they are provided on the command line. Because, one file would be parsed
twice, it wouldn't make much sense. Instead, sort the my setting name.
The advantage is that the generated XML is independent from the order
that make/meson passes to the tool.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
"nm-setting-ip-config.c" is a base class for IPv4 and IPv6 settings. So
far, any tags there were ignored, which was not obvious. It can be
useful to document common properties there. Well, maybe every property
better has a IPv4/IPv6 specific text, but that should not be a technical
limitation of the tool. So also honor the base file for "ipv4" and
"ipv6" settings.

When doing that, the settings are no longer processed in the order as
they are provided on the command line. Because, one file would be parsed
twice, it wouldn't make much sense. Instead, sort the my setting name.
The advantage is that the generated XML is independent from the order
that make/meson passes to the tool.
</pre>
</div>
</content>
</entry>
<entry>
<title>tools: don't set empty attributes in "generate-docs-nm-property-infos.py"</title>
<updated>2022-10-06T11:40:30+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2022-10-04T08:16:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=c1bebdfaa6994a053a0905c9348009ae5bc3de8c'/>
<id>c1bebdfaa6994a053a0905c9348009ae5bc3de8c</id>
<content type='text'>
If the information is missing, the entire attribute should not be there.
Don't set it to the empty word.

Also, don't alias the "variable" attribute to the "name". It's not clear
what the "variable" fields is supposed to mean, but if it's not
explicitly set, don't make up the information. If a user of that
information cares, the can always fallback to the "name".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If the information is missing, the entire attribute should not be there.
Don't set it to the empty word.

Also, don't alias the "variable" attribute to the "name". It's not clear
what the "variable" fields is supposed to mean, but if it's not
explicitly set, don't make up the information. If a user of that
information cares, the can always fallback to the "name".
</pre>
</div>
</content>
</entry>
<entry>
<title>tools: don't write empty XML nodes in "generate-docs-nm-property-infos.py"</title>
<updated>2022-10-06T11:40:29+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2022-10-04T08:16:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e56f7f5c2ddfe3374c03355c36d334e6c93b3d28'/>
<id>e56f7f5c2ddfe3374c03355c36d334e6c93b3d28</id>
<content type='text'>
This generates '&lt;setting name="XXX"&gt;\n&lt;/setting&gt;' nodes in case there is
no additional data. Don't do that. Just '&lt;setting name="XXX"/&gt;'
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This generates '&lt;setting name="XXX"&gt;\n&lt;/setting&gt;' nodes in case there is
no additional data. Don't do that. Just '&lt;setting name="XXX"/&gt;'
</pre>
</div>
</content>
</entry>
<entry>
<title>tools: preserve newlines and indentation in "generate-docs-nm-property-infos.py"</title>
<updated>2022-10-06T11:40:29+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2022-10-04T10:12:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=8899ecc0d84744da19b5e1a686b89443d89ea42f'/>
<id>8899ecc0d84744da19b5e1a686b89443d89ea42f</id>
<content type='text'>
Our docs can be long. It's important to be able to express paragraphs.
Honor a blank line to include a newline. For XML often whitespace is
ignored, but our tools can choose to honor the newline.

Also, don't strip the whitespace from the beginning and the end.
We keep whitespace for a certain indentation level, but additional
whitespace gets preserved. This is less important, because regular
spaces is indeed irrelevant. But when we write the annotations, we
should be in full control over spaces.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Our docs can be long. It's important to be able to express paragraphs.
Honor a blank line to include a newline. For XML often whitespace is
ignored, but our tools can choose to honor the newline.

Also, don't strip the whitespace from the beginning and the end.
We keep whitespace for a certain indentation level, but additional
whitespace gets preserved. This is less important, because regular
spaces is indeed irrelevant. But when we write the annotations, we
should be in full control over spaces.
</pre>
</div>
</content>
</entry>
<entry>
<title>tools: rework generating documentation from libnm meta data</title>
<updated>2022-10-06T11:40:29+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2022-08-29T08:37:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=8fc7b6df12edfdf9a4e74d2bc77853f2806618e8'/>
<id>8fc7b6df12edfdf9a4e74d2bc77853f2806618e8</id>
<content type='text'>
With the given input, this produces *exactly* the same XML as before.

- the parsing is now stricter (and thus the code more verbose). No
  funny stuff, get the annotations correct.
- on parsing errors, we log now the affecting lines
- "nm-setting-ip-config.c" is a base class. Previously it was ignored
  and for the moment we still do that. Next, we will allow to also
  describe properties there.
- prepare the code to better preserve whitespace, indentation and line
  wrappings. In particular, to honor a blank line to indicate a line break
  and support paragraphs. This is not yet done to compare the output
  to before, but will be turned on with a small patch next.
- the code will make it simple to promote the XML attributes to
  nodes. Attributes aren't great, let's write XML nodes later.
  We will only need to adjust the "keywords" dictionary for that,
  but this change will require changes to the entire chain of tools.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
With the given input, this produces *exactly* the same XML as before.

- the parsing is now stricter (and thus the code more verbose). No
  funny stuff, get the annotations correct.
- on parsing errors, we log now the affecting lines
- "nm-setting-ip-config.c" is a base class. Previously it was ignored
  and for the moment we still do that. Next, we will allow to also
  describe properties there.
- prepare the code to better preserve whitespace, indentation and line
  wrappings. In particular, to honor a blank line to indicate a line break
  and support paragraphs. This is not yet done to compare the output
  to before, but will be turned on with a small patch next.
- the code will make it simple to promote the XML attributes to
  nodes. Attributes aren't great, let's write XML nodes later.
  We will only need to adjust the "keywords" dictionary for that,
  but this change will require changes to the entire chain of tools.
</pre>
</div>
</content>
</entry>
<entry>
<title>style: fix python black formatting of "generate-docs-nm-settings-docs-merge.py"</title>
<updated>2022-09-08T07:00:27+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2022-09-08T06:55:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=af2bc358dfd5b2cd6ab270baebfaa810ad869bf5'/>
<id>af2bc358dfd5b2cd6ab270baebfaa810ad869bf5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>generate-docs-nm-settings-docs-gir: remove space from the beginning of a para</title>
<updated>2022-09-07T10:10:21+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2022-09-07T10:08:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=8af1404e54fea5bb038afd6d3e662540f9bda19f'/>
<id>8af1404e54fea5bb038afd6d3e662540f9bda19f</id>
<content type='text'>
From nm-settings-dbus(5):

Before (ugly, offensive, possibly in violation of geneva protocol):

  ...
  | set, the authentication retries for 3
  | times before failing the connection.
  |
  |  Currently, this only applies to 802-1x
  | authentication.

After (beautiful, smells good, in harmony with nature):

  ...
  | set, the authentication retries for 3
  | times before failing the connection.
  |
  | Currently, this only applies to 802-1x
  | authentication.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
From nm-settings-dbus(5):

Before (ugly, offensive, possibly in violation of geneva protocol):

  ...
  | set, the authentication retries for 3
  | times before failing the connection.
  |
  |  Currently, this only applies to 802-1x
  | authentication.

After (beautiful, smells good, in harmony with nature):

  ...
  | set, the authentication retries for 3
  | times before failing the connection.
  |
  | Currently, this only applies to 802-1x
  | authentication.
</pre>
</div>
</content>
</entry>
</feed>
