delta/NetworkManager.git/src, branch th/strsplit

ifcfg-rh: various cleanups using the cleanup attribute

2019-04-09T18:43:34+00:00

all: replace g_strsplit_set() by nm_utils_strsplit_set*()

2019-04-09T18:43:34+00:00

ibft: cleanup read_connections()

2019-04-09T18:43:34+00:00

dcb: cleanup do_helper() in "nm-dcb.c"

2019-04-09T18:43:34+00:00

dhcp: cleanup nm_dhcp_dhclient_create_config()

2019-04-09T18:43:34+00:00

dhcp: cleanup nm_dhcp_dhclient_read_duid()

2019-04-09T18:43:34+00:00

dhcp: cleanup grab_request_options()

2019-04-09T18:43:34+00:00

dhcp: cleanup nm_dhcp_dhclient_save_duid()

2019-04-09T18:43:34+00:00

dhcp: cleanup ip4_process_dhclient_rfc3442_routes()

2019-04-09T18:43:34+00:00

- use nm_utils_strsplit_set_full() instead of g_strsplit_set() to avoid allocating
  a full strv array.
- refactor the code to return early and use cleanup attribute for freeing
  memory.
- return TRUE/FALSE from process_dhclient_rfc3442_route(). It's simpler to
  understand than returning the moved pointer and a success output variable.

all: don't accept %NULL as delimiters for nm_utils_strsplit_set()

2019-04-09T18:43:34+00:00

The caller should make a conscious decision which delimiters to use.
Unfortunately, there is a variety of different demiters in use. This
should be unitfied and the callers should use one of a few specific
set of delimiters.

This could be unified by (re)using a define as delimiters, like

   strv = nm_utils_strsplit_set_full (value, MULTILIST_WITH_ESCAPE_CHARS, NM_UTILS_STRSPLIT_SET_FLAGS_ALLOW_ESCAPING);

where MULTILIST_WITH_ESCAPE_CHARS has a particular meaning that should
be reused for similar uses.

However, leaving the delimiter at NULL is not good because it's unclear who
wants that default behavior (and what the default should be). Don't allow that.

There are almost no callers that relied on this default anyway.