delta/NetworkManager.git/src, branch th/printf

core: escape percent characters for printf format string

2014-08-25T10:29:45+00:00

Signed-off-by: Thomas Haller

libnm-core: fix NMSettingConnection:verify() not to modify interface-name

2014-08-22T13:24:31+00:00

verify() used to modify interface-name of the base settings. This is
discouraged, because verify() should not touch the connection.

For libnm-core we can change behavior and only modify the connection
in normalize().

Also, be more strict not to verify() sucessfully on invalid
interface-name.

Signed-off-by: Thomas Haller

keyfile/tests: test reading minimal keyfiles that needs normalization of type and slave-type

2014-08-22T13:24:31+00:00

Signed-off-by: Thomas Haller

tests: refactor tests to use g_test framework (g_test_add_func)

2014-08-22T13:24:31+00:00

Signed-off-by: Thomas Haller

keyfile/tests: add keyfile_read_connection_from_file() utility function

2014-08-22T13:24:31+00:00

Signed-off-by: Thomas Haller

keyfile: don't add [connection].type base setting which is done by nm_connection_normalize()

2014-08-22T13:24:31+00:00

This undoes commit 9f8b7ff51dfd7cdb828fe5e7b50016c5587e8657
but the same functionality is now provided via normalize().

Signed-off-by: Thomas Haller

keyfile: remove ensure_slave_setting() when reading connection

2014-08-22T13:24:31+00:00

nm_connection_normalize() can now add the slave setting as needed. Remove
the duplicate functionality.

This undoes commit 664d64e0c04bd4b83137a682ff9a9881966f6f94
but the same functionality is now provided via normalize().

Signed-off-by: Thomas Haller

libnm-core: normalize slave-type and slave-settings of connections

2014-08-22T13:24:31+00:00

Some NMSettingConnection:slave-type types require a matching slave #NMSetting.
Add normalization of either the 'slave-type' property or the slave-setting.

Also be more strict in NMSettingConnection:verify() to enforce an
existing slave-setting depending on the slave-type.

Signed-off-by: Thomas Haller

ifcfg-rh: remove verify() connection during reading

2014-08-22T13:24:30+00:00

At the end of reading the connection, reader calls nm_connection_normalize()
to normalize the connection. Normalization inplicitly verifies the
connection.

Doing a verify along the way is not needed and even harmful. Soon further
checks will be added that make verify() fail, but normalize()
can fix the connection. So, while reading, we might actually have
an invalid connection, that will be normalized as last step.

Signed-off-by: Thomas Haller

keyfile: let reader normalize() the connection, not only verify()

2014-08-22T13:24:30+00:00

The new nm_connection_normalize() function allows to fixup an incomplete connection.
The keyfile reader should call normalize on a connection, so that we can implement
common normalizations there instead of inside the settings plugin.

Signed-off-by: Thomas Haller