delta/NetworkManager.git/src, branch lr/asserts

clients: bulk removal of g_assert*() statements

2022-03-28T11:51:44+00:00

Assertions should be done in tests. If we detect an unexpected situation
at runtime, we shall fail more gracefully than crashing right away.

platform: add log detail for ENODEV at do_delete_object()

2022-03-28T08:52:01+00:00

Deactivation of a NIC invokes deletion of qdisc. An ENODEV error can
be generated on deactivation of a virtual NIC when the kernel driver
has already deleted the device along with the qdisc.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1165

libnm/tests: test that nm_vpn_service_plugin_read_vpn_details() does not consume "QUIT" command

2022-03-28T08:40:00+00:00

libnm: handle NUL characters in nm_vpn_service_plugin_read_vpn_details() and fix test

2022-03-28T08:36:05+00:00

We expect to read NUL terminated strings. Upon NUL, we should do
something. Treat it as a line break.

Fixes: 8ae9cf4698b4 ('Revert "libnm: buffer reads in nm_vpn_service_plugin_read_vpn_details()"')

Revert "libnm: buffer reads in nm_vpn_service_plugin_read_vpn_details()"

2022-03-28T07:39:13+00:00

This partially reverts commit 4a9fcb0fc32e, which replaced one-byte
reads with buffered ones in the VPN service plugin.

Unfortunately the buffering means that commands coming after the magic
"DONE" string were being pulled into the buffer. Secrets agents expect
a "QUIT" to come after the "DONE", and since with buffering "QUIT" was
in the buffer, this led to a twenty-second delay on every VPN
connection using a secrets manager.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1164

Fixes: 4a9fcb0fc32e ('libnm: buffer reads in nm_vpn_service_plugin_read_vpn_details()')

core: create GMainLoop after daemonizing

2022-03-22T12:43:41+00:00

The GMainLoop instance (and the default GMainContext singleton) is not
required for trivial operations like --print-config, --version or
--help). If running as SysV daemon, the event file descriptor is
unnecessarily dup'ed from the parent to the child process.

Signed-off-by: Christian Eggers 

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1160

dnsmasq/shared: drop "--dhcp-lease-max=50" option

2022-03-21T16:14:17+00:00

It's not clear why this option is set or why it's necessary. It was
set ever since.

Note that we automatically determines the DHCP range
nm_dnsmasq_utils_get_range(), and with /24 subnets (or larger)
the range spans up to 244 addresses.

With such a DHCP range it doesn't seem to make sense to limit the
number of leases to 50. It also doesn't seem to make sense to limit it
at all. Drop this.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/941

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1156

libnm/docs: fix documentation for "proxy.pac-script"

2022-03-21T14:21:37+00:00

dhcp: simplify nm_dhcp_client_set_effective_client_id()

2022-03-21T12:09:28+00:00

The "take" parameter of _set_effective_client_id() was always "FALSE". Drop it.
Also, drop _set_effective_client_id() and just call nm_dhcp_client_set_effective_client_id()
directly.

dhcp: use nm_g_bytes_equal0() in _set_effective_client_id()

2022-03-21T12:04:52+00:00