<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git/src/tests, branch master</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>tests/client: rework error handling in "test-client.sh" script</title>
<updated>2021-03-19T10:43:19+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-19T10:37:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=571fdaafacb685da1e4201612c14f4cf6a761293'/>
<id>571fdaafacb685da1e4201612c14f4cf6a761293</id>
<content type='text'>
The script runs with "set -e", as such `cmd &amp;&amp; r=ok` seems wrong.
It worked apparently, but I don't understand why. Anyway, change
it.

Fixes: e64370341850 ('tests/client: run "test-client.py" also for meson')
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The script runs with "set -e", as such `cmd &amp;&amp; r=ok` seems wrong.
It worked apparently, but I don't understand why. Anyway, change
it.

Fixes: e64370341850 ('tests/client: run "test-client.py" also for meson')
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "tests/client: increase timeout to wait for process"</title>
<updated>2021-03-19T10:35:18+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-19T10:33:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=c2265dd8a9722f05d1407214f2636b5626841c7b'/>
<id>c2265dd8a9722f05d1407214f2636b5626841c7b</id>
<content type='text'>
This didn't help and was not necessary. Instead, there was an issue
that is fixed now.

This reverts commit b4c25f9131fd3eea47b9ca812d6049995fae017a.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This didn't help and was not necessary. Instead, there was an issue
that is fixed now.

This reverts commit b4c25f9131fd3eea47b9ca812d6049995fae017a.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/client: ensure that we run nmcli before client tests for LTO (again)</title>
<updated>2021-03-19T10:35:18+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-18T18:44:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=489c5f8cd8c8880f18cd54aa0e23db2cf3b1ffee'/>
<id>489c5f8cd8c8880f18cd54aa0e23db2cf3b1ffee</id>
<content type='text'>
See also commit 00e3fc036add ('clients/tests: ensure that we run nmcli
before client tests for LTO').

With the latest rework that code was dropped and tests (with LTO) are
broken as they hit a timeout (aside taking much longer).

Fixes: e64370341850 ('tests/client: run "test-client.py" also for meson')
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
See also commit 00e3fc036add ('clients/tests: ensure that we run nmcli
before client tests for LTO').

With the latest rework that code was dropped and tests (with LTO) are
broken as they hit a timeout (aside taking much longer).

Fixes: e64370341850 ('tests/client: run "test-client.py" also for meson')
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/client: increase timeout to wait for process</title>
<updated>2021-03-17T09:57:52+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-17T09:56:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=b4c25f9131fd3eea47b9ca812d6049995fae017a'/>
<id>b4c25f9131fd3eea47b9ca812d6049995fae017a</id>
<content type='text'>
We now get unit test failures hitting this timeout. That is
likely a new bug introduced somewhere, but to rule out that
the timeout is simply too short, increase it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We now get unit test failures hitting this timeout. That is
likely a new bug introduced somewhere, but to rule out that
the timeout is simply too short, increase it.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests/client: run "test-client.py" also for meson</title>
<updated>2021-03-15T16:10:56+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-15T09:59:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e643703418502ccd3b530b41748edf21ea56bb0c'/>
<id>e643703418502ccd3b530b41748edf21ea56bb0c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>client/tests: move "clients/tests/test-client.py" to "src/tests/client/"</title>
<updated>2021-03-15T16:10:55+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-15T09:48:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=019bc3233a0608c0bcf72c8e1b0e64063a4be25b'/>
<id>019bc3233a0608c0bcf72c8e1b0e64063a4be25b</id>
<content type='text'>
Note that "test-client.py" currently only tests nmcli. But what it does
is to spawn test-networkmanager-service.py and run nmcli against it.

As such, it could really be used to test any NetworkManager client
against the stub service. Hence this test is not under
"src/nmcli/tests", but under "src/tests/client/" where it is more
general.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Note that "test-client.py" currently only tests nmcli. But what it does
is to spawn test-networkmanager-service.py and run nmcli against it.

As such, it could really be used to test any NetworkManager client
against the stub service. Hence this test is not under
"src/nmcli/tests", but under "src/tests/client/" where it is more
general.
</pre>
</div>
</content>
</entry>
<entry>
<title>all: move "src/" directory to "src/core/"</title>
<updated>2021-02-04T08:45:55+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-02-03T14:25:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=ac1a9e03e4d6674e1e60529b47b325a8f62e67b3'/>
<id>ac1a9e03e4d6674e1e60529b47b325a8f62e67b3</id>
<content type='text'>
Currently "src/" mostly contains the source code of the daemon.
I say mostly, because that is not true, there are also the device,
settings, wwan, ppp plugins, the initrd generator, the pppd and dhcp
helper, and probably more.

Also we have source code under libnm-core/, libnm/, clients/, and
shared/ directories. That is all confusing.

We should have one "src" directory, that contains subdirectories. Those
subdirectories should contain individual parts (libraries or
applications), that possibly have dependencies on other subdirectories.
There should be a flat hierarchy of directories under src/, which
contains individual modules.

As the name "src/" is already taken, that prevents any sensible
restructuring of the code.

As a first step, move "src/" to "src/core/". This gives space to
reorganize the code better by moving individual components into "src/".

For inspiration, look at systemd's "src/" directory.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/743
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently "src/" mostly contains the source code of the daemon.
I say mostly, because that is not true, there are also the device,
settings, wwan, ppp plugins, the initrd generator, the pppd and dhcp
helper, and probably more.

Also we have source code under libnm-core/, libnm/, clients/, and
shared/ directories. That is all confusing.

We should have one "src" directory, that contains subdirectories. Those
subdirectories should contain individual parts (libraries or
applications), that possibly have dependencies on other subdirectories.
There should be a flat hierarchy of directories under src/, which
contains individual modules.

As the name "src/" is already taken, that prevents any sensible
restructuring of the code.

As a first step, move "src/" to "src/core/". This gives space to
reorganize the code better by moving individual components into "src/".

For inspiration, look at systemd's "src/" directory.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/743
</pre>
</div>
</content>
</entry>
<entry>
<title>build/meson: cleanup "src/meson.build"</title>
<updated>2021-01-27T20:47:53+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-01-27T20:15:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=a482461cb416990d60f7d13b76d17b9f1a63cb1c'/>
<id>a482461cb416990d60f7d13b76d17b9f1a63cb1c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>core/logging: move "nm-logging.c" to shared/nm-log-core/libnm-log-core library</title>
<updated>2021-01-15T10:32:31+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2020-12-30T16:32:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=24c634bf573880786e709c7ddfab01ebaec7eaa7'/>
<id>24c634bf573880786e709c7ddfab01ebaec7eaa7</id>
<content type='text'>
We want to move platform code to "shared/nm-platform". However, platform
code uses the logging infrastructure from the daemon, there is thus
an odd circular dependency.

Solve that by moving the "src/nm-logging.[hc]" to a new helper library
in "shared/nm-log-core".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We want to move platform code to "shared/nm-platform". However, platform
code uses the logging infrastructure from the daemon, there is thus
an odd circular dependency.

Solve that by moving the "src/nm-logging.[hc]" to a new helper library
in "shared/nm-log-core".
</pre>
</div>
</content>
</entry>
<entry>
<title>core: move NM_MANAGER_ERROR to shared/nm-glib-aux</title>
<updated>2021-01-15T10:32:30+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2020-12-30T14:54:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=c6e132749506e77bf5afdfd9174b497b20e7595a'/>
<id>c6e132749506e77bf5afdfd9174b497b20e7595a</id>
<content type='text'>
"src/nm-logging.c" should be independent of libnm-core. It almost
is, except the error domain and code.

Move NM_MANAGER_ERROR to "nm-glib-aux/nm-shared-utils.h" so that
"nm-logging.c" is independent of libnm-core.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
"src/nm-logging.c" should be independent of libnm-core. It almost
is, except the error domain and code.

Move NM_MANAGER_ERROR to "nm-glib-aux/nm-shared-utils.h" so that
"nm-logging.c" is independent of libnm-core.
</pre>
</div>
</content>
</entry>
</feed>
