<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git/src/tests/test-systemd.c, branch th/cli-strsplit</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>systemd: merge branch systemd into master</title>
<updated>2017-09-21T13:33:32+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2017-09-21T13:33:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=61f0f198bf97dca9d652eda10c81a279db5f20c9'/>
<id>61f0f198bf97dca9d652eda10c81a279db5f20c9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>logging: log device and connection along with the message</title>
<updated>2017-03-24T11:42:09+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2017-03-01T10:20:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=ed552c732c76c6f0f222a71400d601a0c967be83'/>
<id>ed552c732c76c6f0f222a71400d601a0c967be83</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>build: don't add systemd path the include search path</title>
<updated>2016-09-27T12:13:21+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-09-27T11:35:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e3a072f3c0d8046a9c1d01c8518c532b71f7bd7a'/>
<id>e3a072f3c0d8046a9c1d01c8518c532b71f7bd7a</id>
<content type='text'>
Our internal copy of systemd should not be in the search path.
Instead, let users only
  #include "systemd/nm-sd.h"
which then includes everything from systemd that we need.

We want to avoid to accidentally include anything from our
systemd-copy. Any user of that should only include "nm-sd.h",
which then includes everything that is needed further.

For example, "src/devices/wwan/nm-modem-manager.c" has
  #include &lt;systemd/nm-daemon.h&gt;
which in turn includes
  #include "_sd-common.h"
This works all correctly before, because #include "" will first
look in the directory where sd-daemon.h is. However, our mixing of
external systemd library and internal copy is rather dangerous.
Try to avoid it further by keeping the include paths clean.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Our internal copy of systemd should not be in the search path.
Instead, let users only
  #include "systemd/nm-sd.h"
which then includes everything from systemd that we need.

We want to avoid to accidentally include anything from our
systemd-copy. Any user of that should only include "nm-sd.h",
which then includes everything that is needed further.

For example, "src/devices/wwan/nm-modem-manager.c" has
  #include &lt;systemd/nm-daemon.h&gt;
which in turn includes
  #include "_sd-common.h"
This works all correctly before, because #include "" will first
look in the directory where sd-daemon.h is. However, our mixing of
external systemd library and internal copy is rather dangerous.
Try to avoid it further by keeping the include paths clean.
</pre>
</div>
</content>
</entry>
<entry>
<title>systemd: merge branch systemd into master</title>
<updated>2016-08-12T07:20:16+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-08-11T10:42:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=2f296cb8fe22ba5b493a6c7a00437e5af8c1a978'/>
<id>2f296cb8fe22ba5b493a6c7a00437e5af8c1a978</id>
<content type='text'>
Conflicts:
    src/systemd/src/basic/fd-util.c
    src/systemd/src/basic/fileio.c
    src/systemd/src/libsystemd/sd-event/sd-event.c
    src/systemd/src/libsystemd/sd-id128/sd-id128.c
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Conflicts:
    src/systemd/src/basic/fd-util.c
    src/systemd/src/basic/fileio.c
    src/systemd/src/libsystemd/sd-event/sd-event.c
    src/systemd/src/libsystemd/sd-id128/sd-id128.c
</pre>
</div>
</content>
</entry>
<entry>
<title>systemd/tests: don't link test-systemd against libNetworkManagerBase</title>
<updated>2016-08-12T06:14:53+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-08-12T06:05:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=9c8b7b001ea5a6639babe59d96701fd5e0509c2b'/>
<id>9c8b7b001ea5a6639babe59d96701fd5e0509c2b</id>
<content type='text'>
One point of test-systemd is to see whether our internal systemd code can
fully link without external systemd library. In fact, we want all symbols
from the internal systemd code to resolve, because when we link against
an external libsystemd library, we may mix differing APIs, resulting in
subtle bugs.

Currently, it may well be that libNetworkManagerBase.la already links
against libsystemd, which would result in test-systemd to wrongly
succeed resolving all names.

Fix that, by don't link libNetworkManagerBase.la into test-systemd.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
One point of test-systemd is to see whether our internal systemd code can
fully link without external systemd library. In fact, we want all symbols
from the internal systemd code to resolve, because when we link against
an external libsystemd library, we may mix differing APIs, resulting in
subtle bugs.

Currently, it may well be that libNetworkManagerBase.la already links
against libsystemd, which would result in test-systemd to wrongly
succeed resolving all names.

Fix that, by don't link libNetworkManagerBase.la into test-systemd.
</pre>
</div>
</content>
</entry>
<entry>
<title>systemd: merge branch systemd into master</title>
<updated>2016-06-30T08:55:03+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-06-30T07:29:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=5ce62dccc5d8edc77a71a00c6ec9436f23f42e0b'/>
<id>5ce62dccc5d8edc77a71a00c6ec9436f23f42e0b</id>
<content type='text'>
Conflicts:
    src/systemd/src/basic/siphash24.c
    src/systemd/src/basic/time-util.c
    src/systemd/src/basic/util.c
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Conflicts:
    src/systemd/src/basic/siphash24.c
    src/systemd/src/basic/time-util.c
    src/systemd/src/basic/util.c
</pre>
</div>
</content>
</entry>
<entry>
<title>all/tests: split core part out of "nm-test-utils.h"</title>
<updated>2016-05-17T14:48:52+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-05-17T12:04:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=a2c843499ca15ca507f6cab2e071a1068d1d709f'/>
<id>a2c843499ca15ca507f6cab2e071a1068d1d709f</id>
<content type='text'>
A large part of "nm-test-utils.h" is only relevant for tests inside "src/"
directory, as they are helpers related to NetworkManager core part.

Split this part out of "nm-test-utils.h" header.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A large part of "nm-test-utils.h" is only relevant for tests inside "src/"
directory, as they are helpers related to NetworkManager core part.

Split this part out of "nm-test-utils.h" header.
</pre>
</div>
</content>
</entry>
<entry>
<title>systemd: split "nm-sd.h" out of "nm-sd-adapt.h"</title>
<updated>2016-03-11T10:02:12+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-03-11T09:25:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=aed3c810b3681fa38000487f519660a338bc063e'/>
<id>aed3c810b3681fa38000487f519660a338bc063e</id>
<content type='text'>
Now we have:

"nm-sd.h" is a header file of NetworkManager with utilities
related to systemd. It can be used anywhere freely.

Also, systemd headers that are considered public API (like
"sd-event.h") can be used without restrictions.

When compiling the systemd sources, we always must include
"nm-sd-adapt.h" as first. Similarly, systemd headers must
not include "nm-sd-adapt.h", because they are either public
(in which case the adapter is not needed) or they are internal
(in which case they are themself included via a systemd source).

Sometimes, we must internal API (like "dhcp-lease-internal.h").
In this case, we also must include "nm-sd-adapt.h".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now we have:

"nm-sd.h" is a header file of NetworkManager with utilities
related to systemd. It can be used anywhere freely.

Also, systemd headers that are considered public API (like
"sd-event.h") can be used without restrictions.

When compiling the systemd sources, we always must include
"nm-sd-adapt.h" as first. Similarly, systemd headers must
not include "nm-sd-adapt.h", because they are either public
(in which case the adapter is not needed) or they are internal
(in which case they are themself included via a systemd source).

Sometimes, we must internal API (like "dhcp-lease-internal.h").
In this case, we also must include "nm-sd-adapt.h".
</pre>
</div>
</content>
</entry>
<entry>
<title>systemd: integrate sd-event into glib main loop</title>
<updated>2016-03-11T08:28:12+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-03-09T11:27:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=a8bc65b1a19221677a8771aa9c4903407560a576'/>
<id>a8bc65b1a19221677a8771aa9c4903407560a576</id>
<content type='text'>
We should not try to reimplement sd-event based on glib,
instead we should hook sd-event into the glib mainloop.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We should not try to reimplement sd-event based on glib,
instead we should hook sd-event into the glib mainloop.
</pre>
</div>
</content>
</entry>
<entry>
<title>systemd: merge branch systemd into th/systemd-lldp-bgo763384</title>
<updated>2016-03-11T08:28:10+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-02-29T13:30:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=18133ea1428648781dba74c26dd5d118e8d5ce33'/>
<id>18133ea1428648781dba74c26dd5d118e8d5ce33</id>
<content type='text'>
As the lldp API changed, adjust "nm-lldp-listener.c".

Note that the commit is not yet functional due to missing
sd_event_source_set_enabled() and sd_event_source_set_time().
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As the lldp API changed, adjust "nm-lldp-listener.c".

Note that the commit is not yet functional due to missing
sd_event_source_set_enabled() and sd_event_source_set_time().
</pre>
</div>
</content>
</entry>
</feed>
