<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git/src/supplicant, branch th/fix-python-test</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>wifi: fix the supplicant config test</title>
<updated>2019-09-20T14:24:40+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-09-20T14:20:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e1cda0150ca9f78b19967542234227cbf1853b18'/>
<id>e1cda0150ca9f78b19967542234227cbf1853b18</id>
<content type='text'>
Oopsie, forgot to adjust the test for change in roaming signal strength
threshold.

Fixes: 24bbceed9bad ('wifi: roam more aggressively'):
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Oopsie, forgot to adjust the test for change in roaming signal strength
threshold.

Fixes: 24bbceed9bad ('wifi: roam more aggressively'):
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: roam more aggressively</title>
<updated>2019-09-20T10:57:16+00:00</updated>
<author>
<name>Kristian Klausen</name>
<email>kristian@klausen.dk</email>
</author>
<published>2019-09-19T08:46:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=24bbceed9badb74dcbfbba51fa2a2df5bf90558d'/>
<id>24bbceed9badb74dcbfbba51fa2a2df5bf90558d</id>
<content type='text'>
-80dBm is a very weak signal and we should roam sooner.
iwd[1] and iOS[2] default to -70dBm, Android[3] default to -73dBm.
So lets change the roaming threshold to -70dBm.

[1] https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=45a51613c4c24067fe0e35b4c084a50124282b36
[2] https://support.apple.com/en-us/HT203068
[3] https://android.googlesource.com/platform/frameworks/base/+/68a4599a37e07745cbe0d441e29152da388b5baa/core/res/res/values/config.xml#609
    https://android.googlesource.com/platform/frameworks/opt/net/wifi/+/dacacbf69da8844232d938437b3b38471a3d2827/service/java/com/android/server/wifi/ScoringParams.java#218
    https://android.googlesource.com/platform/frameworks/opt/net/wifi/+/dacacbf69da8844232d938437b3b38471a3d2827/service/java/com/android/server/wifi/ScoringParams.java#325
    https://android.googlesource.com/platform/frameworks/opt/net/wifi/+/ee0920fb68d2f4447936301ce3192c345224e8e7/service/java/com/android/server/wifi/WifiNetworkSelector.java#149

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/201
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/278
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
-80dBm is a very weak signal and we should roam sooner.
iwd[1] and iOS[2] default to -70dBm, Android[3] default to -73dBm.
So lets change the roaming threshold to -70dBm.

[1] https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=45a51613c4c24067fe0e35b4c084a50124282b36
[2] https://support.apple.com/en-us/HT203068
[3] https://android.googlesource.com/platform/frameworks/base/+/68a4599a37e07745cbe0d441e29152da388b5baa/core/res/res/values/config.xml#609
    https://android.googlesource.com/platform/frameworks/opt/net/wifi/+/dacacbf69da8844232d938437b3b38471a3d2827/service/java/com/android/server/wifi/ScoringParams.java#218
    https://android.googlesource.com/platform/frameworks/opt/net/wifi/+/dacacbf69da8844232d938437b3b38471a3d2827/service/java/com/android/server/wifi/ScoringParams.java#325
    https://android.googlesource.com/platform/frameworks/opt/net/wifi/+/ee0920fb68d2f4447936301ce3192c345224e8e7/service/java/com/android/server/wifi/WifiNetworkSelector.java#149

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/201
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/278
</pre>
</div>
</content>
</entry>
<entry>
<title>supplicant: add FT-SAE key-mgmt to verification list</title>
<updated>2019-09-16T14:21:35+00:00</updated>
<author>
<name>Beniamino Galvani</name>
<email>bgalvani@redhat.com</email>
</author>
<published>2019-09-16T14:14:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=c177a38e88021392412a796154d47168b8b17598'/>
<id>c177a38e88021392412a796154d47168b8b17598</id>
<content type='text'>
FT-SAE is missing in the supplicant configuration verification list,
causing an activation failure when using SAE and the supplicant
supports FT.

Fixes: d17a0a090555 ('supplicant: allow fast transition for WPA-PSK and WPA-EAP')
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
FT-SAE is missing in the supplicant configuration verification list,
causing an activation failure when using SAE and the supplicant
supports FT.

Fixes: d17a0a090555 ('supplicant: allow fast transition for WPA-PSK and WPA-EAP')
</pre>
</div>
</content>
</entry>
<entry>
<title>all: SPDX header conversion</title>
<updated>2019-09-10T09:19:56+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-09-10T09:19:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=24028a22467275671df71cc6a8054036b37d8f03'/>
<id>24028a22467275671df71cc6a8054036b37d8f03</id>
<content type='text'>
  $ find * -type f |xargs perl contrib/scripts/spdx.pl
  $ git rm contrib/scripts/spdx.pl
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
  $ find * -type f |xargs perl contrib/scripts/spdx.pl
  $ git rm contrib/scripts/spdx.pl
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: drop support for wpa-none key-mgmt</title>
<updated>2019-08-26T08:25:00+00:00</updated>
<author>
<name>Beniamino Galvani</name>
<email>bgalvani@redhat.com</email>
</author>
<published>2019-08-19T13:32:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=c97e0ce30b8b9b118d47d0e02e6ebe7556e9f0c4'/>
<id>c97e0ce30b8b9b118d47d0e02e6ebe7556e9f0c4</id>
<content type='text'>
NM didn't support wpa-none for years because kernel drivers used to be
broken. Note that it wasn't even possible to *add* a connection with
wpa-none because it was rejected in nm_settings_add_connection_dbus().
Given that wpa-none is also deprecated in wpa_supplicant and is
considered insecure, drop altogether any reference to it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
NM didn't support wpa-none for years because kernel drivers used to be
broken. Note that it wasn't even possible to *add* a connection with
wpa-none because it was rejected in nm_settings_add_connection_dbus().
Given that wpa-none is also deprecated in wpa_supplicant and is
considered insecure, drop altogether any reference to it.
</pre>
</div>
</content>
</entry>
<entry>
<title>wifi: detect FT support per interface and avoid enabling it</title>
<updated>2019-08-20T14:28:28+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2019-08-20T13:50:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=2f8a4e90f0fd0f900996e3081d49f8799bba4c6f'/>
<id>2f8a4e90f0fd0f900996e3081d49f8799bba4c6f</id>
<content type='text'>
Previously we only cared whether supplicant is build with support for
FT. In that case we would pass FT-PSK to supplicant, like

  Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK'

Supplicant would then always try FT with preference, regardless whether
the interface/driver support it. That results in a failure to associate, if
the driver does not support it.

  NetworkManager[1356]: &lt;info&gt;  [1566296144.9940] Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK'
  ...
  wpa_supplicant[1348]: wlan0: WPA: AP key_mgmt 0x42 network profile key_mgmt 0x142; available key_mgmt 0x42
  wpa_supplicant[1348]: wlan0: WPA: using KEY_MGMT FT/PSK
  ...
  wpa_supplicant[1348]:   * akm=0xfac04
  ...
  kernel: ERROR @wl_set_key_mgmt :
  kernel: invalid cipher group (1027076)

Since we pass a list of acceptable "key_mgmt" options to supplicant,
FT-PSK should not be used when supplicant knows it's not supported.
That is a supplicant bug.

Regardless, work around it by checking the per-interface capability, and
avoid it if support is apparently not present.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously we only cared whether supplicant is build with support for
FT. In that case we would pass FT-PSK to supplicant, like

  Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK'

Supplicant would then always try FT with preference, regardless whether
the interface/driver support it. That results in a failure to associate, if
the driver does not support it.

  NetworkManager[1356]: &lt;info&gt;  [1566296144.9940] Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK'
  ...
  wpa_supplicant[1348]: wlan0: WPA: AP key_mgmt 0x42 network profile key_mgmt 0x142; available key_mgmt 0x42
  wpa_supplicant[1348]: wlan0: WPA: using KEY_MGMT FT/PSK
  ...
  wpa_supplicant[1348]:   * akm=0xfac04
  ...
  kernel: ERROR @wl_set_key_mgmt :
  kernel: invalid cipher group (1027076)

Since we pass a list of acceptable "key_mgmt" options to supplicant,
FT-PSK should not be used when supplicant knows it's not supported.
That is a supplicant bug.

Regardless, work around it by checking the per-interface capability, and
avoid it if support is apparently not present.
</pre>
</div>
</content>
</entry>
<entry>
<title>supplicant: mark static arrays as const and static in "nm-supplicant-settings-verify.c"</title>
<updated>2019-08-02T16:19:49+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2019-08-02T16:05:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=79660f1f5b1d336ba8b24f9ce71442ac9f0dfd81'/>
<id>79660f1f5b1d336ba8b24f9ce71442ac9f0dfd81</id>
<content type='text'>
They should be "static" and only visible to this source file.

Also, they should be "const", that allows the linker to place them
into read-only memory.

(cherry picked from commit 722b167953c2384615cb11bbc88988dec7e647ab)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
They should be "static" and only visible to this source file.

Also, they should be "const", that allows the linker to place them
into read-only memory.

(cherry picked from commit 722b167953c2384615cb11bbc88988dec7e647ab)
</pre>
</div>
</content>
</entry>
<entry>
<title>supplicant: don't put binary data in error message for supplicant</title>
<updated>2019-08-02T16:19:49+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2019-08-02T15:34:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=da933ffe2ab9e372e7b418ed52b7ff3662dd553f'/>
<id>da933ffe2ab9e372e7b418ed52b7ff3662dd553f</id>
<content type='text'>
For better or worse, the API does not require the value to be a
UTF-8 string. We cannot just concatenate binary to a string.
Instead, backslash escape it with utf8safe-escape.

Also, this will shut up a (wrong) coverity warning at this place.

(cherry picked from commit 55143dad95dde9e5eae2a5084e39313fcfba4a4a)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For better or worse, the API does not require the value to be a
UTF-8 string. We cannot just concatenate binary to a string.
Instead, backslash escape it with utf8safe-escape.

Also, this will shut up a (wrong) coverity warning at this place.

(cherry picked from commit 55143dad95dde9e5eae2a5084e39313fcfba4a4a)
</pre>
</div>
</content>
</entry>
<entry>
<title>supplicant: fix nm_supplicant_settings_verify_setting() honoring the string length</title>
<updated>2019-08-02T16:19:49+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2019-08-02T15:25:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=d99925a1b05f49d79e68b143edec6ca70d5e7267'/>
<id>d99925a1b05f49d79e68b143edec6ca70d5e7267</id>
<content type='text'>
We must not just pretend that the value is a NULL terminated string.
That's why we have the length argument.

(cherry picked from commit 9ed26de3daf71020dd0148fcc1ad9de8cc5e5009)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We must not just pretend that the value is a NULL terminated string.
That's why we have the length argument.

(cherry picked from commit 9ed26de3daf71020dd0148fcc1ad9de8cc5e5009)
</pre>
</div>
</content>
</entry>
<entry>
<title>supplicant-config: add support for joining a Mesh</title>
<updated>2019-07-29T08:28:22+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-01-24T14:31:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=f249956cf7e6fdcef0dc2dcb76ca938f9e3dff21'/>
<id>f249956cf7e6fdcef0dc2dcb76ca938f9e3dff21</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
