delta/NetworkManager.git/src/settings/plugins/keyfile, branch th/cli-strsplit

settings: fix clearing nm-generated/volatile flags of connection

2017-12-11T11:12:08+00:00

There are a few cases where we don't want to clear a potential
nm-generated/volatile flag, but only mark the connection as
unsaved.

Otherwise, we wrongly end up clearing these flags and the connection
is wrongly not NM_DEVICE_SYS_IFACE_STATE_EXTERNAL.

Fixes: 35dc6421de78cffd1761cfb6edf9e94233f99966

keyfile/tests: test tc traffic filter reading and writing

2017-12-11T10:02:04+00:00

keyfile/tests: test tc qdisc reading and writing

2017-12-11T09:52:23+00:00

settings: pass new_connection to commit_changes() and fix ifnet

2017-12-05T18:57:24+00:00

ifnet shall use the new_connection argument, not NM_CONNECTION(self).
Also, let the caller of the virtual function provide the right new_connection,
not having the virtual function figure that out.

settings: unify settings-update API (rename and merge)

2017-12-05T18:57:24+00:00

settings: unify settings-update API (nm_settings_connection_replace_settings())

2017-12-05T18:57:24+00:00

settings: add persistent-mode argument for connection-replace

2017-12-05T10:50:52+00:00

The current behavior of update_unsaved is confusing. Give the argument
an enum with a name that describes better what's happening. Also, it
makes the uses grep-able.

all: use nm_direct_hash() instead of g_direct_hash()

2017-11-16T10:49:52+00:00

We also do this for libnm, where it causes visible changes
in behavior. But if somebody would rely on the hashing implementation
for hash tables, it would be seriously flawed.

all: avoid coverity warnings about "Wrong Check of Return Value"

2017-10-30T13:10:56+00:00

30. NetworkManager-1.9.2/src/settings/plugins/keyfile/nms-keyfile-writer.c:218:
check_return: Calling "g_mkdir_with_parents" without checking return
value (as is done elsewhere 4 out of 5
 times).

25. NetworkManager-1.9.2/src/platform/nm-linux-platform.c:3969:
check_return: Calling "_nl_send_nlmsg" without checking return value (as
is done elsewhere 4 out of 5 times).

34. NetworkManager-1.9.2/src/nm-core-utils.c:2843:
negative_returns: "fd2" is passed to a parameter that cannot be negative.

26. NetworkManager-1.9.2/src/devices/wwan/nm-modem-broadband.c:897:
check_return: Calling "nm_utils_parse_inaddr_bin" without checking
return value (as is done elsewhere 4 out of 5 times).

3. NetworkManager-1.9.2/src/devices/bluetooth/nm-bluez5-manager.c:386:
check_return: Calling "g_variant_lookup" without checking return value
(as is done elsewhere 79 out of 83 times).

16. NetworkManager-1.9.2/libnm-util/nm-setting.c:405:
check_return: Calling "nm_g_object_set_property" without checking return
value (as is done elsewhere 4 out of 5 times).

settings: extend commit_changes() to update the settings after writing

2017-10-25T12:04:36+00:00

During write, it can regularly happen that the connection gets modified.
For example, keyfile never writes blobs as-is, it always writes the
blob to an external file, and replaces the certificate property with
a path.
Other reasons could be just bugs, where the reader and writer are not doing
a proper round trip (these cases should be fixed).

Refactor commit_changes(), to return the re-read connection to
the settings-connection class, and handle replacing the settings
there.

Also, prepare for another change. Sometimes we first call replace_settings()
followed by commit_changes(). It would be better to instead call commit_changes()
first, and only on success proceed with replace_settings(). Hence, commit_changes()
gets a new argument new_connection, that can be used to write another
connection to disk.