Users are probably more familiar with iproute2 route option names than kernel ones. Fixes: 54e58eb96bbfcd26d31ddba2e98ff2c59335a02a
Catches previously fixed memleak in read_array_of_uint()
The tests were checking that the keyfiles had permission 0600 and there was a check-local target to prepare the permissons of the tests. That is inconvenient, and it is unexpected to have a check-local target for such a case. Also, the tests were not testing that keyfile reader would bail out on invalid permissions. So just skip the check for testing.
These properties limit whether the connection applies to a certain WWAN modem based on the modem's device ID or SIM ID (as reported by the WWAN management service), or through the MCC/MNC ID of the operator that issued the SIM card.
The kernel defaults REORDER_HDR to 1 when creating a new VLAN, but NetworkManager's VLAN flags property defaulted to 0. Thus REORDER_HDR was not set for NM-created VLANs with default values. We want to match the kernel default, so we change the default value for the vlan.flags property. However, we do not want to change the flags for existing connections if the property is missing in connection files. Thus we have to update plugins for that. We also make sure that vlan.flags is always written by 'keyfile' when the value is default. That way new connections have flags property explicitly written and it will be loaded as expected. https://bugzilla.redhat.com/show_bug.cgi?id=1250225
keyfile should become our main import/export format. It is desirable, that a keyfile can contain every aspect of a connection. For blob certificates, the writer in core daemon would always write them to a file and convert the scheme to path. This behavior is not great for a (hyptetical) `nmcli connection export` command because it would have to export them somehow outside of keyfile, e.g. by writing them to temporary files. Instead, if the write handler does not handle a certificate, use a default implementation in nm_keyfile_write() which adds the blob inside the keyfile. Interestingly, keyfile reader already supported reading certificate blobs. But this legacy format accepts the blob as arbitrary binary without marking the format and without scheme prefix. Instead of writing the binary data directly, write it with a new uri scheme "data:;base64," and encode it in base64. Also go through some lengths to make sure that whatever path keyfile plugin writes, can be read back again. That is, because keyfile writer preferably writes relative paths without prefix. Add nm_keyfile_detect_unqualified_path_scheme() to encapsulate the detection of pathnames without file:// prefix and use it to check whether the path name must be fully qualified.