delta/NetworkManager.git/src/ppp, branch th/cli-strsplit

core: refactor NMActRequestGetSecretsCallId typedef not to be a pointer to struct

2017-11-24T15:31:29+00:00

Typedefs to structs are fine, but a typedef for a pointer seems confusing to
me. Let's avoid it.

core: use nm_close()

2017-10-19T13:49:58+00:00

Use nm_close() in the core to catch any improper use of close().

core: rework tracking of gateway/default-route in ip-config

2017-10-10T06:46:47+00:00

Instead of having 3 properties @gateway, @never_default and @has_gateway
on NMIP4Config/NMIP6Config that determine the default-route, track the
default-route as a regular route.

The gateway setting is the configuration knob for the default-route.
Since an NMIP4Config/NMIP6Config instance only has one gateway property,
it cannot track more then one default-routes (see related bug rh#1445417).
Especially with policy routing, it might be interesting to configure a
default-route in multiple tables.

Also, later it might be interesting to allow adding default-routes as
regular static routes in a connection, so that the user can configure additional
route parameters for the default-route or add default-routes in multiple tables.

With this patch, default-routes now have a rt_source property according to their
origin.

Also, the previous commits of this branch broke handling of the
default-route :) . That should be working now again.

core: ppp: use a different unit for each activation

2017-08-05T06:03:16+00:00

We can't tell pppd to create an interface with a given name, so we use
the name generated by kernel and rename the interface afterwards. A
race condition can happen during the rename: NM receives the interface
name from pppd, but in the meantime the interface could be deleted and
another one with that name could appear. In this case we would rename
the wrong interface.

Using a changing unit index, we ensure that interfaces created by NM
don't race with each others. There is still the chance to race with
externally-created interfaces, but I guess this is not easily solvable
since the pppd plugin does not expose the ifindex.

When the specified unit is already in use, the kernel selects another
one.

ppp: fix generation of IP config received from pppd

2017-07-28T08:37:23+00:00

Since commit 22edeb5b691b ("core: track addresses for
NMIP4Config/NMIP6Config via NMDedupMultiIndex"), addresses can be
added to a IP config only after the ifindex has been set.

Fixes: 22edeb5b691befd796c534cf71901b32f0b7945b

core: pass NMDedupMultiIndex instance to NMIP4Config and other

2017-07-05T12:22:10+00:00

NMIP4Config, NMIP6Config, and NMPlatform shall share one
NMDedupMultiIndex instance.

For that, pass an NMDedupMultiIndex instance to NMPlatform and NMNetns.
NMNetns than passes it on to NMDevice, NMDhcpClient, NMIP4Config and NMIP6Config.
So currently NMNetns is the access point to the shared NMDedupMultiIndex
instance, and it gets it from it's NMPlatform instance.

The NMDedupMultiIndex instance is really a singleton, we don't want
multiple instances of it. However, for testing, instead of adding a
singleton instance, pass the instance explicitly around.

ppp: fix cancelling timeout when pppd process exits

2017-06-09T14:15:07+00:00

Otherwise, we get pppd_timed_out() later, which will
emit a DEAD state change at unexpected times.

ppp: cleanup logging pppd exit reason in ppp_watch_cb

2017-06-09T14:07:47+00:00

- don't use assert but be more graceful with g_return_if_fail().
- in case of failure, don't log a debug message after the warning.
  One message is sufficient, drop "pppd pid %d cleaned up".
- print GPid type as long long.
- increase log level to warning. pppd dying unexpectedly warrants a
  warning.

ppp: don't log newlines

2017-06-09T13:42:49+00:00

ppp: refactor ppp_exit_code() to split out error to string conversion

2017-06-09T13:42:49+00:00

ppp_exit_code() does too much or too little. Either it should log
about all reasons why pppd exited, including signals, or it should
just do the status to string conversion. Split it.