delta/NetworkManager.git/src/platform, branch lr/python3

all: use the elvis operator wherever possible

2018-05-10T12:36:58+00:00

Coccinelle:

  @@
  expression a, b;
  @@
  -a ? a : b
  +a ?: b

Applied with:

  spatch --sp-file ternary.cocci --in-place --smpl-spacing --dir .

With some manual adjustments on spots that Cocci didn't catch for
reasons unknown.

Thanks to the marvelous effort of the GNU compiler developer we can now
spare a couple of bits that could be used for more important things,
like this commit message. Standards commitees yet have to catch up.

platform: fix adding direct route to gateway

2018-05-07T15:15:34+00:00

Without ifindex, adding the direct route to gateway fails:

 platform: route-sync: failure to add IPv6 route: fd02::/64 via fd01::1 dev 1635 metric 101 mss 0 rt-src user: No route to host (113); try adding direct route to gateway fd01::1/128 via :: metric 101 mss 0 rt-src user
 platform: route: append     IPv6 route: fd01::1/128 via :: metric 101 mss 0 rt-src user
 platform-linux: delayed-action: schedule wait-for-nl-response (seq 269, timeout in 0.199999195, response-type 0)
 platform-linux: delayed-action: handle wait-for-nl-response (any)
 platform-linux: netlink: recvmsg: new message NLMSG_ERROR, flags 0, seq 269
 platform-linux: netlink: recvmsg: error message from kernel: No such device (19) for request 269

Fixes: c9f89cafdf588f443821ccff220283859ab26d1f

all: remove consecutive empty lines

2018-04-30T14:24:52+00:00

Normalize coding style by removing consecutive empty lines from C
sources and headers.

https://github.com/NetworkManager/NetworkManager/pull/108

test-common: drop unused variables

2018-04-23T06:26:41+00:00

src/platform/tests/test-common.c:1500:17: error: unused variable 'dev' [-Werror,-Wunused-variable]
                gs_free char *dev = NULL;
                              ^
src/platform/tests/test-common.c:1501:17: error: unused variable 'local' [-Werror,-Wunused-variable]
                gs_free char *local = NULL, *remote = NULL;
                              ^
src/platform/tests/test-common.c:1501:32: error: unused variable 'remote' [-Werror,-Wunused-variable]
                gs_free char *local = NULL, *remote = NULL;
                                             ^
Fixes: bd8ab54b8e2f66a53971430d66db766ca30b18ad

all: replace "it's" with "its" where needed

2018-04-18T12:14:07+00:00

build: meson: add prefix to test names

2018-04-12T07:21:10+00:00

There are multiple tests with the same in different directories; add a
unique prefix to test names so that it is clear from the output which
one is running.

build: meson: increase timeout for some tests

2018-04-12T07:21:10+00:00

Some tests, when run in parallel, can take more than the default
timeout (30 seconds). Increase the timeout for them.

build: meson: use run-nm-test.sh to run tests

2018-04-12T07:21:10+00:00

Like autotools, use the wrapper script 'run-nm-test.sh' that starts a
separate D-Bus session when needed.

platform: minor cleanup of nm_platform_ip6_address_sync()

2018-04-10T12:20:19+00:00

Drop the "delete_remaining" variable, and instead rely on the value of "i_know"
alone. Also, add a code comment explaining better what is happening.

platform: fix IPv6 address sync after for link local addresses

2018-04-10T12:09:56+00:00

Since commit 78ed0a4a23f2e08cf5f3a4c75c67eba877c66494 (device: add
IPv6 link local address via merge-and-apply) we handle also IPv6 link
local addresses like regular addresses. That is, we also add them during
merge-and-apply and sync them via nm_platform_ip6_address_sync().

ip6-address-sync loops over the platform addresses, to find which
addresses shall be deleted, and which shall be deleted in order to
fix the address order/priority. At that point, we must not ignore
link-local addresses anymore, but handle them too.

Otherwise, during each resync we have link local addresses, and
platform-sync thinks that the address order is wrong. That wrongly
leads to remove most addresses and re-adding them.

Fixes: 78ed0a4a23f2e08cf5f3a4c75c67eba877c66494