delta/NetworkManager.git/src/platform/nm-platform-utils.h, branch th/cli-strsplit

udev: drop libgudev in favor of libudev

2017-03-22T11:41:06+00:00

libgudev is just a wrapper around libudev. We can
use libudev directly and drop the dependency for
libgudev.

platform: add wrappers for if_nametoindex() and if_indextoname()

2017-01-04T13:18:01+00:00

platform: avoid copying arguments for nmp_utils_ethtool_get_driver_info()

2016-12-13T10:26:59+00:00

We call nmp_utils_ethtool_get_driver_info() twice when receiving a
netlink message, but we don't need a clone of the string values.
Instead, expose a data structure that should be stack allocated
by the caller.

platform: remove unused nmp_utils_device_exists() util

2016-12-13T10:26:59+00:00

platform: lookup ifname for ethtool/mii ioctl immediately before use

2016-12-13T10:26:59+00:00

The ioctl APIs ethtool/mii require an interface ifname. That is inherrently
racy as interfaces can be renamed. This cannot be fixed, we can only
minimize the time between verifying the ifname and calling ioctl.

We already had problems with that when ethtool would access an interface
by name that didn't exists. See commit ab41c13b0611c6cc967b055d328637a143b5c59b .
Checking for an existing interface only helps avoiding races when an interface
gets deleted. It does not help against renaming.

Go one step further, and instead of checking whether such an ifname
exists, try to get the ifname based on the ifindex immediately before
we need it.

This brings an additional overhead for each ethtool access.

platform: refactor nmp_utils_sysctl_open_netdir()

2016-12-13T10:26:58+00:00

- use nm_auto_close cleanup attribute
- optionally, return the found ifname
- don't stat "phy80211". If such an entity can be opened,
  just assume it's a directory.

platform: add a new function nmp_utils_open_sysctl()

2016-12-13T10:26:58+00:00

A race condition may happen when NetworkManager opens sysfs and udev
renames interface name at the same time. Thomas Haller provides a new
function [1] which can avoid the race condition when opening sysfs.

This patch is a direct copy from [1].

[1] https://mail.gnome.org/archives/networkmanager-list/2016-December/msg00004.html

Signed-off-by: Kai-Heng Feng

platform: add APIs to allow link negotiation management

2016-11-22T14:24:47+00:00

Added platform functions to retrieve device link mode status and to
switch from auto to manual link negotiation:
nm_platform_ethtool_get_link_settings
nm_platform_ethtool_set_link_settings

platform: declare nmp_utils_ip_config_source_*() functions as const

2016-05-16T11:16:49+00:00

platform: extend NMIPConfigSource to preserve the rtm_protocol field

2016-04-28T10:53:21+00:00

For addresses (NMPlatformIPAddress) the @addr_source field is ignored
on a platform level. That is, all addresses inside the platform cache
have this value set to NM_IP_CONFIG_SOURCE_KERNEL. Maybe, for that reason,
the source should not be a part of the NMPlatformIPAddress structure, but
it is convenient for users to piggy back the source inside the platform
address structure.

For routes, the source is stored in NMPlatformIPRoute's @rt_source
field. When adding a route to kernel, we set the @rtm_protocol of the
route depending on the source. However, we want to map different source
values to the same protocol value.

On the other hand, when kernel sends us a route that gets put inside
the cache, we must preserve the protocol value and must not map
different protocol values to the same source.
The reason is, that a user can add two routes that only differ by
@rtm_protocol. In that sense, the @rtm_protocol fields is part of the
unique ID of a kernel route, and thus different values must map to
different sources.

Fix this, by extending the range of NMIPConfigSource to contain
a range of protocol fields.