$ find * -type f |xargs perl contrib/scripts/spdx.pl $ git rm contrib/scripts/spdx.pl
Kernel 5.2 is adding stricter checking for netlink messages. In particular, for certain API it checks now that NLA_F_NESTED flag is set for nested attributes ([1]). Note that libnl3 does not ever set this flag, and since our netlink implementation is copied from there, certain netlink messages are now rejected as invalid. On the other hand, libmnl always adds this flag ([2]). So we should do that as well. In particular, this affects the WireGuard netlink API causing request from NetworkManager to be rejected ([3]). [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b424e432e770d6dd572765459d5b6a96a19c5286 [2] https://git.netfilter.org/libmnl/tree/src/attr.c?id=5937dfcb0185f5cb9cf275992ea701ec4e619d9c#n535 [3] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/212 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/210
We no longer add these. If you use Emacs, configure it yourself.
Also, due to our "smart-tab" usage the editor anyway does a subpar
job handling our tabs. However, on the upside every user can choose
whatever tab-width he/she prefers. If "smart-tabs" are used properly
(like we do), every tab-width will work.
No manual changes, just ran commands:
F=($(git grep -l -e '-\*-'))
sed '1 { /\/\* *-\*- *[mM]ode.*\*\/$/d }' -i "${F[@]}"
sed '1,4 { /^\(#\|--\|dnl\) *-\*- [mM]ode/d }' -i "${F[@]}"
Check remaining lines with:
git grep -e '-\*-'
The ultimate purpose of this is to cleanup our files and eventually use
SPDX license identifiers. For that, first get rid of the boilerplate lines.
nla_get_u64() was unlike all other nla_get_u*() implementations, in that it would allow for a missing/invalid nla argument, and return 0. Don't do this. For one, don't behave different than other getters. Also, there really is no space to report errors. Hence, the caller must make sure that the attribute is present and suitable -- like for other nla_get_*() functions. None of the callers relied on being able to pass NULL attribute. Also, inline the function and use unaligned_read_ne64(). That is our preferred way for reading unaligned data, not memcpy().
The policy for strings must indicate a minlen of at least 1. Everything else is a bug, because the policy contains invalid data -- and is determined at compile-time.
- use size_t arguments for the memory sizes. While sizes from netlink API currently are int typed and inherrently limited, use the more appropriate data type. - rename the arguments. The "count" is really the size of the destination buffer. - return how many bytes we wanted to write (like g_strlcpy()). That makes more sense than how many bytes we actually wrote because previously, we could not detect truncation. Anyway, none of the callers cared about the return-value either way.
- let nla_strlcpy() return how many bytes we would like to have copied. That way, the caller could detect string truncation. In practice, no caller cared about that. - the code before would also fill the entire buffer with zeros first, like strncpy(). We still do that. However, only copy the bytes up to the first NUL byte. The previous version would have copied "a\0b\0" (with srclen 4) as "a\0b". Strip all bytes after the first NUL character from src. That seems more correct here. - accept nla argument as %NULL.