g_random_*() is based on GRand, which is not a CSPRNG. Instead, rely on kernel to give us good random numbers, which is what nm_random_*() does. Note that nm_random_*() calls getrandom() (or reads /dev/urandom), which most likely is slower than GRand. It doesn't matter for our uses though. It is cumbersome to review all uses of g_rand_*() whether their usage of a non-cryptographically secure generator is appropriate. Instead, just always use an appropriate function, thereby avoiding this question. Even glib documentation refers to reading "/dev/urandom" as alternative. Which is what nm_random_*() does. These days, it seems unnecessary to not use the best random generator available, unless it's not fast enough or you need a stable/seedable stream of random numbers. In particular in nmcli, we used g_random_int_range() to generate passwords. That is not appropriate. Sure, it's *only* for the hotspot, but still.
Fixes: 8132045d5feb ('nmcli: fix typos in nmcli output')
Spotted by lintian: I: network-manager: spelling-error-in-binary writting writing [usr/bin/nmcli] I: network-manager: spelling-error-in-binary wihout without [usr/lib/x86_64-linux-gnu/NetworkManager/1.40.12/libnm-device-plugin-wifi.so] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1515
https://bugzilla.redhat.com/show_bug.cgi?id=2156385 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1500
See `man ovs-vswitchd.conf.db` for documentation of "other_config" keys. https://bugzilla.redhat.com/show_bug.cgi?id=2151455
For external gateway route management. This setting allows an user to deactivate the automatic route addition to the external gateway. It can be especially useful when a VPN inside another VPN is used. Signed-off-by: Frederic Martinsons <frederic.martinsons@unabiz.com> https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/204 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1491
src/nmcli/devices.c:1196: double_free: Calling "_nm_auto_strfreev" frees pointer "arg_arr" which has already been freed.
Fixes: c5d45848dd07 ('cli: mark argv argument for command line parsing as const')
Add the fwmark property and allow setting input and output key for VTI tunnels.
Introduce a "vlan.protocol" property that specifies the protocol of a VLAN, which controls the tag (EtherType) used for encapsulation. Regular VLANs use 802.1Q (tag 0x8100). To implement VLAN stacking it's sometimes useful to have 802.1ad VLANs with tag 0x88A8. The property is a string instead of e.g. an enum because this allows maximum flexibility in the future. For example, it becomes possible to specify an arbitrary number in case if the kernel ever allows it.
The warning "-Wcast-align=strict" seems useful and will be enabled next. Fix places that currently cause the warning by using the new macro NM_CAST_ALIGN(). This macro also nm_assert()s that the alignment is correct.