$ find * -type f |xargs perl contrib/scripts/spdx.pl $ git rm contrib/scripts/spdx.pl
When we are done with a NMKeepAlive instance, we always should do three things: - unset the owner - disarm (freeze) the keep-alive - give up our reference. Add and use nm_keep_alive_destroy() that does this.
I also like this because it's non-obvious that subscription IDs from GDBusConnection are "guint" (contrary to signal handler IDs which are "gulong"). So, by using this API you get a compiler error when using the wrong type. In the past, when switching to nm_clear_g_signal_handler() this uncovered multiple bugs where the wrong type was used to hold the ID.
... and nm_dbus_connection_call_get_name_owner().
"nm-macros-interal.h" already includes <errno.h> and <string.h>. No need to include it everywhere else too.
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/64
A user can always manually activate his/her own profile, even if the profile is currently is invisible. -- it could be invisible, because the profile has "connection.permissions" set but the user has no active session. Now, if the user should be able to activate such a profile, then it cannot fail simply because being invisible all along. Instead, the alive check must only fail, if a connection becomes invisible that was visible in the time since it is monitored.
NMKeepAlive supports conditions (watches, bindings) that determine whether the instance signals alive state. Currently, there are two conditions: watch a VISIBLE state of a connection and watch whether a D-Bus client is registered. Anyway, if none of these conditions are enabled, then the default should be that the instance is alive. If one or more conditions are enabled, then they cooprate in a particular way, depending on whether the condition is enabled and whether it is satisfied. Previously, the code couldn't differenciate whether a D-Bus watch was not enabled or whether the D-Bus client already disconnected. It would just check whether priv->dbus_client was set, but that alone was not sufficient to differentiate. That means, we couldn't determine whether the keep-alive instance is alive (by default, as no D-Bus watch is enabled) or whether the keep-alive instance is dead (because the D-Bus client disconnected). Fix that, by tracking explicitly whether to watch based on a priv->dbus_client_watching flag. Note, that problems by this were avoided earlier, by only arming the instance when enabling a condition. But I think the concept of arming the keep-alive instance merely means that the instance is ready to fire events. It should not mean that the user only arms the instance after registering a condition. Also, without this, we couldn't unbind the NMKeepAlive instance from all conditions, without making it dead right away. Unbinding/disabling all conditions should render the instance alive, not dead.
set-forced is currently unused, so drop it. NMKeepAlive in principle determines the alive-status based on multiple aspects, that in combination render the instance alive or dead. These aspects cooperate in a particular way. By default, a keep-alive instance should be alive. If there are conditions enabled that further determine the alive-state, then these conditions cooperate in a particular way. As it was, the force-flag would just overrule them all. But is that useful? The nm_keep_alive_set_forced() API also means that only one user caller can have control over the flag. Independent callers cannot cooperate on setting the flag, because there is no reference-counting or registered handles. At least today, it's unclear whether this flag really should overrule all other conditions and how this flag would actually be used. Drop it for now.