<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git/src/libnm-client-impl, branch master</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>libnm: add comment about context-busy-watcher and g_dbus_connection_signal_unsubscribe()</title>
<updated>2021-03-29T19:05:38+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-29T08:28:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=49d69bc1b039f4e98dbf90203d0dab89314c7aaa'/>
<id>49d69bc1b039f4e98dbf90203d0dab89314c7aaa</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm: better explain nm_client_new()/nm_client_new_async()</title>
<updated>2021-03-29T16:33:35+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-29T07:10:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=193a6ac3e5e4226de8e69aa35d172fb9dc57415f'/>
<id>193a6ac3e5e4226de8e69aa35d172fb9dc57415f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm: cleanup handling of cancellation for initializing NMClient</title>
<updated>2021-03-29T16:33:31+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-29T07:06:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=89a6671e5fff8d245f5a9d5ad98fb4e7bea880c4'/>
<id>89a6671e5fff8d245f5a9d5ad98fb4e7bea880c4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>all: split "range" variant of nm_utils_ptrarray_find_binary_search()</title>
<updated>2021-03-16T08:55:49+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-16T08:29:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=6e4cdae25638284a77c8487fd062b46b1f5dfd9f'/>
<id>6e4cdae25638284a77c8487fd062b46b1f5dfd9f</id>
<content type='text'>
nm_utils_ptrarray_find_binary_search() had two additional output
arguments: the first and last index -- in case the sorted list contains
duplicates.

That's nice, and was used in the past. But now, those output arguments
are no longer used.

So drop them from nm_utils_ptrarray_find_binary_search().

Actually, we could now also drop the previous variant
nm_utils_ptrarray_find_binary_search_range(), as it's only used by unit
tests. However, although not rocket science, getting this right is not
entirely trivial, so lets keep the code in case we need it again.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
nm_utils_ptrarray_find_binary_search() had two additional output
arguments: the first and last index -- in case the sorted list contains
duplicates.

That's nice, and was used in the past. But now, those output arguments
are no longer used.

So drop them from nm_utils_ptrarray_find_binary_search().

Actually, we could now also drop the previous variant
nm_utils_ptrarray_find_binary_search_range(), as it's only used by unit
tests. However, although not rocket science, getting this right is not
entirely trivial, so lets keep the code in case we need it again.
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm: guard against empty attribute names for NMLldpNeighbor</title>
<updated>2021-03-12T17:56:43+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-12T08:42:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=cba31136078207f2e8f778759ce4bdf5932a0f55'/>
<id>cba31136078207f2e8f778759ce4bdf5932a0f55</id>
<content type='text'>
The libnm API NMLldpNeighbor does not accept "" as an attribute name.
And it does not need to, because a reasonable NetworkManager should
never expose such names.

However, we should not trust NetworkManager to be reasonable. Check that
the attribute name is not empty.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The libnm API NMLldpNeighbor does not accept "" as an attribute name.
And it does not need to, because a reasonable NetworkManager should
never expose such names.

However, we should not trust NetworkManager to be reasonable. Check that
the attribute name is not empty.
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm: call nm_lldp_neighbor_get_attr_value() from redundant helpers</title>
<updated>2021-03-12T17:56:42+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-12T08:40:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=84d64217f8a7a28fced8114df4ea341a109c5021'/>
<id>84d64217f8a7a28fced8114df4ea341a109c5021</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm/trivial: move code</title>
<updated>2021-03-12T17:56:41+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-11T10:00:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=626a83d0250eec8c363370522601e66d61c44db3'/>
<id>626a83d0250eec8c363370522601e66d61c44db3</id>
<content type='text'>
Move nm_lldp_neighbor_get_attr_value() first. The other functions are all redundant
and should possibly be deprecated.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move nm_lldp_neighbor_get_attr_value() first. The other functions are all redundant
and should possibly be deprecated.
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm: for boxed type NMLldpNeighbor only ref the instance instead of deep cloning</title>
<updated>2021-03-12T17:56:41+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-11T07:35:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=be40c8fdf70cb388995a59d72278e23caff13db5'/>
<id>be40c8fdf70cb388995a59d72278e23caff13db5</id>
<content type='text'>
There is no public API to modify a NMLldpNeighbor instance. They are only
created by NMDevice and afterwards immutable. There is no point to duplicate
them, when we can just take a ref.

Note that this means we must be careful if we ever add API to mutate a
NMLldpNeighbor. But immutable types are awesome, so we probably should
never do that anyway.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There is no public API to modify a NMLldpNeighbor instance. They are only
created by NMDevice and afterwards immutable. There is no point to duplicate
them, when we can just take a ref.

Note that this means we must be careful if we ever add API to mutate a
NMLldpNeighbor. But immutable types are awesome, so we probably should
never do that anyway.
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm: minor cleanup of NMLldpNeighbor getters</title>
<updated>2021-03-12T17:56:40+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-11T07:33:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=ae881b7b5b3f167a9370d1bd187af33f9629c1a4'/>
<id>ae881b7b5b3f167a9370d1bd187af33f9629c1a4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm: sort attributes in nm_lldp_neighbor_get_attr_names()</title>
<updated>2021-03-12T17:56:40+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2021-03-11T07:26:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=88e22b6832472540602bb63ad25e04d6d115bcc9'/>
<id>88e22b6832472540602bb63ad25e04d6d115bcc9</id>
<content type='text'>
A hash table gives values in undefined order. Sort them, to
get a stable order.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A hash table gives values in undefined order. Sort them, to
get a stable order.
</pre>
</div>
</content>
</entry>
</feed>
