delta/NetworkManager.git/src/devices/tests/test-arping.c, branch th/cli-strsplit gitlab.freedesktop.org: NetworkManager/NetworkManager.git tests: increase timeout for arping test 2017-10-27T09:15:51+00:00 Thomas Haller thaller@redhat.com 2017-10-27T09:15:51+00:00 88c24ffc6aa8484310505726fd7e3010ef9c7c45 I hit an assertion failure running with valgrind on a busy machine. Maybe the timeout is just not long enough for every case. Increase it. 
I hit an assertion failure running with valgrind on a busy machine.
Maybe the timeout is just not long enough for every case.

Increase it.
platform/tests: use nm_platform_link_veth_add() to create veth pair in test 2017-05-27T21:16:56+00:00 Thomas Haller thaller@redhat.com 2017-05-26T18:05:08+00:00 d3c71ce4dade9f2ba3e966f63bd7554d9c40f95a 






build: don't add subdirectories to include search path but require qualified include
2016-11-21T13:26:37+00:00

Thomas Haller
thaller@redhat.com

2016-11-20T23:43:52+00:00

44ecb41593bc627d8f4529e74de4a549cf24a695

Keep the include paths clean and separate. We use directories to group source
files together. That makes sense (I guess), but then we should use this
grouping also when including files. Thus require to #include files with their
path relative to "src/".

Also, we build various artifacts from the "src/" tree. Instead of having
individual CFLAGS for each artifact in Makefile.am, the CFLAGS should be
unified. Previously, the CFLAGS for each artifact differ and are inconsistent
in which paths they add to the search path. Fix the inconsistency by just
don't add the paths at all.





Keep the include paths clean and separate. We use directories to group source
files together. That makes sense (I guess), but then we should use this
grouping also when including files. Thus require to #include files with their
path relative to "src/".

Also, we build various artifacts from the "src/" tree. Instead of having
individual CFLAGS for each artifact in Makefile.am, the CFLAGS should be
unified. Previously, the CFLAGS for each artifact differ and are inconsistent
in which paths they add to the search path. Fix the inconsistency by just
don't add the paths at all.







build: merge "src/devices/tests/Makefile.am" into toplevel Makefile
2016-10-21T15:04:06+00:00

Thomas Haller
thaller@redhat.com

2016-10-18T07:36:53+00:00

f3437707e38b4912fb463db042f57234f5e5bab6












build: merge "src/platform/tests/Makefile.am" into toplevel Makefile
2016-10-21T15:04:06+00:00

Thomas Haller
thaller@redhat.com

2016-10-18T07:36:53+00:00

04eb0afd2895a9b6f4be743dba1d390ebe3ffccb












platform/tests: add @platform argument to nmtstp functions
2016-04-11T09:26:37+00:00

Thomas Haller
thaller@redhat.com

2016-04-07T10:32:00+00:00

c4151ebb5bae48f37737126b35116ea97fd93428

This allows tests to use these functions on a different platform instance
then on the singleton. The change makes the argument list longer, which is
unfortunate. On the other hand, it makes those functions more useful
in general.

You can't have it all.

Also, they now follow the pattern of most functions in NM where the type
is a singleton: you always pass the singleton to the function, although
in the usual case there is only one singleton instance. This allows to
use the function also on the non-singleton instance.





This allows tests to use these functions on a different platform instance
then on the singleton. The change makes the argument list longer, which is
unfortunate. On the other hand, it makes those functions more useful
in general.

You can't have it all.

Also, they now follow the pattern of most functions in NM where the type
is a singleton: you always pass the singleton to the function, although
in the usual case there is only one singleton instance. This allows to
use the function also on the non-singleton instance.







platform/tests/trivial: rename init_tests() and setup_tests() function
2016-04-11T09:26:37+00:00

Thomas Haller
thaller@redhat.com

2016-04-06T19:16:49+00:00

25d826ec49585953a5e4ec50995c864ed0bf257f

Make it clear that they are nmtstp functions, i.e. they are found
in the header "test-common.h".





Make it clear that they are nmtstp functions, i.e. they are found
in the header "test-common.h".







platform/tests: pass platform argument to nmtstp helper functions
2016-03-15T11:56:58+00:00

Thomas Haller
thaller@redhat.com

2016-03-14T14:23:05+00:00

ad345cdf7d2d77c945c8a56aa1349a44963bd876

Make the test helper independent from the platform singleton instance.
That way, we can also use them for other platform instances (e.g. in a
different namespace).





Make the test helper independent from the platform singleton instance.
That way, we can also use them for other platform instances (e.g. in a
different namespace).







platform: add flags argument to nm_platform_ip4_address_add()
2016-03-01T14:09:16+00:00

Thomas Haller
thaller@redhat.com

2016-02-29T16:06:21+00:00

684e80b539c75ebd10ceac794288d9bb252e2a32

The argument is still always unset. We will need it later to set
IFA_F_NOPREFIXROUTE.





The argument is still always unset. We will need it later to set
IFA_F_NOPREFIXROUTE.







all: cleanup includes and let "nm-default.h" include "config.h"
2016-02-19T16:53:25+00:00

Thomas Haller
thaller@redhat.com

2016-02-19T13:57:48+00:00

8bace23bebcc28396460663203d54aac4ec8ffbf

- All internal source files (except "examples", which are not internal)
  should include "config.h" first. As also all internal source
  files should include "nm-default.h", let "config.h" be included
  by "nm-default.h" and include "nm-default.h" as first in every
  source file.
  We already wanted to include "nm-default.h" before other headers
  because it might contains some fixes (like "nm-glib.h" compatibility)
  that is required first.

- After including "nm-default.h", we optinally allow for including the
  corresponding header file for the source file at hand. The idea
  is to ensure that each header file is self contained.

- Don't include "config.h" or "nm-default.h" in any header file
  (except "nm-sd-adapt.h"). Public headers anyway must not include
  these headers, and internal headers are never included after
  "nm-default.h", as of the first previous point.

- Include all internal headers with quotes instead of angle brackets.
  In practice it doesn't matter, because in our public headers we must
  include other headers with angle brackets. As we use our public
  headers also to compile our interal source files, effectively the
  result must be the same. Still do it for consistency.

- Except for <config.h> itself. Include it with angle brackets as suggested by
  https://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers





- All internal source files (except "examples", which are not internal)
  should include "config.h" first. As also all internal source
  files should include "nm-default.h", let "config.h" be included
  by "nm-default.h" and include "nm-default.h" as first in every
  source file.
  We already wanted to include "nm-default.h" before other headers
  because it might contains some fixes (like "nm-glib.h" compatibility)
  that is required first.

- After including "nm-default.h", we optinally allow for including the
  corresponding header file for the source file at hand. The idea
  is to ensure that each header file is self contained.

- Don't include "config.h" or "nm-default.h" in any header file
  (except "nm-sd-adapt.h"). Public headers anyway must not include
  these headers, and internal headers are never included after
  "nm-default.h", as of the first previous point.

- Include all internal headers with quotes instead of angle brackets.
  In practice it doesn't matter, because in our public headers we must
  include other headers with angle brackets. As we use our public
  headers also to compile our interal source files, effectively the
  result must be the same. Still do it for consistency.

- Except for <config.h> itself. Include it with angle brackets as suggested by
  https://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers