Names are important. The previous name was counter intuitive for what the behavior was.
It translates to a plain memcmp() as the argument is a string literal.
The previous logging happened, when the value did not change. Log
instead, when the value changes.
Fixes: 86bb09c93be3 ('dns: generate correct search domain for hostnames on non-public TLD')
dns-manager uses the Mozilla Public Suffix List to determine an appropriate search domain when generating /etc/resolv.conf. It is presumed that if the hostname is "example.com", the user does not want to automatically search "com" for unqualified hostnames, which is reasonable. To implement that, prior to the fix, domain_is_valid() implicitly used the PSL "prevailing star rule", which had the consequence of assuming that any top-level domain (TLD) is public whether it is on the official suffix list or not. That meant "example.local" or "example.localdomain" would not result in searching "local" or "localdomain" respectively, but rather /etc/resolv.conf would contain the full hostname "example.local" as the search domain and not give users what they expect. The fix here uses the newer PSL API function that allows us to turn off the "prevailing star rule" so that "local" and "localdomain" are NOT considered public TLDs because they are not literally on the suffix list. That in turn gives us the search domain "local" or "localdomain" in /etc/resolv.conf and allows unqualified hostname lookups "e.g., resolvectl query example" to find example.local while example.com still maintains the previous behavior (i.e., search domain of "example.com" rather than "com"). [thaller@redhat.com: reworded commit message] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1281 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1613
G_SPAWN_CLOEXEC_PIPES is supported since glib 2.40, which we already depend on.
The global configuration now can be valid when there are no global
domains defined. The dnsmasq backend must process it and then, if
there is no global default domain, also process the per-connection
settings.
Fixes: 1f0d1d78d2a2 ('dns-manager: always apply options from [global-dns]')
The dns-type must be included in the hash because it contributes to
the generated composite configuration. Without this, when the type of
a configuration changes (e.g. from DEFAULT to BEST), the DNS manager
would determine that there was no change and it wouldn't call
update_dns().
https://bugzilla.redhat.com/show_bug.cgi?id=2161957
Fixes: 8995d44a0bae ('core: compare the DNS configurations before updating DNS')
(cherry picked from commit 46ccc82a81146132e4bc9c6cc96d7b8b2305f85f)
The enum will be used outside of core/dns. (cherry picked from commit 8a4632b56a1050ae155fef473582cae713321bce)
The function operates on a NML3ConfigData, rename it and move it to the right place. (cherry picked from commit ec0a83b224b313839357fb325ccede0f5a0c47c4)