<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git/m4, branch lr/python3</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>m4: parametrize flags variable</title>
<updated>2018-02-16T15:06:59+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2018-02-16T14:49:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=0999ebdf6d795a84e2afbc13282b400fbd6fd4b5'/>
<id>0999ebdf6d795a84e2afbc13282b400fbd6fd4b5</id>
<content type='text'>
Make it possible to add compiler options to a different variable than
CFLAGS. This is useful to conditionally disable a compiler warning for a
subpart of a tree.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make it possible to add compiler options to a different variable than
CFLAGS. This is useful to conditionally disable a compiler warning for a
subpart of a tree.
</pre>
</div>
</content>
</entry>
<entry>
<title>m4/trivial: add a bug link to a compiler warning check</title>
<updated>2018-02-08T16:11:46+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2018-02-07T20:01:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=422e87ec0d08d51c406b12be70d19e725d9cca4d'/>
<id>422e87ec0d08d51c406b12be70d19e725d9cca4d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>all: replace non-leading tabs with spaces</title>
<updated>2018-02-07T12:32:04+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-02-02T09:55:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e4839accf5a5b470b9bf2287f0269ddc4ce0f91b'/>
<id>e4839accf5a5b470b9bf2287f0269ddc4ce0f91b</id>
<content type='text'>
We commonly only allow tabs at the beginning of a line, not
afterwards. The reason for this style is so that the code
looks formated right with tabstop=4 and tabstop=8.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We commonly only allow tabs at the beginning of a line, not
afterwards. The reason for this style is so that the code
looks formated right with tabstop=4 and tabstop=8.
</pre>
</div>
</content>
</entry>
<entry>
<title>m4: disable -Wcast-function-type</title>
<updated>2018-02-07T10:46:56+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2018-02-07T10:23:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=631982a796a0eeb412551c61469a1cfb83e3f438'/>
<id>631982a796a0eeb412551c61469a1cfb83e3f438</id>
<content type='text'>
This fixes the GCC 8 build. It disables the warning conditionally so that we
get the warning back if glib gets fixed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes the GCC 8 build. It disables the warning conditionally so that we
get the warning back if glib gets fixed.
</pre>
</div>
</content>
</entry>
<entry>
<title>build: enable unused-but-set warning</title>
<updated>2017-12-18T12:29:32+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2017-12-18T07:27:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e912b36d95a3c26a6021eeb27e663bd05910a9b4'/>
<id>e912b36d95a3c26a6021eeb27e663bd05910a9b4</id>
<content type='text'>
It was disabled for shady reasons (not checking write() return value)
that are long gone. Worse even, it hid some real bugs.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It was disabled for shady reasons (not checking write() return value)
that are long gone. Worse even, it hid some real bugs.
</pre>
</div>
</content>
</entry>
<entry>
<title>build: add "-Wvla" to warn about uses of variable-length arrays</title>
<updated>2017-12-15T10:48:38+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2017-12-11T15:24:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=9c3402aa1e145420b868359e993b0a38ae9a6408'/>
<id>9c3402aa1e145420b868359e993b0a38ae9a6408</id>
<content type='text'>
We don't use them, so add a compiler warning about their use.
I think they are annoying, because sizeof(x) and typeof(x) might
evaluate at runtime. Especially the typeof() extension is useful
for macros, but behaves badly with variable-length arrays due to
running code at runtime.

But the worst is, G_STATIC_ASSERT() is implemented by declaring
an array of negative length. Usually, the checked condition should
be a compile time constant, but with VLAs the compiler would not evaluate
the static-assert at compile time and instead accept it silently. It's easy
to mess up static asserts to wrongly have a non-constant condition,
especially when the static-assert is used inside a macro.

Just say no.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We don't use them, so add a compiler warning about their use.
I think they are annoying, because sizeof(x) and typeof(x) might
evaluate at runtime. Especially the typeof() extension is useful
for macros, but behaves badly with variable-length arrays due to
running code at runtime.

But the worst is, G_STATIC_ASSERT() is implemented by declaring
an array of negative length. Usually, the checked condition should
be a compile time constant, but with VLAs the compiler would not evaluate
the static-assert at compile time and instead accept it silently. It's easy
to mess up static asserts to wrongly have a non-constant condition,
especially when the static-assert is used inside a macro.

Just say no.
</pre>
</div>
</content>
</entry>
<entry>
<title>build: disable lcov version check</title>
<updated>2017-10-20T15:16:22+00:00</updated>
<author>
<name>Beniamino Galvani</name>
<email>bgalvani@redhat.com</email>
</author>
<published>2017-10-20T11:39:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=b3b9b2bf384710f7fe90bc85a837465c2e47b7c4'/>
<id>b3b9b2bf384710f7fe90bc85a837465c2e47b7c4</id>
<content type='text'>
Ideally we should switch to the standard macro AX_CODE_COVERAGE for
code coverage, but infortunately it's not supported on older distros
(e.g. on Travis).

Keep using the current macro, but remove the lcov version check as
it's not clear why it's needed in the first place (see [1]). The
latest version of lcov is now 1.13.

[1] http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=commit;h=dedd290bdb647704d74c13992bd04275d9cb648e
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ideally we should switch to the standard macro AX_CODE_COVERAGE for
code coverage, but infortunately it's not supported on older distros
(e.g. on Travis).

Keep using the current macro, but remove the lcov version check as
it's not clear why it's needed in the first place (see [1]). The
latest version of lcov is now 1.13.

[1] http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=commit;h=dedd290bdb647704d74c13992bd04275d9cb648e
</pre>
</div>
</content>
</entry>
<entry>
<title>build: enable -Wlogical-op and -Wshift-negative-value compiler warning</title>
<updated>2017-05-18T16:21:27+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2017-05-18T16:11:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=41e7fca59762dc928c9d67b555b1409c3477b2b0'/>
<id>41e7fca59762dc928c9d67b555b1409c3477b2b0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>m4: disable -Wmissing-braces for newer clang</title>
<updated>2017-04-18T07:44:45+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2017-04-15T10:23:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=928d68d04af20808f801f05f92ad83179d7b826e'/>
<id>928d68d04af20808f801f05f92ad83179d7b826e</id>
<content type='text'>
  src/NetworkManagerUtils.c:347:18: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
          NMIPAddr a1 = { 0 }, a2 = { 0 };
                          ^
                          {}

Should we initialize unions this way? I think it's all right -- the initializer
works well and { { { 0 } } } is probably not what we'd like to see.

(cherry picked from commit 43012156a31fb452ba774196baf106027c2c9067)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
  src/NetworkManagerUtils.c:347:18: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
          NMIPAddr a1 = { 0 }, a2 = { 0 };
                          ^
                          {}

Should we initialize unions this way? I think it's all right -- the initializer
works well and { { { 0 } } } is probably not what we'd like to see.

(cherry picked from commit 43012156a31fb452ba774196baf106027c2c9067)
</pre>
</div>
</content>
</entry>
<entry>
<title>build: test for support of -flto compiler flag</title>
<updated>2017-02-10T11:53:32+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2017-02-10T11:22:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=923c52ffbb79526ca711fa98b5e865d210d01941'/>
<id>923c52ffbb79526ca711fa98b5e865d210d01941</id>
<content type='text'>
... and prepend the $ld_gc_flags instead of appending to the $CFLAGS.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
... and prepend the $ld_gc_flags instead of appending to the $CFLAGS.
</pre>
</div>
</content>
</entry>
</feed>
