<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git/contrib/scripts, branch th/fix-python-test</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>contrib/checkpatch: fix the systemd code path</title>
<updated>2019-09-10T09:20:03+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-09-10T08:58:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=ae6668ae85d313b028f9e14e21fb81a050ad01b5'/>
<id>ae6668ae85d313b028f9e14e21fb81a050ad01b5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: check for SPDX tags</title>
<updated>2019-09-10T09:20:03+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-09-10T08:41:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=1b0ee8756ba08c2334a89c162722f6bdd13718de'/>
<id>1b0ee8756ba08c2334a89c162722f6bdd13718de</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>all: SPDX header conversion</title>
<updated>2019-09-10T09:19:56+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-09-10T09:19:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=24028a22467275671df71cc6a8054036b37d8f03'/>
<id>24028a22467275671df71cc6a8054036b37d8f03</id>
<content type='text'>
  $ find * -type f |xargs perl contrib/scripts/spdx.pl
  $ git rm contrib/scripts/spdx.pl
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
  $ find * -type f |xargs perl contrib/scripts/spdx.pl
  $ git rm contrib/scripts/spdx.pl
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/spdx: add a tool that determines SPDX licensing headers</title>
<updated>2019-09-10T09:18:49+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-09-08T11:46:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e4784327c0f1da74a78428b07d29c74bf6fa5a53'/>
<id>e4784327c0f1da74a78428b07d29c74bf6fa5a53</id>
<content type='text'>
This is a one-off hacky tool that we'll use to convert the long license
boilerplates to SPDX headers that are more friendly to automated tools.

Then we can drop it and forget it existed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is a one-off hacky tool that we'll use to convert the long license
boilerplates to SPDX headers that are more friendly to automated tools.

Then we can drop it and forget it existed.
</pre>
</div>
</content>
</entry>
<entry>
<title>dhcp: add nettools dhcp4 client</title>
<updated>2019-07-05T09:04:32+00:00</updated>
<author>
<name>Tom Gundersen</name>
<email>teg@jklm.no</email>
</author>
<published>2019-05-13T18:02:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=6adade6f21d5fefd0a00abee64f99ff96a54f0f3'/>
<id>6adade6f21d5fefd0a00abee64f99ff96a54f0f3</id>
<content type='text'>
This is inspired by the existing systemd integration, with a few differences:

* This parses the WPAD option, which systemd requested, but did not use.
* We hook into the DAD handling, only making use of the configured address
  once DAD has completed successfully, and declining the lease if it fails.

There are still many areas of possible improvement. In particular, we need
to ensure the parsing of all options are compliant, as n-dhcp4 treats all
options as opaque, unlike sd-dhcp4. We probably also need to look at how
to handle failures and retries (in particular if we decline a lease).

We need to query the current MTU at client startu, as well as the hardware
broadcast address. Both these are provided by the kernel over netlink, so
it should simply be a matter of hooking that up with NM's netlink layer.

Contribution under LGPL2.0+, in addition to stated licenses.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is inspired by the existing systemd integration, with a few differences:

* This parses the WPAD option, which systemd requested, but did not use.
* We hook into the DAD handling, only making use of the configured address
  once DAD has completed successfully, and declining the lease if it fails.

There are still many areas of possible improvement. In particular, we need
to ensure the parsing of all options are compliant, as n-dhcp4 treats all
options as opaque, unlike sd-dhcp4. We probably also need to look at how
to handle failures and retries (in particular if we decline a lease).

We need to query the current MTU at client startu, as well as the hardware
broadcast address. Both these are provided by the kernel over netlink, so
it should simply be a matter of hooking that up with NM's netlink layer.

Contribution under LGPL2.0+, in addition to stated licenses.
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: allow empty lines within continuations</title>
<updated>2019-06-25T18:27:39+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-06-25T08:54:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=a5dd31afeb3c9efe12620b57c59ba60694e37c31'/>
<id>a5dd31afeb3c9efe12620b57c59ba60694e37c31</id>
<content type='text'>
This chunk from nm-device.c is, in fact, okay:

               |&lt;-tab-&gt;nm_assert (   !new_config
               |&lt;-tab-&gt;           || (   new_config
               |&lt;-tab-&gt;               &amp;&amp; ({
               |&lt;-tab-&gt;                    int ip_ifindex = ...
 empty line -&gt; |
               |&lt;-tab-&gt;                    (   ip_ifindex &gt; 0
               |&lt;-tab-&gt;                     &amp;&amp; ip_ifindex == ...
               |&lt;-tab-&gt;                  })));
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This chunk from nm-device.c is, in fact, okay:

               |&lt;-tab-&gt;nm_assert (   !new_config
               |&lt;-tab-&gt;           || (   new_config
               |&lt;-tab-&gt;               &amp;&amp; ({
               |&lt;-tab-&gt;                    int ip_ifindex = ...
 empty line -&gt; |
               |&lt;-tab-&gt;                    (   ip_ifindex &gt; 0
               |&lt;-tab-&gt;                     &amp;&amp; ip_ifindex == ...
               |&lt;-tab-&gt;                  })));
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: be a bit stricter about whitespace</title>
<updated>2019-06-25T18:27:39+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-06-25T08:13:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=da312e62207476624f21efe7be75bcc13e7397b9'/>
<id>da312e62207476624f21efe7be75bcc13e7397b9</id>
<content type='text'>
In continations (that use spaces for alignment), don't allow the number
of leading tabs to change. Previously only removal of tabs was
disallowed, but addition doesn't make sense either, as only spaces
should be used for further alignemnt.

This catches situations like this:

  |&lt;-tab-&gt;all_work_and_no_play (makes,
  |&lt;-tab-&gt;                      jack,
  |&lt;-tab-&gt;&lt;-tab-&gt;               a dull boy);
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In continations (that use spaces for alignment), don't allow the number
of leading tabs to change. Previously only removal of tabs was
disallowed, but addition doesn't make sense either, as only spaces
should be used for further alignemnt.

This catches situations like this:

  |&lt;-tab-&gt;all_work_and_no_play (makes,
  |&lt;-tab-&gt;                      jack,
  |&lt;-tab-&gt;&lt;-tab-&gt;               a dull boy);
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: discourage g_assert*()</title>
<updated>2019-06-25T18:27:39+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-06-25T08:46:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=5ff19ea8d24e6b3751c4356727664ea51f879010'/>
<id>5ff19ea8d24e6b3751c4356727664ea51f879010</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>settings: drop ibft settings plugin</title>
<updated>2019-06-20T14:06:44+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2019-06-19T05:47:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=74641be816a201fdb704a7a8084a791ea5c76c9f'/>
<id>74641be816a201fdb704a7a8084a791ea5c76c9f</id>
<content type='text'>
The functionality of the ibft settings plugin is now handled by
nm-initrd-generator. There is no need for it anymore, drop it.

Note that ibft called iscsiadm, which requires CAP_SYS_ADMIN to work
([1]). We really want to drop this capability, so the current solution
of a settings plugin (as it is implemented) is wrong. The solution
instead is nm-initrd-generator.

Also, on Fedora the ibft was disabled and probably on most other
distributions as well. This was only used on RHEL.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1371201#c7
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The functionality of the ibft settings plugin is now handled by
nm-initrd-generator. There is no need for it anymore, drop it.

Note that ibft called iscsiadm, which requires CAP_SYS_ADMIN to work
([1]). We really want to drop this capability, so the current solution
of a settings plugin (as it is implemented) is wrong. The solution
instead is nm-initrd-generator.

Also, on Fedora the ibft was disabled and probably on most other
distributions as well. This was only used on RHEL.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1371201#c7
</pre>
</div>
</content>
</entry>
<entry>
<title>all: drop vim file variables from source files</title>
<updated>2019-06-11T08:08:07+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2019-06-02T12:32:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=3c47285f4a8df1c7d3648e03bf7f3b6626ccf15a'/>
<id>3c47285f4a8df1c7d3648e03bf7f3b6626ccf15a</id>
<content type='text'>
  sed '1,3 { /^\(#\|--\) *vim:/d }; 1 { /^\/\* *vim:.*\*\/$/ d}' -i $(git grep -l 'vim:')
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
  sed '1,3 { /^\(#\|--\) *vim:/d }; 1 { /^\/\* *vim:.*\*\/$/ d}' -i $(git grep -l 'vim:')
</pre>
</div>
</content>
</entry>
</feed>
