<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git/contrib/scripts/checkpatch.pl, branch th/fix-python-test</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>contrib/checkpatch: fix the systemd code path</title>
<updated>2019-09-10T09:20:03+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-09-10T08:58:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=ae6668ae85d313b028f9e14e21fb81a050ad01b5'/>
<id>ae6668ae85d313b028f9e14e21fb81a050ad01b5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: check for SPDX tags</title>
<updated>2019-09-10T09:20:03+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-09-10T08:41:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=1b0ee8756ba08c2334a89c162722f6bdd13718de'/>
<id>1b0ee8756ba08c2334a89c162722f6bdd13718de</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>all: SPDX header conversion</title>
<updated>2019-09-10T09:19:56+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-09-10T09:19:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=24028a22467275671df71cc6a8054036b37d8f03'/>
<id>24028a22467275671df71cc6a8054036b37d8f03</id>
<content type='text'>
  $ find * -type f |xargs perl contrib/scripts/spdx.pl
  $ git rm contrib/scripts/spdx.pl
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
  $ find * -type f |xargs perl contrib/scripts/spdx.pl
  $ git rm contrib/scripts/spdx.pl
</pre>
</div>
</content>
</entry>
<entry>
<title>dhcp: add nettools dhcp4 client</title>
<updated>2019-07-05T09:04:32+00:00</updated>
<author>
<name>Tom Gundersen</name>
<email>teg@jklm.no</email>
</author>
<published>2019-05-13T18:02:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=6adade6f21d5fefd0a00abee64f99ff96a54f0f3'/>
<id>6adade6f21d5fefd0a00abee64f99ff96a54f0f3</id>
<content type='text'>
This is inspired by the existing systemd integration, with a few differences:

* This parses the WPAD option, which systemd requested, but did not use.
* We hook into the DAD handling, only making use of the configured address
  once DAD has completed successfully, and declining the lease if it fails.

There are still many areas of possible improvement. In particular, we need
to ensure the parsing of all options are compliant, as n-dhcp4 treats all
options as opaque, unlike sd-dhcp4. We probably also need to look at how
to handle failures and retries (in particular if we decline a lease).

We need to query the current MTU at client startu, as well as the hardware
broadcast address. Both these are provided by the kernel over netlink, so
it should simply be a matter of hooking that up with NM's netlink layer.

Contribution under LGPL2.0+, in addition to stated licenses.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is inspired by the existing systemd integration, with a few differences:

* This parses the WPAD option, which systemd requested, but did not use.
* We hook into the DAD handling, only making use of the configured address
  once DAD has completed successfully, and declining the lease if it fails.

There are still many areas of possible improvement. In particular, we need
to ensure the parsing of all options are compliant, as n-dhcp4 treats all
options as opaque, unlike sd-dhcp4. We probably also need to look at how
to handle failures and retries (in particular if we decline a lease).

We need to query the current MTU at client startu, as well as the hardware
broadcast address. Both these are provided by the kernel over netlink, so
it should simply be a matter of hooking that up with NM's netlink layer.

Contribution under LGPL2.0+, in addition to stated licenses.
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: allow empty lines within continuations</title>
<updated>2019-06-25T18:27:39+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-06-25T08:54:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=a5dd31afeb3c9efe12620b57c59ba60694e37c31'/>
<id>a5dd31afeb3c9efe12620b57c59ba60694e37c31</id>
<content type='text'>
This chunk from nm-device.c is, in fact, okay:

               |&lt;-tab-&gt;nm_assert (   !new_config
               |&lt;-tab-&gt;           || (   new_config
               |&lt;-tab-&gt;               &amp;&amp; ({
               |&lt;-tab-&gt;                    int ip_ifindex = ...
 empty line -&gt; |
               |&lt;-tab-&gt;                    (   ip_ifindex &gt; 0
               |&lt;-tab-&gt;                     &amp;&amp; ip_ifindex == ...
               |&lt;-tab-&gt;                  })));
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This chunk from nm-device.c is, in fact, okay:

               |&lt;-tab-&gt;nm_assert (   !new_config
               |&lt;-tab-&gt;           || (   new_config
               |&lt;-tab-&gt;               &amp;&amp; ({
               |&lt;-tab-&gt;                    int ip_ifindex = ...
 empty line -&gt; |
               |&lt;-tab-&gt;                    (   ip_ifindex &gt; 0
               |&lt;-tab-&gt;                     &amp;&amp; ip_ifindex == ...
               |&lt;-tab-&gt;                  })));
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: be a bit stricter about whitespace</title>
<updated>2019-06-25T18:27:39+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-06-25T08:13:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=da312e62207476624f21efe7be75bcc13e7397b9'/>
<id>da312e62207476624f21efe7be75bcc13e7397b9</id>
<content type='text'>
In continations (that use spaces for alignment), don't allow the number
of leading tabs to change. Previously only removal of tabs was
disallowed, but addition doesn't make sense either, as only spaces
should be used for further alignemnt.

This catches situations like this:

  |&lt;-tab-&gt;all_work_and_no_play (makes,
  |&lt;-tab-&gt;                      jack,
  |&lt;-tab-&gt;&lt;-tab-&gt;               a dull boy);
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In continations (that use spaces for alignment), don't allow the number
of leading tabs to change. Previously only removal of tabs was
disallowed, but addition doesn't make sense either, as only spaces
should be used for further alignemnt.

This catches situations like this:

  |&lt;-tab-&gt;all_work_and_no_play (makes,
  |&lt;-tab-&gt;                      jack,
  |&lt;-tab-&gt;&lt;-tab-&gt;               a dull boy);
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: discourage g_assert*()</title>
<updated>2019-06-25T18:27:39+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-06-25T08:46:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=5ff19ea8d24e6b3751c4356727664ea51f879010'/>
<id>5ff19ea8d24e6b3751c4356727664ea51f879010</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: properly determine the commit id boundary</title>
<updated>2019-05-20T14:31:52+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-05-17T17:48:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=f3f8e21bd31a64e994a3cabeedea5242674f7f3c'/>
<id>f3f8e21bd31a64e994a3cabeedea5242674f7f3c</id>
<content type='text'>
It doesn't have to be at the end of line, there may be more words
following.

Fixes: d66a1ace23c5 ('contrib/checkpatch: avoid command injection in checkpatch.pl script')
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It doesn't have to be at the end of line, there may be more words
following.

Fixes: d66a1ace23c5 ('contrib/checkpatch: avoid command injection in checkpatch.pl script')
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: avoid command injection in checkpatch.pl script</title>
<updated>2019-03-18T10:57:04+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2019-03-18T10:34:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=d66a1ace23c5a9fcedefb2b36f328da4972c5d9e'/>
<id>d66a1ace23c5a9fcedefb2b36f328da4972c5d9e</id>
<content type='text'>
The capture variables, $1, etc, are not valid unless the match
succeeded, and they're not cleared, either.

    $ git checkout -B C origin/master &amp;&amp; \
        echo XXXXX &gt; f.txt &amp;&amp; \
        git add f.txt &amp;&amp; \
        git commit -m 'this commit does something()'
    Branch 'C' set up to track remote branch 'master' from 'origin'.
    Reset branch 'C'
    Your branch is up to date with 'origin/master'.
    sh: -c: line 0: syntax error near unexpected token `('
    sh: -c: line 0: `git log --abbrev=12 --pretty=format:"%h ('%s')" -1 does something() 2&gt;/dev/null'

    &gt;&gt;&gt; VALIDATE "a169a98e14 this commit does something()"
    (commit message):4: Commit 'does something()' does not seem to exist:
    &gt; Subject: [PATCH] this commit does something()

    (commit message):4: Refer to the commit id properly: :
    &gt; Subject: [PATCH] this commit does something()

    The patch does not validate.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The capture variables, $1, etc, are not valid unless the match
succeeded, and they're not cleared, either.

    $ git checkout -B C origin/master &amp;&amp; \
        echo XXXXX &gt; f.txt &amp;&amp; \
        git add f.txt &amp;&amp; \
        git commit -m 'this commit does something()'
    Branch 'C' set up to track remote branch 'master' from 'origin'.
    Reset branch 'C'
    Your branch is up to date with 'origin/master'.
    sh: -c: line 0: syntax error near unexpected token `('
    sh: -c: line 0: `git log --abbrev=12 --pretty=format:"%h ('%s')" -1 does something() 2&gt;/dev/null'

    &gt;&gt;&gt; VALIDATE "a169a98e14 this commit does something()"
    (commit message):4: Commit 'does something()' does not seem to exist:
    &gt; Subject: [PATCH] this commit does something()

    (commit message):4: Refer to the commit id properly: :
    &gt; Subject: [PATCH] this commit does something()

    The patch does not validate.
</pre>
</div>
</content>
</entry>
<entry>
<title>contrib/checkpatch: check that we refer to commits properly</title>
<updated>2019-03-07T21:29:41+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2019-03-07T09:16:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=f2a5b6336d7d7cb062adf75716224a54d8b0bb10'/>
<id>f2a5b6336d7d7cb062adf75716224a54d8b0bb10</id>
<content type='text'>
(cherry picked from commit f8578ddc2e6382d31e1a40b1189ca71cfda427e1)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
(cherry picked from commit f8578ddc2e6382d31e1a40b1189ca71cfda427e1)
</pre>
</div>
</content>
</entry>
</feed>
