<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git/clients/tests, branch lr/python3</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>cli: fix property matching</title>
<updated>2018-05-28T09:33:40+00:00</updated>
<author>
<name>Beniamino Galvani</name>
<email>bgalvani@redhat.com</email>
</author>
<published>2018-05-25T16:00:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=1f7780cba9a7446e04c32a765fa72585829c0eec'/>
<id>1f7780cba9a7446e04c32a765fa72585829c0eec</id>
<content type='text'>
@ret was not initialized when there was only one partial match.

Also, refactor the code to return all matching values.

Fixes: 3fd9bf9d7d9fc0290fd25f709b60a3a8f5c7e334

https://github.com/NetworkManager/NetworkManager/pull/123
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
@ret was not initialized when there was only one partial match.

Also, refactor the code to return all matching values.

Fixes: 3fd9bf9d7d9fc0290fd25f709b60a3a8f5c7e334

https://github.com/NetworkManager/NetworkManager/pull/123
</pre>
</div>
</content>
</entry>
<entry>
<title>clients/tests: refactor by moving replace-text helper function</title>
<updated>2018-05-28T06:57:29+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-28T06:57:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=78e877ee3c030762569513b6822852813edf53ec'/>
<id>78e877ee3c030762569513b6822852813edf53ec</id>
<content type='text'>
Have less logic in TestNmcli.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Have less logic in TestNmcli.
</pre>
</div>
</content>
</entry>
<entry>
<title>clients/tests: generate Makefile.am for expected files</title>
<updated>2018-05-27T20:25:44+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-27T18:58:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=ee85151a4ad400a1e43aa50d47a083f1d1d46584'/>
<id>ee85151a4ad400a1e43aa50d47a083f1d1d46584</id>
<content type='text'>
The developer can re-generate .expected files with

 $ NM_TEST_REGENERATE=1 ./clients/tests/test-client.py

Note that these files are also dist-ed, so that the tests also work
from a source-tarball. For that, we need to add them to EXTRA_DIST.

Previously, this was done manually in the base Makefile.am file. This
was cumbersome, because when adding a new test, the developer would need
to manually add the files.

Now, let the test (with NM_TEST_REGENERATE=1) also generate a makefile
part.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The developer can re-generate .expected files with

 $ NM_TEST_REGENERATE=1 ./clients/tests/test-client.py

Note that these files are also dist-ed, so that the tests also work
from a source-tarball. For that, we need to add them to EXTRA_DIST.

Previously, this was done manually in the base Makefile.am file. This
was cumbersome, because when adding a new test, the developer would need
to manually add the files.

Now, let the test (with NM_TEST_REGENERATE=1) also generate a makefile
part.
</pre>
</div>
</content>
</entry>
<entry>
<title>cli: avoid bogus line seprator in pretty-output</title>
<updated>2018-05-25T15:36:47+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-04-26T19:09:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e1bbc2e1556e8211054f14a5da4f43cded83a3e1'/>
<id>e1bbc2e1556e8211054f14a5da4f43cded83a3e1</id>
<content type='text'>
This bug resulted in spurious lines with "--pretty --mode tabular",
whenever nmc_print() was called with multiple rows.

Currently, the only case where this was visible was with:

  $ nmcli --pretty general permissions

(note that "--mode tabular" is the default).

Fixes: 16299e5ac0a8882e13d42122278013b74bc6d34d
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This bug resulted in spurious lines with "--pretty --mode tabular",
whenever nmc_print() was called with multiple rows.

Currently, the only case where this was visible was with:

  $ nmcli --pretty general permissions

(note that "--mode tabular" is the default).

Fixes: 16299e5ac0a8882e13d42122278013b74bc6d34d
</pre>
</div>
</content>
</entry>
<entry>
<title>cli/tests: add test for output of `nmcli general permissions`</title>
<updated>2018-05-25T15:24:57+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-25T15:14:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=5090c1f2556909a9f4404ee0ec89d712a92b40d8'/>
<id>5090c1f2556909a9f4404ee0ec89d712a92b40d8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>clients/tests: drop duplicate tests for German translation</title>
<updated>2018-05-24T14:40:17+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T15:12:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=41dbf2b9d36d5eae53a594180d5334c134cbe18c'/>
<id>41dbf2b9d36d5eae53a594180d5334c134cbe18c</id>
<content type='text'>
call_nmcli_l() would test for 3 languages: 'C', 'de', and 'pl'. There
is no fundamental difference between 'de' and 'pl', so there is no need
to test for two languages.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
call_nmcli_l() would test for 3 languages: 'C', 'de', and 'pl'. There
is no fundamental difference between 'de' and 'pl', so there is no need
to test for two languages.
</pre>
</div>
</content>
</entry>
<entry>
<title>clients/tests: test nmcli output for active-connection state DEACTIVATING</title>
<updated>2018-05-24T14:40:17+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T14:39:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=2cae37ca40886c8edaf524406ad61ab1b92aff3d'/>
<id>2cae37ca40886c8edaf524406ad61ab1b92aff3d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>clients/tests: load libnm via GObject introspection</title>
<updated>2018-05-24T14:40:17+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T14:38:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=6f82c880a655509b18ad384e6c2cc5f67a4d0377'/>
<id>6f82c880a655509b18ad384e6c2cc5f67a4d0377</id>
<content type='text'>
We will use it, and it must be available anyway, because the stub server
also requires it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We will use it, and it must be available anyway, because the stub server
also requires it.
</pre>
</div>
</content>
</entry>
<entry>
<title>clients/tests: add SetProperties operation to test-networkmanager-service.py stub</title>
<updated>2018-05-24T14:40:17+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T14:20:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=d424de10bf6d2228d36dadf3568a74a3e505e647'/>
<id>d424de10bf6d2228d36dadf3568a74a3e505e647</id>
<content type='text'>
It is a hook to set one or several D-Bus properties at once. Properties that are
to be set-able, have to be whitelisted in the stub.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It is a hook to set one or several D-Bus properties at once. Properties that are
to be set-able, have to be whitelisted in the stub.
</pre>
</div>
</content>
</entry>
<entry>
<title>clients/tests: test nmcli output for multiple activation of same profile</title>
<updated>2018-05-24T14:40:17+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-05-15T10:06:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=7ae5fb7ec61f7215b3d609f656403b432ca20028'/>
<id>7ae5fb7ec61f7215b3d609f656403b432ca20028</id>
<content type='text'>
Activate the same profile on two devices. Arguably, real NetworkManager
(currently) does not allow that. But the D-Bus API is fine with
having multiple ActiveConnections for one SettingsConnection.

So, also the client should do something sensible.

Also, later we will add wildcard support to NetworkManager, which means
that a profile can be active multiple times (simultaneously).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Activate the same profile on two devices. Arguably, real NetworkManager
(currently) does not allow that. But the D-Bus API is fine with
having multiple ActiveConnections for one SettingsConnection.

So, also the client should do something sensible.

Also, later we will add wildcard support to NetworkManager, which means
that a profile can be active multiple times (simultaneously).
</pre>
</div>
</content>
</entry>
</feed>
