delta/NetworkManager.git/cli/src/nmcli.c, branch th/NMStringTable

nmcli: fix some leaks found by valgrind

2013-10-24T02:22:35+00:00

https://bugzilla.gnome.org/show_bug.cgi?id=709369

cli: reset terminal using libreadline when quitting on signal (bgo #706118)

2013-09-10T09:45:21+00:00

readline() makes changes to terminal and when it doesn't receive unix signals,
it has no chance to perform cleanups on exit. So we have to call its cleanup
functions manually on exit.

https://bugzilla.gnome.org/show_bug.cgi?id=706118

cli: handle POSIX signals in a dedicated thread

2013-09-10T09:41:00+00:00

For a multihreaded application the safest way to handle unix signals is using
a dedicated thread that processes the signals by sigwait() function. All other
threads have these signals (processed by the thread) blocked.

A few useful links:
http://pubs.opengroup.org/onlinepubs/007904975/functions/sigwait.html
http://pic.dhe.ibm.com/infocenter/aix/v6r1/index.jsp?topic=%2Fcom.ibm.aix.genprogc%2Fdoc%2Fgenprogc%2Fsignal_mgmt.htm
http://www.linuxjournal.com/article/2121?page=0,2
http://www.redwoodsoft.com/~dru/unixbook/book.chinaunix.net/special/ebook/addisonWesley/APUE2/0201433079/ch12lev1sec8.html
https://www.securecoding.cert.org/confluence/display/seccode/CON37-C.+Do+not+call+signal%28%29+in+a+multithreaded+program

cli: confirm connection saving when autoconnect=yes (rh #953296)

2013-07-30T12:04:52+00:00

Ask for confirmation in these cases:
* autoconnect=yes and connection has not been saved yet
* autoconnect=yes, but saved connection had autoconnect=no

The confirmation can be switched off with
nmcli> nmcli save-confirmation no

cli: add 'nmcli' command for nmcli connection editor configuration

2013-07-22T11:37:16+00:00

- show/hide status line:  nmcli> nmcli status-line yes | no
- editor prompt color:    nmcli> nmcli prompt-color <0-8>  (0 = normal/without color)

cli: enhance printing to align tabular output properly and not to waste space

2013-05-31T07:38:03+00:00

Until now we have used a static width defined for each column for tabular
output. Even if this worked in most cases, it was not optimal, because by
using too wide columns we wasted space, and in case of a too narrow column the
alignment broke. So, we need to know the longest string in a column to be able
to align columns in the tabular output. Thus, the printing has to be postponed
till we have all data available, and can find the widest column. This value is
then used for aligning while printing the data.

Arrays of NmcOutputField (rows) are inserted into output_data array. When all
data have been added, print_data() can be used to print the whole output_data
array with proper alignment.

A single row can be printed using print_required_fields().

Also, output flags are redone to better match the new output_data array.
The flags are needed for every row (in tabular output); they are stored in
the first field (NmcOutputField) for the whole row.

Addapted set_val_str() and set_val_arr() to set value type (char * x char **).
Added set_val_strc(), set_val_arrc() for const values that should not be freed.

output_data takes ownership of the data added to it and takes care of freeing
the memory.

See e.g.
https://bugzilla.gnome.org/show_bug.cgi?id=699503

cli: add global '--wait ' option - timeout waiting for operations

2013-05-16T08:28:40+00:00

--wait <0-maxint>

0    : means "do not wait". nmcli exits immediatelly with success.
1... : if operation doesn't finish within the timeout, nmcli exits with an error

cli: remove obsolete 'nmcli nm'

2013-04-24T08:04:43+00:00

The functionality is present in 'general', 'networking' and 'radio'.
We changed syntax anyway, so it doesn't make much sense to keep 'nm'.

cli: accept shortcuts for --mode and --escape arguments

2013-04-24T08:04:33+00:00

--mode tabular | multiline  -->  --mode t | m
--escape yes | no           -->  --escape y | n

cli: split 'nmcli switch' --> 'nmcli networking' and 'nmcli radio'

2013-04-08T21:14:11+00:00